GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make New-Item -Force overwrite on Junction by GigaScratch · Pull Request #18311 · PowerShell/PowerShell

Conversation

@GigaScratch

@GigaScratch Olivia (GigaScratch) commented Oct 17, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

When performing New-Item <itemname> -Type Junction -Value <path> -Force, it will fail with "<path> cannot be removed because it is not empty.".

This has been resolved by moving the Child Item check from before force is checked, to the else condition of the force check.

PR Context

This PR aims to fix #17656.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@GigaScratch
Olivia (GigaScratch) requested a review from Andrew (anmenaga) as a code owner October 17, 2022 06:12
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Small label Oct 17, 2022
@ghost ghost assigned Ilya (iSazonov) Oct 17, 2022
@ghost

Deleted user (ghost) commented Oct 17, 2022 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@GigaScratch

Olivia (GigaScratch) commented Oct 17, 2022

Copy link
Copy Markdown
Contributor Author

Making this WIP as my build environment is unhappy so I'll be testing off the build artifact. 😅

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

GigaScratch
Olivia (GigaScratch) commented Oct 17, 2022
View reviewed changes
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov

Ilya (iSazonov) commented Oct 17, 2022

Copy link
Copy Markdown
Collaborator

Olivia (@GigaScratch) Please add a test.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 17, 2022
@GigaScratch

Olivia (GigaScratch) commented Oct 18, 2022

Copy link
Copy Markdown
Contributor Author

Olivia (@GigaScratch) Please add a test.
Ilya (@iSazonov) Can you please provide guideance as to where tests for New-Item/ FileSystemProvidershould go? I tried searching for New-Item and Junction and System.Mangement.Automation through a few contexts but they're broadly used in standard PS tests so much that I can't actually find the test area dedicated to them.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov

Ilya (iSazonov) commented Oct 18, 2022

Copy link
Copy Markdown
Collaborator

You could look
Describe "Hard link and symbolic link tests" -Tags "CI", "RequireAdminOnWindows"
in FileSystem.Tests.ps1

GigaScratch reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@GigaScratch

Olivia (GigaScratch) commented Oct 18, 2022

Copy link
Copy Markdown
Contributor Author

Please add a test.

I added a simple overwrite test, but ideally I would like a way to verify that the object created is actually new and to throw an error if it is not.
In a FAT32 or EXFAT FS I would just compare the creation date by epoch, but afaik Windows doesn't store the milliseconds in item creation 😐. Is there a way you would recommend to compare the first and second junction to verify the second is actually new?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov

Ilya (iSazonov) commented Oct 18, 2022

Copy link
Copy Markdown
Collaborator

You could use another target in second New-Item and check that target is changed after first command.

GigaScratch reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@GigaScratch Olivia (GigaScratch) changed the title WIP:Make New-Item -Force overwrite on Junction Make New-Item -Force overwrite on Junction Oct 18, 2022
iSazonov
Ilya (iSazonov) requested changes Oct 18, 2022
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 18, 2022
@iSazonov Ilya (iSazonov) added the Hacktoberfest-Accepted Accepted to participate in Hacktoberfest label Oct 18, 2022
@iSazonov
Ilya (iSazonov) requested a review from Steve Lee (SteveL-MSFT) October 18, 2022 10:59
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 19, 2022
iSazonov
Ilya (iSazonov) reviewed Oct 19, 2022
View reviewed changes
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov Ilya (iSazonov) added the Hacktoberfest Potential candidate to participate in Hacktoberfest label Oct 19, 2022
iSazonov
Ilya (iSazonov) reviewed Oct 19, 2022
View reviewed changes
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

iSazonov
Ilya (iSazonov) reviewed Oct 19, 2022
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

iSazonov
Ilya (iSazonov) reviewed Oct 19, 2022
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

iSazonov
Ilya (iSazonov) reviewed Oct 19, 2022
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

@GigaScratch

Olivia (GigaScratch) commented Oct 19, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

1 similar comment
@GigaScratch

Olivia (GigaScratch) commented Oct 19, 2022

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iSazonov
Ilya (iSazonov) approved these changes Oct 20, 2022
View reviewed changes
@ghost ghost added the Review - Needed The PR is being reviewed label Oct 27, 2022
@ghost

Deleted user (ghost) commented Oct 27, 2022

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Olivia @daxian-dbw
Refactor New-Item for Junction to allow force on Dir with Childitems
c329021
Olivia and others added 8 commits May 1, 2023 22:29
Olivia @daxian-dbw
Put on my glasses before moving code
63a9aff
Olivia @daxian-dbw
Recreate path after delete.
81d66c4
Olivia @daxian-dbw
Add target check to test (WIP)
9ee044e
Olivia @daxian-dbw
add setup to get error to throw
dda7688
Olivia @daxian-dbw
Move lines out of try/catch to avoid race condition
8fe15e5
Olivia @daxian-dbw
caught fleeing brace
575d444
@GigaScratch @iSazonov @daxian-dbw
Update src/System.Management.Automation/namespaces/FileSystemProvider.cs
c6288ef
Co-authored-by: Ilya <[email protected]>
@daxian-dbw
Apply a fix to the change
53a65d5
@daxian-dbw
Dongbo Wang (daxian-dbw) force-pushed the JunctionForceFix branch from 82c5a86 to 53a65d5 Compare May 2, 2023 05:48
@daxian-dbw
Minor change to the test
869cb6c
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented May 2, 2023

Copy link
Copy Markdown

This PR has 38 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +23 -15
Percentile : 15.2%

Total files changed: 2

Change summary by file extension:
.cs : +13 -15
.ps1 : +10 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes May 2, 2023
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Made a quick fix and rebased the branch.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 05fbceb into PowerShell:master May 2, 2023
@daxian-dbw Dongbo Wang (daxian-dbw) removed the Review - Needed The PR is being reviewed label May 2, 2023
@sdwheeler Sean Wheeler (sdwheeler) added the PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update label Jun 1, 2023
@ghost

Deleted user (ghost) commented Jun 29, 2023

Copy link
Copy Markdown

🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
tolgabalci reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost mentioned this pull request Jun 29, 2023
New-Item -Force does not have expected behavior for all types #17656
Closed
5 tasks done
@sdwheeler Sean Wheeler (sdwheeler) mentioned this pull request Jun 30, 2023
New-Item recreates Junction when -Force is used MicrosoftDocs/PowerShell-Docs#10227
Closed
@coderabbitai coderabbitai Bot mentioned this pull request May 29, 2026
qq-nt: Update to version 9.9.31.260528, add data persistence ScoopInstaller/Extras#17919
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@GigaScratch
Fix New-Item to re-create Junction when -Force is specified (Po…
118aa6e
…werShell#18311)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small Hacktoberfest Potential candidate to participate in Hacktoberfest Hacktoberfest-Accepted Accepted to participate in Hacktoberfest PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New-Item -Force does not have expected behavior for all types

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@GigaScratch @iSazonov @daxian-dbw @sdwheeler
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.