GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove `PSv2CompletionCompleter` by xtqqczze · Pull Request #18337 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Oct 20, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Contributes to #18323.

Remove references to "PSv2" in: src/System.Management.Automation/engine/CommandCompletion/CommandCompletion.cs

Breaking changes to public APIs:

  • CompleteInput(String, Int32, Hashtable, PowerShell)
  • CompleteInput(Ast, Token[], IScriptPosition, Hashtable, PowerShell)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
xtqqczze added 3 commits October 20, 2022 17:55
@xtqqczze
Move PSv2CompletionCompleter to seperate file
0c7623e
@xtqqczze
Fix CS8019: Unnecessary using directive
da45fc3
@xtqqczze
Remove PSv2CompletionCompleter
920bf3b
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Large label Oct 20, 2022
@ghost ghost assigned Ilya (iSazonov) Oct 20, 2022
@xtqqczze

xtqqczze commented Oct 20, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

3a06f64: LastWordFinder is used for legacy tab expansion (TabExpansion internal function). I will try to remove

PowerShell/src/System.Management.Automation/engine/CommandCompletion/CommandCompletion.cs

Lines 670 to 673 in 920bf3b

/// LastWordFinder implements the algorithm we use to search for the last word in a line of input taken from the console.
/// This class exists for legacy purposes only - V3 and forward uses a slightly different interface.
/// </summary>
private sealed class LastWordFinder

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@xtqqczze
xtqqczze force-pushed the PSv2CompletionCompleter branch from 072040d to 0b45fbb Compare October 20, 2022 20:47
xtqqczze added 2 commits October 20, 2022 21:53
@xtqqczze
Move LastWordFinder to new file
3a06f64
@xtqqczze
Remove support for legacy tab expansion
e86ca2a
@xtqqczze
xtqqczze force-pushed the PSv2CompletionCompleter branch from 0b45fbb to e86ca2a Compare October 20, 2022 20:53
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added Extra Large and removed Large labels Oct 20, 2022
@xtqqczze
xtqqczze force-pushed the PSv2CompletionCompleter branch from 7038d32 to 06fc7cc Compare October 21, 2022 03:11
@xtqqczze
xtqqczze marked this pull request as ready for review October 21, 2022 03:12
@iSazonov
Ilya (iSazonov) requested review from Steve Lee (SteveL-MSFT) and Dongbo Wang (daxian-dbw) October 21, 2022 03:39
iSazonov
Ilya (iSazonov) reviewed Oct 21, 2022
View reviewed changes
Comment thread src/System.Management.Automation/engine/CommandCompletion/CommandCompletion.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CommandCompletion.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CommandCompletion.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CommandCompletion.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@xtqqczze

xtqqczze commented Oct 21, 2022

Copy link
Copy Markdown
Contributor Author

PowerShell-CI-windows (Test for Windows Windows Test - ElevatedPesterTests - Others) failure:

Set/New/Remove-Service cmdlet tests.Remove-Service can accept a ServiceController as pipeline input

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@xtqqczze xtqqczze closed this Oct 21, 2022
@xtqqczze

xtqqczze commented Oct 21, 2022

Copy link
Copy Markdown
Contributor Author

restarting tests

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@xtqqczze xtqqczze reopened this Oct 21, 2022
SteveL-MSFT
Steve Lee (SteveL-MSFT) reviewed Oct 24, 2022
View reviewed changes
Comment thread src/System.Management.Automation/engine/CommandCompletion/CommandCompletion.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

SteveL-MSFT
Steve Lee (SteveL-MSFT) reviewed Oct 24, 2022
View reviewed changes
Comment thread src/System.Management.Automation/engine/CommandCompletion/CommandCompletion.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

SteveL-MSFT
Steve Lee (SteveL-MSFT) reviewed Oct 24, 2022
View reviewed changes
Comment thread src/System.Management.Automation/engine/CommandCompletion/CommandCompletion.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

SteveL-MSFT
Steve Lee (SteveL-MSFT) reviewed Oct 24, 2022
View reviewed changes
Comment thread src/System.Management.Automation/engine/CommandCompletion/CommandCompletion.LastWordFinder.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Oct 24, 2022
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some legacy code should be removed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 24, 2022
xtqqczze added 2 commits October 26, 2022 01:04
@xtqqczze
Return instead of throwing
8b60d92
@xtqqczze
Update comment referencing win8
df593bd
@xtqqczze
xtqqczze force-pushed the PSv2CompletionCompleter branch from 5996d49 to df593bd Compare October 26, 2022 00:07
@xtqqczze
Remove override TabExpansion tests
f852ef3
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added Extra Large and removed Large labels Oct 26, 2022
@xtqqczze

xtqqczze commented Oct 26, 2022

Copy link
Copy Markdown
Contributor Author

Removed "Override TabExpansion with function" and "Override TabExpansion with alias" tests as they relate to the removed code.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@xtqqczze xtqqczze closed this Oct 26, 2022
@xtqqczze

xtqqczze commented Oct 26, 2022

Copy link
Copy Markdown
Contributor Author

restarting tests

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@xtqqczze xtqqczze reopened this Oct 26, 2022
@xtqqczze
xtqqczze marked this pull request as ready for review October 26, 2022 01:54
@xtqqczze

xtqqczze commented Oct 26, 2022

Copy link
Copy Markdown
Contributor Author

Steve Lee (@SteveL-MSFT) Ready for review, feedback addressed and test failures resolved.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iSazonov
Ilya (iSazonov) reviewed Oct 26, 2022
View reviewed changes
Comment thread src/System.Management.Automation/engine/CommandCompletion/CommandCompletion.cs Outdated
*/
}

@iSazonov Ilya (iSazonov) Oct 26, 2022

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 2, 2022
@ghost

Deleted user (ghost) commented Nov 2, 2022

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label May 1, 2023
SteveL-MSFT
Steve Lee (SteveL-MSFT) reviewed May 1, 2023
View reviewed changes
Comment thread src/System.Management.Automation/engine/CommandCompletion/CommandCompletion.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@SteveL-MSFT
Update src/System.Management.Automation/engine/CommandCompletion/Comm…
c417d79
…andCompletion.cs


Remove trailing whitespace
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes May 1, 2023
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@daxian-dbw
Merge branch 'master' into PSv2CompletionCompleter
e172cbd
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added Large and removed Extra Large labels May 2, 2023
@daxian-dbw Dongbo Wang (daxian-dbw) assigned Dongbo Wang (daxian-dbw) and unassigned Ilya (iSazonov) May 2, 2023
@ghost ghost removed the Review - Needed The PR is being reviewed label May 2, 2023
@daxian-dbw
Restore a new line to fix a CodeFactor issue
c6d9a9e
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented May 2, 2023

Copy link
Copy Markdown

This PR has 391 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Large
Size       : +9 -382
Percentile : 79.1%

Total files changed: 2

Change summary by file extension:
.cs : +9 -366
.ps1 : +0 -16

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit c77c286 into PowerShell:master May 2, 2023
@ghost

Deleted user (ghost) commented Jun 29, 2023

Copy link
Copy Markdown

🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@yan12125 Chih-Hsuan Yen (yan12125) mentioned this pull request Nov 25, 2023
Choco tab completion does not work if .exe is present chocolatey/choco#2255
Closed
@yan12125 Chih-Hsuan Yen (yan12125) mentioned this pull request Dec 6, 2023
Update tab completions for compatibility with PowerShell 7.4+ chocolatey/choco#3364
Closed
5 tasks done
@yan12125 Chih-Hsuan Yen (yan12125) mentioned this pull request Jan 5, 2024
Custom auto-completion not working anymore on 7.4.0 #20930
Closed
5 tasks done
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Remove PSv2CompletionCompleter as part of the PowerShell v2 code cl…
71ec7f0
…eanup (PowerShell#18337)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov left review comments
@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@xtqqczze @SteveL-MSFT @iSazonov @daxian-dbw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.