GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Correct incorrect cmdlet name in script by urizen-source · Pull Request #18374 · PowerShell/PowerShell

Conversation

@urizen-source

@urizen-source Nicklas Bjälemark (urizen-source) commented Oct 25, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Corrects incorrect cmdlet name in script, which has been causing for instance "Restart-Computer -Computername otherserver -Wait -For Powershell" to never complete.
Also fixes "Restart-Computer -ComputerName $_ -Force -Wait -Timeout 1800" where powershell is implicit.

PR Context

Resolves #12232
Also resolves #11002 which is also dependant on this powershell script, and it hangs in the same place.
Issue is that the powershell script invoked has an exception because of the incorrect cmdlet-name, and this exception is silently ignored, so it never determines that any powershell is reachable on restarted servers.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Zeze1184 reacted with laugh emoji
All reactions
  • 😄 1 reaction
Nicklas Bjälemark
Correct incorrect cmdlet name in script
b0e792f
@urizen-source
Nicklas Bjälemark (urizen-source) requested review from Aditya Patwardhan (adityapatwardhan) and Dongbo Wang (daxian-dbw) as code owners October 25, 2022 12:35
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Small label Oct 25, 2022
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Oct 25, 2022

Copy link
Copy Markdown

This PR has 2 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +1 -1
Percentile : 0.8%

Total files changed: 1

Change summary by file extension:
.cs : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost assigned Travis Plunk (TravisEz13) Oct 25, 2022
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Oct 25, 2022
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@iSazonov
Ilya (iSazonov) requested a review from James Truher (JamesWTruher) October 26, 2022 03:23
@iSazonov

Ilya (iSazonov) commented Oct 26, 2022

Copy link
Copy Markdown
Collaborator

Should we backport this?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daxian-dbw Dongbo Wang (daxian-dbw) added Backport-7.2.x-Consider CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log labels Oct 26, 2022
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit a06d908 into PowerShell:master Oct 26, 2022
@iSazonov

Ilya (iSazonov) commented Oct 26, 2022

Copy link
Copy Markdown
Collaborator

Nicklas Bjälemark (@urizen-source) Thanks for your contribution!

urizen-source reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Backport-7.3.x-Approved and removed Backport-7.3.x-Consider labels Nov 2, 2022
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Nov 2, 2022

Copy link
Copy Markdown
Member

Since 7.2.x is LTS lets have some bake time for this in 7.3.x and consider this for next 7.2 release.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Nov 2, 2022

Copy link
Copy Markdown
Member

/backport to release/v7.3.0

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot mentioned this pull request Nov 2, 2022
[release/v7.3.0] Correct incorrect cmdlet name in script #18445
Merged
1 task
@TravisEz13 Travis Plunk (TravisEz13) added Backport-7.3.x-Done and removed Backport-7.3.x-Approved labels Nov 2, 2022
@ghost

Deleted user (ghost) commented Nov 9, 2022

Copy link
Copy Markdown

🎉v7.3.0 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Nov 9, 2022
Restart-Computer -cn -Force -Wait -Timeout is broken in latest build. #11002
Closed
Restart-Computer wait for PowerShell never completes #12232
Closed
@unfurl-links unfurl-links Bot mentioned this pull request Nov 9, 2022
Arguments for external executables aren't correctly escaped #1995
Closed
@TravisEz13

Travis Plunk (TravisEz13) commented Nov 15, 2022

Copy link
Copy Markdown
Member

Triaging backports: Waiting for next release before backporting to LTS in order to give some time to discover issue.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Nov 15, 2022
& operator launches commands differently in 7.3.0 #18568
Closed
PowerShell 7.3 sends arguments to native apps differently #18617
Closed
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Backport-7.2.x-Approved and removed Backport-7.2.x-Consider labels Jan 4, 2023
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 10, 2023

Copy link
Copy Markdown
Member

/backport to release/v7.2.9

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot mentioned this pull request Jan 10, 2023
[release/v7.2.9] Correct incorrect cmdlet name in script #18919
Merged
1 task
@TravisEz13 Travis Plunk (TravisEz13) added Backport-7.2.x-Done and removed Backport-7.2.x-Approved labels Jan 10, 2023
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@urizen-source
Fix incorrect cmdlet name in the script used by Restart-Computer (P…
cb8dd60
…owerShell#18374)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

Backport-7.2.x-Done Backport-7.3.x-Done CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Restart-Computer wait for PowerShell never completes Restart-Computer -cn -Force -Wait -Timeout is broken in latest build.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@urizen-source @iSazonov @adityapatwardhan @TravisEz13 @daxian-dbw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.