GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add AllowInsecureRedirect switch to Web cmdlets by CarloToso · Pull Request #18546 · PowerShell/PowerShell

Conversation

@CarloToso

@CarloToso CarloToso commented Nov 13, 2022 •
edited by iSazonov
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

WebCmdlets add -AllowInsecureRedirect switch to enable HTTPS to HTTP redirect.
System.Net.Http.HttpClient disables insecure redirects, this PR bypasses the problem, unfortunately at the moment I can't find a way to make it honor the -MaximumRedirects flag, so I have disabled using both of them toghether.
I'm eager to receive your feedback on this feature and some input on how to fix and re-enable the -MaximumRedirect flag.
I'm going to add some tests to show what works and what doesn't work yet.

PR Context

Fixes #2896 and #18541

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed: Document WebCmdlets -AllowInsecureRedirect parameter MicrosoftDocs/PowerShell-Docs#9689
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
CarloToso added 3 commits November 13, 2022 01:32
@CarloToso
Add SwitchParameter
6ee2238
AllowInsecureRedirect
@CarloToso
ValidateParameters
17198a3
@CarloToso
Enable HTTP redirects from HTTPS
35a1eaf
@CarloToso
CarloToso requested a review from Paul Higinbotham (PaulHigin) as a code owner November 13, 2022 01:05
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Small label Nov 13, 2022
@ghost ghost assigned Paul Higinbotham (PaulHigin) Nov 13, 2022
CarloToso added 3 commits November 13, 2022 02:06
@CarloToso
fix comment
a26d327
@CarloToso
Add error to WebCmdletsStrings.resx
a84ab27
@CarloToso
fix WebCmdletsStrings.resx
f5eede6
@iSazonov

Ilya (iSazonov) commented Nov 14, 2022

Copy link
Copy Markdown
Collaborator

unfortunately at the moment I can't find a way to make it honor the -MaximumRedirects flag

PowerShell/src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs

Lines 1045 to 1049 in f5eede6

// This indicates GetResponse will handle redirects.
if (handleRedirect)
{
handler.AllowAutoRedirect = false;
}

This says it is in GetResponse().

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CarloToso
CarloToso marked this pull request as draft November 14, 2022 10:48
@CarloToso CarloToso changed the title Webcmdlets -AllowInsecureRedirect -> follow HTTP redirects from HTTPS WIP: Webcmdlets -AllowInsecureRedirect -> follow HTTP redirects from HTTPS Nov 14, 2022
CarloToso added 2 commits November 15, 2022 01:06
@CarloToso
Comment out AllowInsecureRedirectMaximumRedirectionConflict
94f78cc
@CarloToso
AllowInsecureRedirect + MaximumRedirection
e0ba600
@CarloToso

CarloToso commented Nov 15, 2022

Copy link
Copy Markdown
Contributor Author

-AllowInsecureRedirect should now work with -MaximumRedirect.
I tested it with this code:

0..5 | ForEach-Object {Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck -AllowInsecureRedirect -MaximumRedirection $_}
0..5 | ForEach-Object {Invoke-RestMethod https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck -AllowInsecureRedirect -MaximumRedirection $_}
Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck -AllowInsecureRedirect 
Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck

I still have to remove some commented code.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CarloToso
CarloToso marked this pull request as ready for review November 15, 2022 00:29
@CarloToso

CarloToso commented Nov 15, 2022

Copy link
Copy Markdown
Contributor Author
Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck

1

Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck -AllowInsecureRedirect

2

0..5 | ForEach-Object {(Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck -AllowInsecureRedirect -MaximumRedirection $_).StatusCode}

3

Some inconsistent behaviours (increase redirects errors, status code 308) are fixed by PR #18536.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CarloToso added 2 commits November 15, 2022 01:45
@CarloToso
Fix Spaces
e43e863
@CarloToso
Fix comment
9f61d36
@iSazonov

Ilya (iSazonov) commented Nov 15, 2022

Copy link
Copy Markdown
Collaborator

LGTM.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CarloToso
Remove commented error message
287bc61
@CarloToso CarloToso changed the title WIP: Webcmdlets -AllowInsecureRedirect -> follow HTTP redirects from HTTPS Webcmdlets -AllowInsecureRedirect -> follow HTTP redirects from HTTPS Nov 15, 2022
iSazonov
Ilya (iSazonov) approved these changes Nov 15, 2022
View reviewed changes
@CarloToso CarloToso mentioned this pull request Nov 17, 2022
Webcmdlets display an error on https to http redirect #18595
Merged
7 of 22 tasks
@CarloToso
Merge branch 'PowerShell:master' into WebCmdlets-add--allowInsecureRe…
aa3be10
…direct
@CarloToso

CarloToso commented Nov 23, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Paul Higinbotham (@PaulHigin) please review, thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost added the Review - Needed The PR is being reviewed label Dec 1, 2022
@ghost

Deleted user (ghost) commented Dec 1, 2022

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CarloToso
Merge branch 'master' into WebCmdlets-add--allowInsecureRedirect
b9703c3
@CarloToso

CarloToso commented Dec 16, 2022

Copy link
Copy Markdown
Contributor Author

Is something blocking this PR?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov

Ilya (iSazonov) commented Dec 17, 2022

Copy link
Copy Markdown
Collaborator

Is something blocking this PR?

Yes, holydays :-)
I hope MSFT team will start active work after Jan 1.
Until that I can consider minor style changes and discuss/review code for already triaged issues.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost removed the Review - Needed The PR is being reviewed label Dec 17, 2022
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 25, 2022
@ghost

Deleted user (ghost) commented Dec 25, 2022

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CarloToso

CarloToso commented Jan 3, 2023

Copy link
Copy Markdown
Contributor Author

I think that after this PR is merged I can work on fixing #14531, it should be similar.

iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CarloToso
Merge branch 'PowerShell:master' into WebCmdlets-add--allowInsecureRe…
d63ea55
…direct
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Jan 4, 2023

Copy link
Copy Markdown

This PR has 6 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +4 -2
Percentile : 2.4%

Total files changed: 1

Change summary by file extension:
.cs : +4 -2

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Jan 6, 2023
Add PreserveHttpMethodOnRedirect switch to Web cmdlets #18894
Merged
Fix bug with managing redirection and keepAuthorization in Web cmdlets #18902
Merged
@iSazonov Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jan 12, 2023
@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Paul Higinbotham (PaulHigin) Jan 12, 2023
@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 12, 2023
@iSazonov

Ilya (iSazonov) commented Jan 12, 2023

Copy link
Copy Markdown
Collaborator

please open new issue in Docs repository and add reference in the PR description.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CarloToso CarloToso mentioned this pull request Jan 12, 2023
Document WebCmdlets -AllowInsecureRedirect parameter MicrosoftDocs/PowerShell-Docs#9689
Closed
2 tasks done
@CarloToso

CarloToso commented Jan 12, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

please open new issue in Docs repository and add reference in the PR description.

Done MicrosoftDocs/PowerShell-Docs#9689

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov Ilya (iSazonov) changed the title Webcmdlets -AllowInsecureRedirect -> follow HTTP redirects from HTTPS Add AllowInsecureRedirect switch to Web cmdlets Jan 12, 2023
@iSazonov
Ilya (iSazonov) merged commit ca4b616 into PowerShell:master Jan 12, 2023
@CarloToso
CarloToso deleted the WebCmdlets-add--allowInsecureRedirect branch January 12, 2023 16:13
@CarloToso CarloToso mentioned this pull request Jan 13, 2023
Add tests for Allowinsecureredirect parameter in Web cmdlets #18939
Merged
@CarloToso CarloToso mentioned this pull request Jan 23, 2023
Invoke-WebRequest/Invoke-RestMethod doesn't error silently and doesn't return object #16247
Closed
5 tasks done
@ghost

Deleted user (ghost) commented Mar 14, 2023

Copy link
Copy Markdown

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost mentioned this pull request Mar 14, 2023
Invoke-WebRequest / Invoke-RestMethod fails to follow HTTP redirects from HTTPS #2896
Closed
@CarloToso CarloToso mentioned this pull request Apr 7, 2023
WebCmdlets check if absolute uri before checking scheme #19468
Merged
22 tasks
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@CarloToso
Add AllowInsecureRedirect switch to Web cmdlets (PowerShell#18546)
cdc1ca7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invoke-WebRequest / Invoke-RestMethod fails to follow HTTP redirects from HTTPS

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@CarloToso @iSazonov @PaulHigin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.