GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update supported distros in Readme by techguy16 · Pull Request #18667 · PowerShell/PowerShell

Conversation

@techguy16

@techguy16 techguy16 (techguy16) commented Nov 27, 2022

Copy link
Copy Markdown
Contributor

Ubuntu 22.04 can run PowerShell, so adding it as supported distro.

PR Summary

In the Readme, there was no "Ubuntu 22.04" as a supported distro in the table. Ubuntu 22.04 does support PowerShell.

PR Context

Ubuntu 22.04 users probably thought that PowerShell didn't support their distro so I added it as a row in the table.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@techguy16
Adding Ubuntu 22.04 as supported distro
b441012
Ubuntu 22.04 can run PowerShell, so adding it as supported distro.
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Small label Nov 27, 2022
@ghost ghost assigned Travis Plunk (TravisEz13) Nov 27, 2022
kilasuit
Ryan Yates (kilasuit) approved these changes Nov 27, 2022
View reviewed changes
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 5, 2022
@ghost

Deleted user (ghost) commented Dec 5, 2022

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@techguy16

techguy16 (techguy16) commented Dec 10, 2022

Copy link
Copy Markdown
Contributor Author

Hi can you please review these changes?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TravisEz13
Travis Plunk (TravisEz13) reviewed Feb 13, 2023
View reviewed changes
Comment thread README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

TravisEz13
Travis Plunk (TravisEz13) reviewed Feb 13, 2023
View reviewed changes
Comment thread README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13
Apply suggestions from code review
238158c
TravisEz13
Travis Plunk (TravisEz13) reviewed Feb 13, 2023
View reviewed changes
Comment thread README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

TravisEz13
Travis Plunk (TravisEz13) reviewed Feb 13, 2023
View reviewed changes
Comment thread README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13
Add Ubuntu 16 back for LTS
a98ec54
TravisEz13
Travis Plunk (TravisEz13) reviewed Feb 13, 2023
View reviewed changes
Comment thread README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

TravisEz13
Travis Plunk (TravisEz13) reviewed Feb 13, 2023
View reviewed changes
Comment thread README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Travis Plunk (TravisEz13) added 2 commits February 13, 2023 12:30
@TravisEz13
remove deb9
98cad7e
@TravisEz13
Fix Kali
9a6e733
TravisEz13
Travis Plunk (TravisEz13) reviewed Feb 13, 2023
View reviewed changes
Comment thread README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13
Update README.md
20c9989
TravisEz13
Travis Plunk (TravisEz13) approved these changes Feb 13, 2023
View reviewed changes
@TravisEz13 Travis Plunk (TravisEz13) changed the title Adding Ubuntu 22.04 as supported distro Update supported distros in Readme Feb 13, 2023
@TravisEz13
Merge branch 'master' into patch-1
d8b2d80
TravisEz13
Travis Plunk (TravisEz13) reviewed Feb 13, 2023
View reviewed changes
Comment thread README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13
fix merge issue
4bdf1ea
daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Feb 13, 2023
View reviewed changes
Comment thread README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

techguy16 (techguy16) added 2 commits February 15, 2023 07:24
@techguy16
Update README.md
acc9b16
@techguy16
Update README.md
46a851a
I recommend adding a link somewhere that users of older operating systems can click and download the correct version of PowerShell for their OS.
daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Feb 14, 2023
View reviewed changes
Comment thread README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@techguy16 @daxian-dbw
Update README.md
015b833
Co-authored-by: Dongbo Wang <[email protected]>
TravisEz13
Travis Plunk (TravisEz13) approved these changes Feb 16, 2023
View reviewed changes
@techguy16

techguy16 (techguy16) commented Feb 17, 2023

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Travis Plunk (TravisEz13) added 4 commits March 3, 2023 13:27
@TravisEz13
Merge branch 'master' into patch-1
f3ccfb2
@TravisEz13
Update README.md
f8fefed
@TravisEz13
Update README.md
331ea9d
@TravisEz13
Update README.md
9eea0db
JamesWTruher
James Truher (JamesWTruher) approved these changes Mar 3, 2023
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) enabled auto-merge (squash) March 3, 2023 21:40
@TravisEz13
Travis Plunk (TravisEz13) merged commit 34cf469 into PowerShell:master Mar 3, 2023
@ghost ghost removed the Review - Needed The PR is being reviewed label Mar 3, 2023
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Mar 3, 2023

Copy link
Copy Markdown

This PR has 23 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +12 -11
Percentile : 9.2%

Total files changed: 1

Change summary by file extension:
.md : +12 -11

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13

Travis Plunk (TravisEz13) commented Mar 8, 2023

Copy link
Copy Markdown
Member

thanks techguy16 (@techguy16) for your contribution

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@techguy16

techguy16 (techguy16) commented Mar 9, 2023

Copy link
Copy Markdown
Contributor Author

Travis Plunk (@TravisEz13) No worries - need any help, just ask 😁

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Mar 14, 2023
@ghost

Deleted user (ghost) commented Mar 14, 2023

Copy link
Copy Markdown

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@techguy16
Update supported distros in Readme (PowerShell#18667)
ad8768e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw left review comments
@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
+2 more reviewers
@kilasuit Ryan Yates (kilasuit) kilasuit approved these changes
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@techguy16 @TravisEz13 @daxian-dbw @kilasuit @JamesWTruher @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.