GeezerVison is showing github.com — Set default native arg passing to Legacy on Windows. by JamesWTruher · Pull Request #18706 · PowerShell/PowerShell
Conversation
PR Summary
The committee agreed to a new PSWindowsNativeCommandArgPassing experimental feature. When this feature is enabled:
- On Windows
$PSNativeCommandArgumentPassing = Windows
- Non-Windows
$PSNativeCommandArgumentPassing = Standard
When this feature is disabled:
- On Windows
$PSNativeCommandArgumentPassing = Legacy
- Non-Windows
$PSNativeCommandArgumentPassing = Standard
Additionally, new telemetry metric will be added for native command execution to inform the mode being used.
PR Context
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Make sure all
.h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
- Breaking changes
- User-facing changes
- Testing - New and feature
- Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
- Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
- Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use PSVersionInfo.PSCurrentVersion.PreReleaseLabel to detect whether it's a stable version.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ghost
added
Waiting on Author
The PR was reviewed and requires changes or comments from the author before being accept
and removed
Waiting on Author
The PR was reviewed and requires changes or comments from the author before being accept
labels
Dec 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes stable and preview releases have different default behavior on native argument passing. Won't that inconsistency cause any problems and confusions to the preview adopters? If we choose to do this on purpose, then doc needs to be updated to reflect this inconsistency.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ghost
added
the
Waiting on Author
The PR was reviewed and requires changes or comments from the author before being accept
label
Dec 2, 2022
ghost
removed
the
Waiting on Author
The PR was reviewed and requires changes or comments from the author before being accept
label
Dec 2, 2022
|
Dongbo Wang (@daxian-dbw) the difference between stable and preview is deliberate as to prioritize compat for stable while ensuring we have the new desired behavior in preview to continue to get feedback. Maybe an option we can take here to make this more clear is to wrap it in a new Experimental Feature. Specifically, Windows mode is experimental.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I understand there will be difference between stable and preview versions. However, the native arg passing feature is already official, so making an official feature behave differently seems confusing.
Introducing a new experimental feature for the different arg passing behavior in preview versions sounds like a good idea. A doc issue needs to be opened for the new experimental feature.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Dongbo Wang (@daxian-dbw) We should probably advertise that Windows mode is still experimental and changes will continue until we can get to an acceptable level of compatibility
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@PowerShell/powershell-committee Please review this PR and decide whether this PR should be closed or accepted.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@PowerShell/powershell-committee discussed this. We agreed to a new PSWindowsNativeCommandArgPassing experimental feature. When this feature is enabled:
- On Windows
$PSNativeCommandArgumentPassing = Windows
- Non-Windows
$PSNativeCommandArgumentPassing = Standard
When this feature is disabled:
- On Windows
$PSNativeCommandArgumentPassing = Legacy
- Non-Windows
$PSNativeCommandArgumentPassing = Standard
Additionally, new telemetry metric will be added for native command execution to inform the mode being used.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
If the PS release is a preview, then set it to Windows.
use compile time rather than runtime check
Co-authored-by: Dongbo Wang <[email protected]>

This PR has 24 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!
Quantification details
Label : Extra Small
Size : +21 -3
Percentile : 9.6%
Total files changed: 4
Change summary by file extension:
.cs : +17 -2
.ps1 : +4 -1
Change counts above are quantified counts, based on the PullRequestQuantifier customizations.
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:
- Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
iterations.
- Similarity in low PR complexity drives similar review times.
- Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
- Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
- Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.
What can I do to optimize my changes
- Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the
Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your
prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your
prquantifier.yaml context profile.
- Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
- Your PR could be split in smaller, self-contained PRs instead
- Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).
How to interpret the change counts in git diff output
- One line was added:
+1 -0
- One line was deleted:
+0 -1
- One line was modified:
+1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
- Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:
Handy links:
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
So the default behavior in 7.2 is Legacy, then in 7.3 it's Windows, now it's going to be Legacy in 7.4 unless an experimental feature is enabled which makes it into Windows by default unless you set a new variable to Legacy, do I have that right?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@ImportTaste, this is marked to backport to 7.3.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@PowerShell/powershell-committee Are we okay with making this change to 7.3 after it has been release?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
PS-Committee decided to make this feature stable in 7.4, so the default will be Windows in 7.4. Based on the telemetry, it seems that most Windows (like 99%) have not changed the default in 7.4 previews to Legacy or Standard. As such, there is no reason to backport to 7.3 which will be supported for just 1 more year.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
it seems that most Windows (like 99%) have not changed the default in 7.4 previews to Legacy or Standard
What's the difference between Windows and Standard on Windows?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
+1 more reviewer
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|