GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use interpolated strings 12 by CarloToso · Pull Request #19003 · PowerShell/PowerShell

Conversation

@CarloToso

@CarloToso CarloToso commented Jan 21, 2023 •
edited by iSazonov
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Replace string.Format() with new string.Create((IFormatProvider? provider, [InterpolatedStringHandlerArgument(nameof(provider))] ref DefaultInterpolatedStringHandler handler).

PR Context

#18974, I think this is the last one

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@CarloToso
3 files
1be0d9d
@CarloToso
CarloToso requested a review from Paul Higinbotham (PaulHigin) as a code owner January 21, 2023 18:57
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Small label Jan 21, 2023
@ghost ghost assigned Dongbo Wang (daxian-dbw) Jan 21, 2023
CarloToso added 2 commits January 21, 2023 20:38
@CarloToso
revert
0089c2a
@CarloToso
streamWriter.NewLine -> ToString
8be40c2
@CarloToso CarloToso closed this Jan 21, 2023
@CarloToso CarloToso reopened this Jan 21, 2023
@CarloToso

CarloToso commented Jan 21, 2023

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) What is the preferred solution ? streamWriter.NewLine -> streamWriter.NewLine.ToString() or streamWriter.NewLine -> Environment.NewLine

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov

Ilya (iSazonov) commented Jan 22, 2023

Copy link
Copy Markdown
Collaborator

Ilya (@iSazonov) What is the preferred solution ? streamWriter.NewLine -> streamWriter.NewLine.ToString() or streamWriter.NewLine -> Environment.NewLine

We can not use Environment.NewLine since streamWriter can use any value.
streamWriter.NewLine doesn't work but streamWriter.NewLine.ToString()? If so we can use second one.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CarloToso
streamWriter.NewLine.ToString()
c9ba906
@iSazonov

Ilya (iSazonov) commented Jan 22, 2023

Copy link
Copy Markdown
Collaborator

Maybe it's not worth the effort.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CarloToso added 2 commits January 22, 2023 14:12
@CarloToso
string.Format({streamWriter.NewLine})
f3a9545
@CarloToso
revert 2 files
93bfa82
iSazonov
Ilya (iSazonov) reviewed Jan 23, 2023
View reviewed changes
Comment thread src/System.Management.Automation/engine/Modules/NewModuleManifestCommand.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

iSazonov
Ilya (iSazonov) reviewed Jan 23, 2023
View reviewed changes
Comment thread src/System.Management.Automation/engine/remoting/commands/NewPSSessionConfigurationFile.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@CarloToso
revert
044d1c2
iSazonov
Ilya (iSazonov) approved these changes Jan 23, 2023
View reviewed changes
@iSazonov
Ilya (iSazonov) self-requested a review January 23, 2023 12:35
iSazonov
Ilya (iSazonov) requested changes Jan 23, 2023
View reviewed changes

@iSazonov Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CarloToso Again an test fails.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 23, 2023
@CarloToso

CarloToso commented Jan 23, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) I don't know why the tests are failing, it doesn't make any sense. Maybe it was a random error

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 23, 2023
@CarloToso CarloToso closed this Jan 23, 2023
@CarloToso CarloToso reopened this Jan 23, 2023
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Jan 23, 2023

Copy link
Copy Markdown

This PR has 17 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +4 -13
Percentile : 6.8%

Total files changed: 3

Change summary by file extension:
.cs : +4 -13

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iSazonov
Ilya (iSazonov) approved these changes Jan 23, 2023
View reviewed changes
@iSazonov Ilya (iSazonov) added the CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log label Jan 23, 2023
@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Dongbo Wang (daxian-dbw) Jan 23, 2023
@iSazonov
Ilya (iSazonov) merged commit 33ba573 into PowerShell:master Jan 23, 2023
@CarloToso
CarloToso deleted the Use-interpolated-strings-12 branch January 23, 2023 17:37
daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Jan 23, 2023
View reviewed changes
Comment thread src/System.Management.Automation/engine/runtime/Binding/Binders.cs
_allowSlicing ? string.Empty : " slicing disallowed",
_constraints == null ? string.Empty : " constraints: " + _constraints,
_version);
return string.Create(CultureInfo.InvariantCulture, $"PSGetIndexBinder indexCount={this.CallInfo.ArgumentCount}{(_allowSlicing ? string.Empty : " slicing disallowed")}{(_constraints == null ? string.Empty : " constraints: " + _constraints)} ver:{_version}");

@daxian-dbw Dongbo Wang (daxian-dbw) Jan 23, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ilya (@iSazonov) I think this is way less readable than the original code, don't you think so?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

PaulHigin and powercode reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

@iSazonov Ilya (iSazonov) Jan 24, 2023

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think more about reducing allocations. My suggestions for improvement I outlined in your PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ghost

Deleted user (ghost) commented Mar 14, 2023

Copy link
Copy Markdown

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@CarloToso
Use interpolated strings 12 (PowerShell#19003)
81fbafa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw left review comments
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@CarloToso @iSazonov @daxian-dbw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.