GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add Windows ARM64 CI by TravisEz13 · Pull Request #19040 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Jan 27, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

The goal here is to get Windows ARM64 tests running daily rather than only with a release.

  • Add an Windows ARM64 CI
    • the PR tests will require using /azp run see comment
    • Several templates had to be update to choose between running in an Microsoft Hosted pool or an internal hosted pool
    • Many tests were skipped or pended because of failures. We should try to fix those issues later.

Issues filed:

  • Console APIs fail when running in ARM64 on AzDevOps
  • Need to setup remoting on ARM64
  • Investigate ARM64 failures
  • Unable to unelevate on ARM64 in azDO
  • Tests assume shell is available
  • tests assume homepath is set
  • Need a way to register event provider on ARM64
  • Get-hotfix is broken on ARM64 because native lib doesn't load

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kilasuit reacted with hooray emoji
All reactions
  • 🎉 1 reaction
Aditya Patwardhan (adityapatwardhan) and others added 24 commits January 26, 2023 11:36
@adityapatwardhan @TravisEz13
Add CI for win-arm64
90f359f
@adityapatwardhan @TravisEz13
Install Powershell
2e18541
@adityapatwardhan @TravisEz13
Fix condition
aaeeafe
@adityapatwardhan @TravisEz13
Add Sync-PStags
eb65d14
@adityapatwardhan @TravisEz13
Add missing switch
8f4bac9
@adityapatwardhan @TravisEz13
Add explicit checkout
b54a899
@adityapatwardhan @TravisEz13
Make test stages use the correct image
6181cd1
@adityapatwardhan @TravisEz13
Install pscore
494b607
@adityapatwardhan @TravisEz13
Fix typo
7e127ea
@adityapatwardhan @TravisEz13
Add logging
4f0c9ea
@adityapatwardhan @TravisEz13
fix path
e6e34ad
@adityapatwardhan @TravisEz13
Fix bootstrap
089212c
@TravisEz13
fix unelevated tests
fbc67e2
@TravisEz13
update image name
24badb1
@TravisEz13
update build image name
87459f5
@TravisEz13
Add note
a0ec3eb
@TravisEz13
make step name more descriptive
2fdabeb
@TravisEz13
fix test failures
f952733
@TravisEz13
fix test failures
0e7095a
@TravisEz13
fix test issues
ad65b7a
@TravisEz13
fix test issues
679b896
@TravisEz13
fix test issue
0b1cba6
@TravisEz13
Fix test issues
6735561
@TravisEz13
Fix test issue
0398853
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Large label Jan 27, 2023
@ghost ghost assigned Ilya (iSazonov) Jan 27, 2023
@TravisEz13 Travis Plunk (TravisEz13) assigned Aditya Patwardhan (adityapatwardhan) and unassigned Ilya (iSazonov) Jan 27, 2023
@TravisEz13
fix test issues
32290f8
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 27, 2023

Copy link
Copy Markdown
Member Author

/azp run ps-Windows-Arm64

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13
Travis Plunk (TravisEz13) marked this pull request as ready for review January 27, 2023 21:03
@TravisEz13
Travis Plunk (TravisEz13) requested review from Paul Higinbotham (PaulHigin), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners January 27, 2023 21:03
TravisEz13
Travis Plunk (TravisEz13) commented Jan 27, 2023
View reviewed changes
Comment thread .vsts-ci/templates/ci-build.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

Travis Plunk (TravisEz13) and others added 2 commits January 27, 2023 13:04
@TravisEz13
Update .vsts-ci/templates/ci-build.yml
2554ed8
@TravisEz13
fix a typo
e668afa
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) reviewed Jan 27, 2023
View reviewed changes
Comment thread .vsts-ci/templates/ci-build.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13
Update .vsts-ci/templates/ci-build.yml
79e5d98
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) reviewed Jan 27, 2023
View reviewed changes
Comment thread test/powershell/Host/ConsoleHost.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

adityapatwardhan
Aditya Patwardhan (adityapatwardhan) reviewed Jan 27, 2023
View reviewed changes
Comment thread test/powershell/Host/ScreenReader.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Jan 27, 2023
View reviewed changes
kilasuit
Ryan Yates (kilasuit) suggested changes Jan 28, 2023
View reviewed changes

@kilasuit Ryan Yates (kilasuit) left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor codefactor issues & minor other little nitpicks I am very glad to see this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread test/powershell/Host/ScreenReader.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/powershell/Language/Scripting/NativeExecution/NativeCommandProcessor.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/powershell/engine/ExperimentalFeature/Get-ExperimentalFeature.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 28, 2023
@TravisEz13
Add common function to test for windows arm64
5130c31
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 31, 2023
@TravisEz13
Update because string where items need investigation
4f5da10
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 31, 2023

Copy link
Copy Markdown
Member Author

/azp run ps-Windows-Arm64

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@azure-pipelines

azure-pipelines Bot commented Jan 31, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Jan 31, 2023

Copy link
Copy Markdown

This PR has 271 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Large
Size       : +246 -25
Percentile : 67.1%

Total files changed: 31

Change summary by file extension:
.yml : +143 -5
.psm1 : +13 -3
.ps1 : +85 -13
.psd1 : +5 -4

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13
Travis Plunk (TravisEz13) merged commit b2c4888 into master Jan 31, 2023
@TravisEz13
Travis Plunk (TravisEz13) deleted the CIwinArm64 branch January 31, 2023 20:06
@unfurl-links unfurl-links Bot mentioned this pull request Feb 6, 2023
Misleading error message when parsing Configuration keyword on ARM processor #18781
Closed
5 tasks done
@xtqqczze xtqqczze mentioned this pull request Mar 7, 2023
Update build.psm1 to require pwsh 7.0 #18556
Closed
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Mar 14, 2023
@ghost

Deleted user (ghost) commented Mar 14, 2023

Copy link
Copy Markdown

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) mentioned this pull request Nov 6, 2023
Fix setting of variable to consume internal SDK source #20644
Merged
8 of 22 tasks
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13 @adityapatwardhan
Add Windows ARM64 CI (PowerShell#19040)
3b66bf5
* Add CI for win-arm64

* Add common function to test for windows arm64

* Update because string where items need investigation

---------

Co-authored-by: Aditya Patwardhan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin
+1 more reviewer
@kilasuit Ryan Yates (kilasuit) kilasuit requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log Large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@TravisEz13 @kilasuit @adityapatwardhan @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.