GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Replace `Requires.NotNullOrEmpty(string)` with `ArgumentException.ThrowIfNullOrEmpty` by xtqqczze · Pull Request #19197 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Feb 22, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Breaking change: Bucket 3: Unlikely Grey Area

This PR makes changes to public APIs so that an ArgumentException is thrown instead of ArgumentNullException when a string is empty rather than null.

  • System.Management.Automation.Subsystem.Prediction.PredictionContext.Create(String)
  • System.Management.Automation.Subsystem.Prediction.PredictiveSuggestion..ctor(String)
  • System.Management.Automation.Subsystem.Prediction.PredictiveSuggestion..ctor(String, String)
  • System.Management.Automation.Subsystem.Prediction.CommandPrediction.OnSuggestionAccepted(PredictionClient, Guid, UInt32, String)

If a consumer caught the ArgumentNullException and not the base class ArgumentException this is a change in behavior.

However, it seems unlikely to depend on a specific exception being thrown, because if specific behavior was required, the caller could have implemented the necessary business logic.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ghost ghost assigned Dongbo Wang (daxian-dbw) Feb 22, 2023
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Small label Feb 22, 2023
@xtqqczze

xtqqczze commented Feb 22, 2023

Copy link
Copy Markdown
Contributor Author

Dongbo Wang (@daxian-dbw) Please mark Review - Maintainer.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@xtqqczze xtqqczze mentioned this pull request Feb 22, 2023
Revert a few changes to not use 'ArgumentNullException.ThrowIfNull' #19151
Merged
7 of 13 tasks
@xtqqczze

xtqqczze commented Feb 22, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

PowerShell-CI-macos (Test for macOS mac Test - UnelevatedPesterTests - Others test failure: #19198

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@xtqqczze
xtqqczze marked this pull request as ready for review February 22, 2023 23:28
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Feb 23, 2023

Copy link
Copy Markdown
Member

I think this change is fine. But you need to rebase with the master, because #19133 introduces another use of the Requires.NotNullOrEmpty(string value, string paramName). So, you need to update that one as well. Thanks!

xtqqczze reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Feb 23, 2023
xtqqczze added 2 commits February 23, 2023 03:09
@xtqqczze
Replace Requires.NotNullOrEmpty with `ArgumentException.ThrowIfNull…
0c99171
…OrEmpty`
@xtqqczze
Update with changes from 79b4b5c
f16cb79
@iSazonov
Ilya (iSazonov) self-requested a review February 23, 2023 04:08
@xtqqczze xtqqczze mentioned this pull request Feb 23, 2023
[macos] Invoke-WebRequest tests.Error occurred in Describe block #19198
Closed
@daxian-dbw Dongbo Wang (daxian-dbw) added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 23, 2023
@xtqqczze
xtqqczze force-pushed the Requires.NotNullOrEmpty branch from 375a8c8 to f16cb79 Compare February 24, 2023 00:03
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 24, 2023
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Feb 24, 2023
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Feb 24, 2023

Copy link
Copy Markdown

This PR has 11 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +4 -7
Percentile : 4.4%

Total files changed: 4

Change summary by file extension:
.cs : +4 -7

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iSazonov
Ilya (iSazonov) approved these changes Feb 24, 2023
View reviewed changes
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 7441276 into PowerShell:master Feb 24, 2023
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Feb 24, 2023
Use correct exceptions #19212
Closed
@xtqqczze
xtqqczze deleted the Requires.NotNullOrEmpty branch February 24, 2023 18:19
@ghost

Deleted user (ghost) commented Mar 14, 2023

Copy link
Copy Markdown

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Replace Requires.NotNullOrEmpty(string) with `ArgumentException.Thr…
d50fced
…owIfNullOrEmpty` (PowerShell#19197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xtqqczze @daxian-dbw @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.