GeezerVison is showing github.com — Use `ArgumentException.ThrowIfNullOrEmpty` part 1 by xtqqczze · Pull Request #19215 · PowerShell/PowerShell
Conversation
xtqqczze
commented
Feb 24, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Use ArgumentException.ThrowIfNullOrEmpty in Microsoft.PowerShell.Commands.Management.
Contributes to #19212.
Changes
- Throws
ArgumentException instead of ArgumentNullException when a string is empty.
- Possible breaking change as
ArgumentException is a less derived type.
- Throws
ArgumentNullException instead of ArgumentException when a string is null.
- Clearly non-breaking as
ArgumentNullException is a more derived type.
Breaking changes contract
Bucket 4: Clearly Non-Public
- Modifies internal class
Microsoft.PowerShell.Cmdletization.Cim.CimQuery
- Modifies internal class
Microsoft.PowerShell.Commands.CIMHelper
Other changes
608186d is a related refactoring that does not change behavior.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
xtqqczze The change is for adopting ArgumentException.ThrowIfNullOrEmpty instead of ArgumentNullException.ThrowIfNull, right?
|
xtqqczze reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
xtqqczze The change is for adopting ArgumentException.ThrowIfNullOrEmpty instead of ArgumentNullException.ThrowIfNull, right?
My bad, this is why I'm trying to keep PRs small.
Although I've mixed the following changes when they could have been seperated.:
- Throws
ArgumentException instead of ArgumentNullException when a string is empty.
- Throws
ArgumentNullException instead of ArgumentException when a string is null.
In any case the changes are to non-public APIS.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
|
}
|
|
|
|
|
|
ArgumentException.ThrowIfNullOrEmpty(optionName);
|
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
xtqqczze
Feb 24, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My personal preference is to separate the method calls with a blank line when the type of the ArgumentException differs.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, I'll update my PR following your style 👍
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to group them together as they are doing the same kind of things. For example, we group Dbg.Assert(xxx) together at the beginning of some methods, even though they do different checks.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
xtqqczze reacted with eyes emoji
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.

This PR has 25 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!
Quantification details
Label : Extra Small
Size : +11 -14
Percentile : 10%
Total files changed: 3
Change summary by file extension:
.cs : +11 -14
Change counts above are quantified counts, based on the PullRequestQuantifier customizations.
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:
- Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
iterations.
- Similarity in low PR complexity drives similar review times.
- Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
- Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
- Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.
What can I do to optimize my changes
- Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the
Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your
prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your
prquantifier.yaml context profile.
- Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
- Your PR could be split in smaller, self-contained PRs instead
- Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).
How to interpret the change counts in git diff output
- One line was added:
+1 -0
- One line was deleted:
+0 -1
- One line was modified:
+1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
- Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jul 15, 2026
Reviewers
+1 more reviewer
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|