GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use `ArgumentException.ThrowIfNullOrEmpty` part 1 by xtqqczze · Pull Request #19215 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Feb 24, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Use ArgumentException.ThrowIfNullOrEmpty in Microsoft.PowerShell.Commands.Management.

Contributes to #19212.

Changes

  • Throws ArgumentException instead of ArgumentNullException when a string is empty.
    • Possible breaking change as ArgumentException is a less derived type.
  • Throws ArgumentNullException instead of ArgumentException when a string is null.
    • Clearly non-breaking as ArgumentNullException is a more derived type.

Breaking changes contract

Bucket 4: Clearly Non-Public

  • Modifies internal class Microsoft.PowerShell.Cmdletization.Cim.CimQuery
  • Modifies internal class Microsoft.PowerShell.Commands.CIMHelper

Other changes

608186d is a related refactoring that does not change behavior.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
xtqqczze added 2 commits February 24, 2023 19:52
@xtqqczze
Use ArgumentException.ThrowIfNullOrEmpty in `Microsoft.PowerShell.C…
304173a
…ommands.Management`
@xtqqczze
IsNullOrWhiteSpace control flow refactoring
608186d
@xtqqczze
xtqqczze requested review from Aditya Patwardhan (adityapatwardhan) and Dongbo Wang (daxian-dbw) as code owners February 24, 2023 20:02
@ghost ghost assigned Ilya (iSazonov) Feb 24, 2023
@xtqqczze xtqqczze mentioned this pull request Feb 24, 2023
Use ArgumentException.ThrowIfNullOrEmpty() in more places #19213
Merged
22 tasks
@daxian-dbw Dongbo Wang (daxian-dbw) changed the title Use ArgumentNullException.ThrowIfNull part 1 Use ArgumentException.ThrowIfNullOrEmpty part 1 Feb 24, 2023
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Feb 24, 2023

Copy link
Copy Markdown
Member

xtqqczze The change is for adopting ArgumentException.ThrowIfNullOrEmpty instead of ArgumentNullException.ThrowIfNull, right?

xtqqczze reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@xtqqczze

This comment was marked as resolved.

Sign in to view
@xtqqczze

xtqqczze commented Feb 24, 2023

Copy link
Copy Markdown
Contributor Author

xtqqczze The change is for adopting ArgumentException.ThrowIfNullOrEmpty instead of ArgumentNullException.ThrowIfNull, right?

My bad, this is why I'm trying to keep PRs small.

Although I've mixed the following changes when they could have been seperated.:

  • Throws ArgumentException instead of ArgumentNullException when a string is empty.
  • Throws ArgumentNullException instead of ArgumentException when a string is null.

In any case the changes are to non-public APIS.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Small label Feb 24, 2023
CarloToso
CarloToso reviewed Feb 24, 2023
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/cimQuery.cs Outdated
}

ArgumentException.ThrowIfNullOrEmpty(optionName);

@CarloToso CarloToso Feb 24, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@xtqqczze xtqqczze Feb 24, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My personal preference is to separate the method calls with a blank line when the type of the ArgumentException differs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@CarloToso CarloToso Feb 24, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, I'll update my PR following your style 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@daxian-dbw Dongbo Wang (daxian-dbw) Feb 27, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to group them together as they are doing the same kind of things. For example, we group Dbg.Assert(xxx) together at the beginning of some methods, even though they do different checks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

xtqqczze reacted with eyes emoji
All reactions
  • 👀 1 reaction
@iSazonov Ilya (iSazonov) added CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log labels Feb 25, 2023
iSazonov
Ilya (iSazonov) approved these changes Feb 25, 2023
View reviewed changes
@daxian-dbw
Remove empty line between argument checks
6794357
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Feb 27, 2023
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Feb 27, 2023

Copy link
Copy Markdown

This PR has 25 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +11 -14
Percentile : 10%

Total files changed: 3

Change summary by file extension:
.cs : +11 -14

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit fe8cc5d into PowerShell:master Feb 28, 2023
@xtqqczze
xtqqczze deleted the string-IsNullOrWhiteSpace-p1 branch February 28, 2023 23:48
@unfurl-links unfurl-links Bot mentioned this pull request Nov 22, 2023
7.4.0 Breaking change: Passing -OutFile $null to Invoke-WebRequest fails #20744
Open
5 tasks done
@pwshBot PowerShell Team Bot (pwshBot) mentioned this pull request Jun 10, 2026
Update 7.4 changelog for v7.4.17 #27590
Merged
This was referenced Jul 15, 2026
Update 7.4 changelog for v7.4.18 #27689
Closed
Update 7.4 changelog for v7.4.18 #27691
Merged
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Use ArgumentException.ThrowIfNullOrEmpty as appropriate [part 1] (P…
e6093ef
…owerShell#19215)
@powershell-pr-automation powershell-pr-automation Bot mentioned this pull request Aug 11, 2026
Update 7.4 changelog for v7.4.19 #27833
Merged
@jshigetomi Justin Chung (jshigetomi) mentioned this pull request Aug 12, 2026
Update 7.4 changelog for v7.4.19 #27835
Closed
@powershell-pr-automation powershell-pr-automation Bot mentioned this pull request Sep 2, 2026
Update 7.4 changelog for v7.4.20 #27949
Merged
@powershell-pr-automation powershell-pr-automation Bot mentioned this pull request Oct 9, 2026
Update 7.4 changelog for v7.4.21 #28179
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
+1 more reviewer
@CarloToso CarloToso CarloToso left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@xtqqczze @daxian-dbw @iSazonov @CarloToso
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.