GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Take into account ContentType from Headers in WebCmdlets by CarloToso · Pull Request #19227 · PowerShell/PowerShell

Conversation

@CarloToso

@CarloToso CarloToso commented Feb 26, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

  • Currently we only check for -ContentType and we ignore -Headers @{Content-Type=...} after this PR we also check for ContentType in headers

  • If we set both -ContentType and -Headers @{Content-Type=...} --> -ContentType is used

We will also have to change the documentation that documents this behaviour

PR Context

Fixes #19156

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed: Invoke-WebRequest if no -ContentType check -Headers @{Content-Type=...} MicrosoftDocs/PowerShell-Docs#9851
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@CarloToso
check for ContentType in Headers
23dd037
@CarloToso
CarloToso requested a review from Paul Higinbotham (PaulHigin) as a code owner February 26, 2023 12:08
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Small label Feb 26, 2023
@ghost ghost assigned Paul Higinbotham (PaulHigin) Feb 26, 2023
@CarloToso CarloToso mentioned this pull request Feb 26, 2023
Invoke-WebRequest should support -Encoding parameter for default character set #19226
Closed
@CarloToso
add 1 test
77d6c79
iSazonov
Ilya (iSazonov) reviewed Feb 28, 2023
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

@CarloToso
add Invoke-RestMethod test
8eff42c
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Mar 1, 2023

Copy link
Copy Markdown

This PR has 19 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +15 -4
Percentile : 7.6%

Total files changed: 2

Change summary by file extension:
.cs : +4 -3
.ps1 : +11 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov Ilya (iSazonov) added CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Documentation Needed in this repo Documentation is needed in this repo labels Mar 1, 2023
@iSazonov

Ilya (iSazonov) commented Mar 1, 2023

Copy link
Copy Markdown
Collaborator

CarloToso Please open new doc issue and add reference in the PR description.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CarloToso CarloToso mentioned this pull request Mar 1, 2023
Invoke-WebRequest if no -ContentType check -Headers @{Content-Type=...} MicrosoftDocs/PowerShell-Docs#9851
Closed
2 tasks done
@iSazonov Ilya (iSazonov) removed the Documentation Needed in this repo Documentation is needed in this repo label Mar 1, 2023
iSazonov
Ilya (iSazonov) approved these changes Mar 1, 2023
View reviewed changes
@iSazonov Ilya (iSazonov) changed the title WebCmdlets check for ContentType in Headers Take into account ContentType from Headers in WebCmdlets Mar 1, 2023
@iSazonov
Ilya (iSazonov) merged commit cf622f8 into PowerShell:master Mar 1, 2023
@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Paul Higinbotham (PaulHigin) Mar 1, 2023
@CarloToso
CarloToso deleted the Webcmdlets-use-content-type-in-headers branch March 1, 2023 18:23
@ghost

Deleted user (ghost) commented Mar 14, 2023

Copy link
Copy Markdown

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost mentioned this pull request Mar 14, 2023
Investigate possible BUG Invoke-WebRequest content type charset #19156
Closed
5 tasks done
@andrewsav-bt Andrew Savinykh (andrewsav-bt) mentioned this pull request Feb 28, 2024
Not possible to create a new session with New-F5Session joel74/POSH-LTM-Rest#237
Closed
@AndrewSav Andrew Savinykh (AndrewSav) mentioned this pull request Feb 28, 2024
Not possible to create a new session with New-F5Session joel74/POSH-LTM-Rest#238
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@CarloToso
Take into account ContentType from Headers in WebCmdlets (PowerShell#…
364a9aa
…19227)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate possible BUG Invoke-WebRequest content type charset

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@CarloToso @iSazonov @PaulHigin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.