GeezerVison is showing github.com — Add FileNameStar to MultipartFileContent in WebCmdlets by CarloToso · Pull Request #19467 · PowerShell/PowerShell
Conversation
CarloToso
commented
Apr 7, 2023
•
edited by SteveL-MSFT
Loading
Uh oh!
There was an error while loading. Please reload this page.
PR Summary
- Add FileNameStar to MultipartFileContent
- The parameters filename and filename* differ only in that filename* uses the encoding defined in RFC 5987. When both filename and filename* are present in a single header field value, filename* is preferred over filename when both are understood [from https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition]
- Now .Net add quotes as needed so remove the code.
PR Context
Removed linked issue as this PR doesn't fix that issue
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Make sure all
.h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
- Breaking changes
- User-facing changes
- Testing - New and feature
- Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
- Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
- Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Ilya (iSazonov)
changed the title
WebCmdlets add FileNameStar to MultipartFileContent
Add FileNameStar to MultipartFileContent in WebCmdlets
Apr 8, 2023
|
CarloToso Can you please update the PR description with more context information about why adding FileNameStar? Also, can you please confirm whether it fixes #19456?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Dongbo Wang (@daxian-dbw) Updated the PR description, I can't confirm it fixes the issue because it depends on the endpoint that recieves the Multipart/Form-Data
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
CarloToso reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
This did not fix the customer's issue. Do we still want to proceed with this fix?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
ghost
removed
the
Waiting on Author
The PR was reviewed and requires changes or comments from the author before being accept
label
May 2, 2023
|
This add useful standard behavior.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I pinged WG-Cmdlets to triage.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Looking at the HTTP specs, it seems that this is useful even though it doesn't solve the original problem.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
if we're adding new or altering current behavior, there should be some validation.
|
TravisEz13, TobiasPSP, and rkeithhill reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This really should have some validation of the behavior.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
|
// .NET does not enclose field names in quotes, however, modern browsers and curl do.
|
|
|
result.Headers.ContentDisposition.FileName = "\"" + file.Name + "\"";
|
|
|
result.Headers.ContentDisposition.FileName = file.Name;
|
|
|
result.Headers.ContentDisposition.FileNameStar = file.Name;
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have tests for this new behavior.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
CarloToso reacted with thumbs up emoji
CarloToso
May 8, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
I'll fix it tomorrow
Done
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
JamesWTruher reacted with thumbs up emoji
ghost
added
the
Waiting on Author
The PR was reviewed and requires changes or comments from the author before being accept
label
May 8, 2023
ghost
removed
the
Waiting on Author
The PR was reviewed and requires changes or comments from the author before being accept
label
May 8, 2023

This PR has 38 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!
Quantification details
Label : Extra Small
Size : +35 -3
Percentile : 15.2%
Total files changed: 2
Change summary by file extension:
.cs : +4 -3
.ps1 : +31 -0
Change counts above are quantified counts, based on the PullRequestQuantifier customizations.
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:
- Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
iterations.
- Similarity in low PR complexity drives similar review times.
- Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
- Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
- Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.
What can I do to optimize my changes
- Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the
Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your
prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your
prquantifier.yaml context profile.
- Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
- Your PR could be split in smaller, self-contained PRs instead
- Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).
How to interpret the change counts in git diff output
- One line was added:
+1 -0
- One line was deleted:
+0 -1
- One line was modified:
+1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
- Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@PowerShell/wg-powershell-cmdlets discussed this briefly and agree on supporting FileNameStar. The linked issue is not resolved by this PR, so we removed the link to the issue.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding the validation!
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:
Handy links:
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
It is possible this change is breaking Invoke-RestMethod calls with multipart/form-data, i.e.
$form = @{
"file" = Get-Item -Path $File
}
Invoke-RestMethod -Uri $Url -Method POST -Headers $headers -Form $form
results in an malformed request.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
|
|
|
|
// .NET does not enclose field names in quotes, however, modern browsers and curl do.
|
|
|
contentDisposition.Name = "\"" + LanguagePrimitives.ConvertTo<string>(fieldName) + "\"";
|
|
|
contentDisposition.Name = LanguagePrimitives.ConvertTo<string>(fieldName);
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This broke IWR for us when we upgraded to 7.4. We use IWR in a publish script to upload a zip to an internal PERL / CGI-based website. AFAICT the PERL CGI module requires field name values to be quoted. See #23843
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
+2 more reviewers
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|