GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add FileNameStar to MultipartFileContent in WebCmdlets by CarloToso · Pull Request #19467 · PowerShell/PowerShell

Conversation

@CarloToso

@CarloToso CarloToso commented Apr 7, 2023 •
edited by SteveL-MSFT
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

  1. Add FileNameStar to MultipartFileContent
  • The parameters filename and filename* differ only in that filename* uses the encoding defined in RFC 5987. When both filename and filename* are present in a single header field value, filename* is preferred over filename when both are understood [from https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition]
  1. Now .Net add quotes as needed so remove the code.

PR Context

Removed linked issue as this PR doesn't fix that issue

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@CarloToso
add FileNameStar to MultipartFileContent
f50bc9b
@CarloToso
CarloToso requested a review from Paul Higinbotham (PaulHigin) as a code owner April 7, 2023 18:38
@ghost ghost assigned Travis Plunk (TravisEz13) Apr 7, 2023
iSazonov
Ilya (iSazonov) reviewed Apr 8, 2023
View reviewed changes
Comment thread ...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@CarloToso
remove "\""
008e384
iSazonov
Ilya (iSazonov) approved these changes Apr 8, 2023
View reviewed changes
@iSazonov Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Apr 8, 2023
@iSazonov Ilya (iSazonov) changed the title WebCmdlets add FileNameStar to MultipartFileContent Add FileNameStar to MultipartFileContent in WebCmdlets Apr 8, 2023
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Apr 11, 2023

Copy link
Copy Markdown
Member

CarloToso Can you please update the PR description with more context information about why adding FileNameStar? Also, can you please confirm whether it fixes #19456?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CarloToso

CarloToso commented Apr 11, 2023

Copy link
Copy Markdown
Contributor Author

Dongbo Wang (@daxian-dbw) Updated the PR description, I can't confirm it fixes the issue because it depends on the endpoint that recieves the Multipart/Form-Data

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Apr 11, 2023
Invoke-RestMethod Multipart/Form-Data Filename encoding with non-ascii chars #19456
Closed
5 tasks done
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Apr 11, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Thanks CarloToso. Let's wait for the user to verify the fix.
#19456 (comment)

CarloToso reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost added the Review - Needed The PR is being reviewed label Apr 19, 2023
@ghost

Deleted user (ghost) commented Apr 19, 2023

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daxian-dbw Dongbo Wang (daxian-dbw) added WG-Cmdlets general cmdlet issues Needs-Triage The issue is new and needs to be triaged by a work group. labels May 1, 2023
@TravisEz13

Travis Plunk (TravisEz13) commented May 1, 2023

Copy link
Copy Markdown
Member

This did not fix the customer's issue. Do we still want to proceed with this fix?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost removed the Review - Needed The PR is being reviewed label May 1, 2023
@TravisEz13 Travis Plunk (TravisEz13) added Needs-Triage The issue is new and needs to be triaged by a work group. Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Needs-Triage The issue is new and needs to be triaged by a work group. labels May 1, 2023
@CarloToso

CarloToso commented May 2, 2023

Copy link
Copy Markdown
Contributor Author

Travis Plunk (@TravisEz13) I think we should merge this PR anyway

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 2, 2023
@iSazonov

Ilya (iSazonov) commented May 3, 2023

Copy link
Copy Markdown
Collaborator

This add useful standard behavior.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13

Travis Plunk (TravisEz13) commented May 8, 2023

Copy link
Copy Markdown
Member

I pinged WG-Cmdlets to triage.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented May 8, 2023

Copy link
Copy Markdown
Member

Looking at the HTTP specs, it seems that this is useful even though it doesn't solve the original problem.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes May 8, 2023
View reviewed changes
@JamesWTruher

James Truher (JamesWTruher) commented May 8, 2023

Copy link
Copy Markdown
Collaborator

if we're adding new or altering current behavior, there should be some validation.

TravisEz13, TobiasPSP, and rkeithhill reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JamesWTruher
James Truher (JamesWTruher) suggested changes May 8, 2023
View reviewed changes

@JamesWTruher James Truher (JamesWTruher) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really should have some validation of the behavior.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread ...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs
// .NET does not enclose field names in quotes, however, modern browsers and curl do.
result.Headers.ContentDisposition.FileName = "\"" + file.Name + "\"";
result.Headers.ContentDisposition.FileName = file.Name;
result.Headers.ContentDisposition.FileNameStar = file.Name;

@JamesWTruher James Truher (JamesWTruher) May 8, 2023

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have tests for this new behavior.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CarloToso reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@CarloToso CarloToso May 8, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
I'll fix it tomorrow
Done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JamesWTruher reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 8, 2023
@CarloToso
add test
bcb932e
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 8, 2023
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Small label May 8, 2023
CarloToso added 3 commits May 9, 2023 00:39
@CarloToso
add tests
54a1447
@CarloToso
forgot -Be
60fba13
@CarloToso
fix tests
50c3f74
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented May 8, 2023

Copy link
Copy Markdown

This PR has 38 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +35 -3
Percentile : 15.2%

Total files changed: 2

Change summary by file extension:
.cs : +4 -3
.ps1 : +31 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CarloToso
CarloToso requested a review from James Truher (JamesWTruher) May 9, 2023 10:24
@ghost ghost added the Review - Needed The PR is being reviewed label May 16, 2023
@ghost

Deleted user (ghost) commented May 16, 2023

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@StevenBucher98 Steven Bucher (StevenBucher98) added the PowerShell-Docs needed The PR was reviewed and a PowerShell Docs update is needed label Jun 5, 2023
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Jun 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@PowerShell/wg-powershell-cmdlets discussed this briefly and agree on supporting FileNameStar. The linked issue is not resolved by this PR, so we removed the link to the issue.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 7, 2023
@SteveL-MSFT Steve Lee (SteveL-MSFT) removed the Needs-Triage The issue is new and needs to be triaged by a work group. label Jun 7, 2023
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Jun 12, 2023
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good to me

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
JamesWTruher
James Truher (JamesWTruher) approved these changes Jun 12, 2023
View reviewed changes

@JamesWTruher James Truher (JamesWTruher) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the validation!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 1822ad7 into PowerShell:master Jun 12, 2023
@daxian-dbw Dongbo Wang (daxian-dbw) removed the PowerShell-Docs needed The PR was reviewed and a PowerShell Docs update is needed label Jun 12, 2023
@ghost

Deleted user (ghost) commented Jun 29, 2023

Copy link
Copy Markdown

🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@marekvinkler

Marek Vinkler (marekvinkler) commented Feb 2, 2024

Copy link
Copy Markdown

It is possible this change is breaking Invoke-RestMethod calls with multipart/form-data, i.e.

$form = @{
  "file"      = Get-Item -Path $File
}
Invoke-RestMethod -Uri $Url -Method POST -Headers $headers -Form $form

results in an malformed request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov Ilya (iSazonov) mentioned this pull request May 28, 2024
Using Invoke-WebRequest POST to upload a file is broken #23843
Open
5 tasks done
rkeithhill-keysight
Keith Hill (rkeithhill-keysight) reviewed Jun 27, 2024
View reviewed changes
Comment thread ...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs

// .NET does not enclose field names in quotes, however, modern browsers and curl do.
contentDisposition.Name = "\"" + LanguagePrimitives.ConvertTo<string>(fieldName) + "\"";
contentDisposition.Name = LanguagePrimitives.ConvertTo<string>(fieldName);

@rkeithhill-keysight Keith Hill (rkeithhill-keysight) Jun 27, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke IWR for us when we upgraded to 7.4. We use IWR in a publish script to upload a zip to an internal PERL / CGI-based website. AFAICT the PERL CGI module requires field name values to be quoted. See #23843

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@CarloToso
Add FileNameStar to MultipartFileContent in WebCmdlets (PowerShel…
436c742
…l#19467)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin
+2 more reviewers
@rkeithhill-keysight Keith Hill (rkeithhill-keysight) rkeithhill-keysight left review comments
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small WG-Cmdlets general cmdlet issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@CarloToso @daxian-dbw @TravisEz13 @iSazonov @SteveL-MSFT @JamesWTruher @marekvinkler @rkeithhill-keysight @StevenBucher98
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.