GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add ProductCode in registry for MSI install by adityapatwardhan · Pull Request #19590 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Apr 28, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Add a registry key for the generated ProductCode using an MSI install. This is useful for doing an uninstallation by reading the reg key and avoids calling WMI for it.

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ghost ghost assigned Paul Higinbotham (PaulHigin) Apr 28, 2023
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title Add ProductCode in registry for MSI install WIP: Add ProductCode in registry for MSI install Apr 28, 2023
@daxian-dbw Dongbo Wang (daxian-dbw) added the WG-Maintainers-Build specific to affecting the build label May 1, 2023
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title WIP: Add ProductCode in registry for MSI install Add ProductCode in registry for MSI install May 1, 2023
@daxian-dbw Dongbo Wang (daxian-dbw) added the Needs-Triage The issue is new and needs to be triaged by a work group. label May 1, 2023
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Backport-7.2.x-Consider labels May 1, 2023
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Small label May 1, 2023
TravisEz13
Travis Plunk (TravisEz13) approved these changes May 1, 2023
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) enabled auto-merge (squash) May 1, 2023 21:46
@TravisEz13

This comment was marked as off-topic.

Sign in to view
@azure-pipelines

This comment was marked as off-topic.

Sign in to view
@StevenBucher98 Steven Bucher (StevenBucher98) added the PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update label May 8, 2023
@PaulHigin

Paul Higinbotham (PaulHigin) commented May 9, 2023

Copy link
Copy Markdown
Contributor

Aditya Patwardhan (@adityapatwardhan) Please take a look at failing tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested review from Paul Higinbotham (PaulHigin), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners May 9, 2023 22:46
Aditya Patwardhan (adityapatwardhan) added 7 commits May 9, 2023 20:50
@adityapatwardhan
Add ProductCode in registry for MSI install
55aa8d4
@adityapatwardhan
Add test for validating ProductCode regkey is created
a86c6df
@adityapatwardhan
Add test better validation
2a9f12d
@adityapatwardhan
Fix test for x86 packages
da98255
@adityapatwardhan
Fixed the upgrade codes in test
a4e376c
@adityapatwardhan
Fix typo
4a3f2e8
@adityapatwardhan
return product code value
a336c09
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) force-pushed the AddProductCodeToMSIInstall branch from 2e55c8e to a336c09 Compare May 10, 2023 03:50
@adityapatwardhan
Revert inadvertant change
d71fd4c
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented May 10, 2023

Copy link
Copy Markdown

This PR has 21 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +21 -0
Percentile : 8.4%

Total files changed: 2

Change summary by file extension:
.wxs : +1 -0
.ps1 : +20 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13
Travis Plunk (TravisEz13) merged commit 7144ec7 into PowerShell:master May 10, 2023
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the AddProductCodeToMSIInstall branch May 26, 2023 21:08
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented May 26, 2023

Copy link
Copy Markdown
Member Author

We should wait for at least 1 preview release before backporting this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jun 28, 2023
@ghost

Deleted user (ghost) commented Jun 29, 2023

Copy link
Copy Markdown

🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13 Travis Plunk (TravisEz13) added Backport-7.3.x-Approved and removed Backport-7.3.x-Consider labels Jul 11, 2023
Travis Plunk (TravisEz13) pushed a commit to TravisEz13/PowerShell that referenced this pull request Jul 12, 2023
@adityapatwardhan @TravisEz13
Add ProductCode in registry for MSI install (PowerShell#19590)
65a8d2a 
* Add ProductCode in registry for MSI install

* Add test for validating ProductCode regkey is created

* Add test better validation
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Jul 12, 2023
[release/v7.3.6]Add ProductCode in registry for MSI install #19951
Merged
@TravisEz13 Travis Plunk (TravisEz13) added Backport-7.3.x-Done and removed Backport-7.3.x-Approved labels Jul 12, 2023
@TravisEz13 Travis Plunk (TravisEz13) added Backport-7.2.x-Approved and removed Backport-7.2.x-Consider labels Sep 6, 2023
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Sep 11, 2023
[release/v7.2.14]Add ProductCode in registry for MSI install #20233
Merged
Dongbo Wang (daxian-dbw) pushed a commit that referenced this pull request Sep 11, 2023
@adityapatwardhan @daxian-dbw
Add ProductCode in registry for MSI install (#19590)
a7f75b6 
* Add ProductCode in registry for MSI install

* Add test for validating ProductCode regkey is created

* Add test better validation
Dongbo Wang (daxian-dbw) added a commit that referenced this pull request Sep 11, 2023
@daxian-dbw
[release/v7.2.14] Add ProductCode in registry for MSI install (#19590…
729be90 
…) (#20233)
@daxian-dbw Dongbo Wang (daxian-dbw) added Backport-7.2.x-Done and removed Backport-7.2.x-Approved labels Sep 11, 2023
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Apr 16, 2024
WIP: add more detail to suspicious scriptblock logging #21475
Closed
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Jul 9, 2024
Add script to update SDK for release branches #24034
Merged
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan
Add ProductCode in registry for MSI install (PowerShell#19590)
22a8cd0 
* Add ProductCode in registry for MSI install

* Add test for validating ProductCode regkey is created

* Add test better validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@PaulHigin Paul Higinbotham (PaulHigin)

Labels

Backport-7.2.x-Done Backport-7.3.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small Needs-Triage The issue is new and needs to be triaged by a work group. PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update WG-Maintainers-Build specific to affecting the build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@adityapatwardhan @TravisEz13 @PaulHigin @daxian-dbw @StevenBucher98
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.