GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add WDAC Audit logging 3 by PaulHigin · Pull Request #19641 · PowerShell/PowerShell

Conversation

@PaulHigin

@PaulHigin Paul Higinbotham (PaulHigin) commented May 10, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

This PR adds WDAC audit logging using a different implementation from previous versions.

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s): PSConstrainedAuditLogging
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed: 10091
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Paul Higinbotham (PaulHigin) added 30 commits March 14, 2023 15:39
@PaulHigin
Initial check in
f643a88
@PaulHigin
Second wave implementation
73cbf1b
@PaulHigin
Third wave implementation
26dddfe
@PaulHigin
Fix up FL checks
b2d6504
@PaulHigin
Fix up CL checks
7c0e06d
@PaulHigin
Fix file check
e5dce9e
@PaulHigin
Fix missing method invocation logs
bf98edf
@PaulHigin
Fix target type name.
eb7977d
@PaulHigin
Add FQID to log
10f0362
@PaulHigin
Add actual logging calls
ea46b6d
@PaulHigin
Fix log logic
909e4ae
@PaulHigin
Fix logic and clean up
af2ed43
@PaulHigin
Add stub for LogWDACAuditMessage
3310de3
@PaulHigin
Add missing language mode to stub
3c60d6c
@PaulHigin
Fix CodeFactor and logic bug
c774587
@PaulHigin
Fix logic bug for COM
9d5b9de
@PaulHigin
Add Audit mode to binding language transition.
3b82f9a
@PaulHigin
Begin adding WDAC audit log strings to resources.
8161f8d
@PaulHigin
Move more WDAC messages to resources
d6dab7e
@PaulHigin
Final WDAC messages to resources
5706591
@PaulHigin
Make experimental feature.
075c6ff
@PaulHigin
Add scriptblock Id
4f2a7f9
@PaulHigin
Add debugger drop
01c636a
@PaulHigin
Add debugger conditions
82f8965
@PaulHigin
Fix debug break
55cdeba
@PaulHigin
Fix non-Windows build
dd921d7
@PaulHigin
Add script context to messages
4680b26
@PaulHigin
Fix debug position message
c79cb53
@PaulHigin
Fix position message for remote session
2ed7819
@PaulHigin
Add execution context to WDAC log method
bcb4286
Paul Higinbotham (PaulHigin) and others added 7 commits May 22, 2023 11:15
@PaulHigin @daxian-dbw
Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/New…
40811ce
…-Object.cs

Co-authored-by: Dongbo Wang <[email protected]>
@PaulHigin @daxian-dbw
Update src/System.Management.Automation/engine/CommandProcessorBase.cs
9de50b6
Co-authored-by: Dongbo Wang <[email protected]>
@PaulHigin @daxian-dbw
Update src/System.Management.Automation/engine/Modules/ModuleCmdletBa…
ec44bce
…se.cs

Co-authored-by: Dongbo Wang <[email protected]>
@PaulHigin @daxian-dbw
Update src/System.Management.Automation/engine/Modules/ModuleCmdletBa…
1cb2f58
…se.cs

Co-authored-by: Dongbo Wang <[email protected]>
@PaulHigin @daxian-dbw
Update src/System.Management.Automation/engine/Modules/ModuleCmdletBa…
6659779
…se.cs

Co-authored-by: Dongbo Wang <[email protected]>
@PaulHigin @daxian-dbw
Update src/System.Management.Automation/engine/Modules/NewModuleComma…
e7691c9
…nd.cs

Co-authored-by: Dongbo Wang <[email protected]>
@PaulHigin @daxian-dbw
Update src/System.Management.Automation/engine/LanguagePrimitives.cs
cae42e4
Co-authored-by: Dongbo Wang <[email protected]>
sdwheeler
Sean Wheeler (sdwheeler) suggested changes May 22, 2023
View reviewed changes
Comment thread src/System.Management.Automation/resources/Modules.resx Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/resources/ParserStrings.resx Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 22, 2023
@PaulHigin @daxian-dbw
Update src/System.Management.Automation/engine/debugger/debugger.cs
5136c3d
Co-authored-by: Dongbo Wang <[email protected]>
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 22, 2023
Paul Higinbotham (PaulHigin) and others added 2 commits May 22, 2023 13:00
@PaulHigin @daxian-dbw
Update src/System.Management.Automation/engine/Modules/ModuleCmdletBa…
c17fd21
…se.cs

Co-authored-by: Dongbo Wang <[email protected]>
@PaulHigin
Implement CR suggestions
ce8f375
sdwheeler
Sean Wheeler (sdwheeler) reviewed May 22, 2023
View reviewed changes
Comment thread src/System.Management.Automation/resources/ParserStrings.resx Resolved

Uh oh!

There was an error while loading. Please reload this page.

Paul Higinbotham (PaulHigin) and others added 2 commits May 22, 2023 14:13
@PaulHigin @sdwheeler
Update src/System.Management.Automation/resources/ParserStrings.resx
d00e431
Co-authored-by: Sean Wheeler <[email protected]>
@PaulHigin
Fix message tense
01bad2c
daxian-dbw
Dongbo Wang (daxian-dbw) reviewed May 22, 2023
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall. Left a few more comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread src/System.Management.Automation/engine/SessionStateScope.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/remoting/client/RunspaceRef.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/runtime/Operations/MiscOps.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/security/wldpNativeMethods.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Paul Higinbotham (PaulHigin) and others added 3 commits May 22, 2023 15:43
@PaulHigin @daxian-dbw
Update src/System.Management.Automation/engine/runtime/Operations/Mis…
6816980
…cOps.cs

Co-authored-by: Dongbo Wang <[email protected]>
@PaulHigin @daxian-dbw
Update src/System.Management.Automation/engine/Modules/ModuleCmdletBa…
a88ef43
…se.cs

Co-authored-by: Dongbo Wang <[email protected]>
@PaulHigin
More CR changes
9816fb8
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented May 22, 2023

Copy link
Copy Markdown

This PR has 885 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +700 -185
Percentile : 96.17%

Total files changed: 53

Change summary by file extension:
.cs : +529 -185
.resx : +171 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes May 22, 2023
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Paul Higinbotham (@PaulHigin) for pushing this change through!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@daxian-dbw Dongbo Wang (daxian-dbw) assigned Dongbo Wang (daxian-dbw) and unassigned Paul Higinbotham (PaulHigin) May 22, 2023
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label May 22, 2023
sdwheeler
Sean Wheeler (sdwheeler) approved these changes May 22, 2023
View reviewed changes

@sdwheeler Sean Wheeler (sdwheeler) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit e5728b6 into PowerShell:master May 22, 2023
@PaulHigin Paul Higinbotham (PaulHigin) mentioned this pull request May 23, 2023
Add documentation for new Constrained Language WDAC Audit Logging Experimental Feature MicrosoftDocs/PowerShell-Docs#10091
Closed
2 tasks done
@ghost

Deleted user (ghost) commented Jun 29, 2023

Copy link
Copy Markdown

🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@PaulHigin
Add WDAC Audit logging (PowerShell#19641)
e8e9b85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13 TravisEz13 is a code owner
+1 more reviewer
@sdwheeler Sean Wheeler (sdwheeler) sdwheeler approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log Extra Large PowerShell-Docs needed The PR was reviewed and a PowerShell Docs update is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@PaulHigin @daxian-dbw @sdwheeler @StevenBucher98
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.