GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Added `-CaseInsensitive` switch parameter to `Select-Object` & `Get-Unique` cmdlets by ArmaanMcleod · Pull Request #19683 · PowerShell/PowerShell

Conversation

@ArmaanMcleod

@ArmaanMcleod Armaan Mcleod (ArmaanMcleod) commented May 20, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Fixes #12059

Added -CaseInsensitive switch parameter to Select-Object & Get-Unique cmdlets.

PR Context

The Select-Object and Get-Unique cmdlets currently do case-sensitive string comparison when filtering unique items, and don't allow the user to override this behaviour and use case-insensitive comparison.

To make sure no breaking change is introduced, the most ideal solution is to introduce a -CaseInsensitive parameter.

Examples

Select-Object -Unique

> "derp", "Derp" | Select-Object -Unique
derp
Derp

> "derp", "Derp" | Select-Object -Unique -CaseInsensitive
derp

Get-Unique

> "aa", "Aa", "bb", "Bb" | Get-Unique
aa
Aa
bb
Bb

> "aa", "Aa", "bb", "Bb" | Get-Unique -AsString -CaseInsensitive
aa
bb

> "aa", "Aa", "bb", "Bb" | Get-Unique -CaseInsensitive
aa
bb

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed: Add -CaseInsensitive switch parameter to Select-Object & Get-Unique cmdlet documentation MicrosoftDocs/PowerShell-Docs#10097
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

doctordns reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Armaan Mcleod (ArmaanMcleod) added 2 commits May 20, 2023 18:06
@ArmaanMcleod
Added Select-Object CaseInsensitive parameter and tests
a67f83a
@ArmaanMcleod
Added Get-Unique CaseInsensitive parameter and tests
336cc44
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Small label May 20, 2023
@ghost ghost assigned Travis Plunk (TravisEz13) May 20, 2023
@ArmaanMcleod
Fix codefactor issue
35f743b
@ArmaanMcleod
Armaan Mcleod (ArmaanMcleod) marked this pull request as ready for review May 20, 2023 08:44
@ArmaanMcleod
Armaan Mcleod (ArmaanMcleod) requested a review from Paul Higinbotham (PaulHigin) as a code owner May 20, 2023 08:44
iSazonov
Ilya (iSazonov) reviewed May 20, 2023
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/GetUnique.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

iSazonov
Ilya (iSazonov) reviewed May 20, 2023
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/Select-Object.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ArmaanMcleod
Add named arguements
67957a2
ArmaanMcleod
Armaan Mcleod (ArmaanMcleod) commented May 20, 2023
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/GetUnique.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ArmaanMcleod
Remove comments
f407fe4
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented May 21, 2023

Copy link
Copy Markdown

This PR has 34 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +29 -5
Percentile : 13.6%

Total files changed: 4

Change summary by file extension:
.cs : +11 -4
.ps1 : +18 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ArmaanMcleod
Armaan Mcleod (ArmaanMcleod) requested a review from Ilya (iSazonov) May 21, 2023 11:12
@StevenBucher98 Steven Bucher (StevenBucher98) added PowerShell-Docs needed The PR was reviewed and a PowerShell Docs update is needed WG-Cmdlets-Utility labels May 22, 2023
@ArmaanMcleod Armaan Mcleod (ArmaanMcleod) mentioned this pull request May 26, 2023
Add -CaseInsensitive switch parameter to Select-Object & Get-Unique cmdlet documentation MicrosoftDocs/PowerShell-Docs#10097
Closed
2 tasks done
@ghost ghost added the Review - Needed The PR is being reviewed label Jun 2, 2023
@ghost

Deleted user (ghost) commented Jun 2, 2023

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@doctordns Thomas Lee (doctordns) added the WG-Cmdlets general cmdlet issues label Jun 9, 2023
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Jun 21, 2023

Copy link
Copy Markdown
Member

@PowerShell/wg-powershell-cmdlets reviewed this, we agree that adding a -CaseInsensitive switch makes sense particularly the internals also support it and just hard coded to be case sensitive.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 21, 2023
iSazonov
Ilya (iSazonov) approved these changes Jun 21, 2023
View reviewed changes
@ghost ghost added the Review - Needed The PR is being reviewed label Jun 29, 2023
@ghost

Deleted user (ghost) commented Jun 29, 2023

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@SteveL-MSFT Steve Lee (SteveL-MSFT) added WG-Reviewed A Working Group has reviewed this and made a recommendation CommunityDay-Small A small PR that the PS team has identified to prioritize to review labels Jul 5, 2023
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Jul 24, 2023
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@TravisEz13
Travis Plunk (TravisEz13) merged commit 836c0c5 into PowerShell:master Jul 24, 2023
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the Review - Needed The PR is being reviewed label Jul 24, 2023
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jul 24, 2023
@ArmaanMcleod
Armaan Mcleod (ArmaanMcleod) deleted the case-insensitive-select-object-and-get-unique-cmdlets branch July 24, 2023 20:00
@surfingoldelephant surfingoldelephant mentioned this pull request Jan 1, 2026
about_Case-Sensitivity lacks detail in a lot of areas MicrosoftDocs/PowerShell-Docs#12624
Closed
3 tasks done
@kilasuit Ryan Yates (kilasuit) removed the WG-Cmdlets-Utility label Jul 17, 2026
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@ArmaanMcleod
Added -CaseInsensitive switch parameter to Select-Object & `Get-U…
2365666
…nique` cmdlets (PowerShell#19683)

* Added Select-Object CaseInsensitive parameter and tests

* Added Get-Unique CaseInsensitive parameter and tests

* Fix codefactor issue

* Add named arguements

* Remove comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log CommunityDay-Small A small PR that the PS team has identified to prioritize to review Extra Small PowerShell-Docs needed The PR was reviewed and a PowerShell Docs update is needed WG-Cmdlets general cmdlet issues WG-Reviewed A Working Group has reviewed this and made a recommendation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Select-Object -unique is inconsistently case sensitive

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@ArmaanMcleod @SteveL-MSFT @iSazonov @daxian-dbw @doctordns @kilasuit @TravisEz13 @StevenBucher98
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.