GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make `Update-Help` throw proper error when current culture is not associated with a language by josea · Pull Request #19765 · PowerShell/PowerShell

Conversation

@josea

@josea josea commented Jun 7, 2023 •
edited by daxian-dbw
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Fix #19633

Fix logic to check for no language in current culture (linux C.UTF-8).

PR Context

Check the current culture (if no parameter is passed). If no language is found, throw exception with the designated message.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed: 19633
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@josea
josea requested a review from Aditya Patwardhan (adityapatwardhan) as a code owner June 7, 2023 20:06
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Small label Jun 7, 2023
@ghost ghost assigned Andrew (anmenaga) Jun 7, 2023
@josea

josea commented Jun 7, 2023

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@josea josea closed this Jun 7, 2023
@josea
josea force-pushed the issue-19633-update-error-culture-C.UTF8 branch from 1489fe0 to b159db3 Compare June 7, 2023 20:13
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added No Changes and removed Extra Small labels Jun 7, 2023
@josea josea reopened this Jun 7, 2023
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added Extra Small and removed No Changes labels Jun 7, 2023
@StevenBucher98 Steven Bucher (StevenBucher98) added the PowerShell-Docs needed The PR was reviewed and a PowerShell Docs update is needed label Jun 12, 2023
SteveL-MSFT
Steve Lee (SteveL-MSFT) reviewed Jun 12, 2023
View reviewed changes
Comment thread src/System.Management.Automation/resources/HelpDisplayStrings.resx Resolved

Uh oh!

There was an error while loading. Please reload this page.

adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested changes Jun 19, 2023
View reviewed changes
Comment thread src/System.Management.Automation/resources/HelpDisplayStrings.resx Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Jun 19, 2023
@josea

josea commented Jun 19, 2023

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) : ok, so that's an option. See how it looks like.

image

adityapatwardhan and beedell-roke reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Jun 19, 2023

Copy link
Copy Markdown
Member

josea I like the one above. Please push the changes and I will re-review. Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Jun 19, 2023

Copy link
Copy Markdown
Member

Also, please check CI failures for the test you added.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@josea
josea force-pushed the issue-19633-update-error-culture-C.UTF8 branch from 034c974 to b608697 Compare June 19, 2023 20:54
@josea
josea requested review from Travis Plunk (TravisEz13), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners June 19, 2023 20:54
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added Small and removed Extra Small labels Jun 19, 2023
@josea
josea force-pushed the issue-19633-update-error-culture-C.UTF8 branch from b608697 to 7c3f5b6 Compare June 19, 2023 21:07
@josea

josea commented Jun 19, 2023

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) : changes are done. CI now passes.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daxian-dbw

Dongbo Wang (daxian-dbw) commented Jun 19, 2023

Copy link
Copy Markdown
Member

josea CIs are all failing, please take a look.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@josea
josea force-pushed the issue-19633-update-error-culture-C.UTF8 branch from 7c3f5b6 to 014217b Compare June 19, 2023 22:41
daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Jun 19, 2023
View reviewed changes
Comment thread test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Jun 19, 2023

Copy link
Copy Markdown
Member

The PR has unrelated commits, it needs to be rebased.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daxian-dbw Dongbo Wang (daxian-dbw) added CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Jun 19, 2023
SteveL-MSFT
Steve Lee (SteveL-MSFT) previously requested changes Jun 19, 2023
View reviewed changes
Comment thread src/System.Management.Automation/resources/HelpDisplayStrings.resx Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 20, 2023
@josea
Add error message when trying to Update-Help in a Linux system with C…
df3a79e
….UTF-8 culture (issue 19765).
@josea
josea force-pushed the issue-19633-update-error-culture-C.UTF8 branch from 014217b to df3a79e Compare June 20, 2023 12:38
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added Extra Small and removed Small labels Jun 20, 2023
@josea

josea commented Jun 20, 2023

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) : I cleaned the commit.

Dongbo Wang (@daxian-dbw) , Aditya Patwardhan (@adityapatwardhan) : I am having issues with the tests. They are failing and I am not sure it is related to my changes. See image below - it seems a test is setting up a web listener and it times out. I have no way to re-run the test (other than change the commit forcing it to happen again, but ideally I would just re-run this test to see what is happening).

Still, the error doesn't seem to be related to my changes. Please advise.

image

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

adityapatwardhan
Aditya Patwardhan (adityapatwardhan) reviewed Jun 20, 2023
View reviewed changes
Comment thread src/System.Management.Automation/help/UpdateHelpCommand.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@adityapatwardhan
Update src/System.Management.Automation/help/UpdateHelpCommand.cs
25b32ff
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Jun 20, 2023
View reviewed changes
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Jun 20, 2023

Copy link
Copy Markdown
Member

josea pushed 1 small change. Rest looks good. The test failure is intermittent and does typically work fine on re-run.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Jun 20, 2023

Copy link
Copy Markdown

This PR has 13 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +13 -0
Percentile : 5.2%

Total files changed: 3

Change summary by file extension:
.cs : +7 -0
.resx : +3 -0
.ps1 : +3 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@josea
josea requested a review from Steve Lee (SteveL-MSFT) June 20, 2023 15:44
@daxian-dbw
Dongbo Wang (daxian-dbw) dismissed Steve Lee (SteveL-MSFT)’s stale review June 20, 2023 16:47

Comment was addressed.

@daxian-dbw Dongbo Wang (daxian-dbw) changed the title Add check for no UI language in the current culture (linux C.UTF-8) t… Make Update-Help throw proper error when current culture is not associated with a language Jun 20, 2023
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 16558c9 into PowerShell:master Jun 20, 2023
@josea
josea deleted the issue-19633-update-error-culture-C.UTF8 branch June 20, 2023 17:30
@ghost

Deleted user (ghost) commented Jun 29, 2023

Copy link
Copy Markdown

🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost mentioned this pull request Jun 29, 2023
Update error message of Update-Help when culture is C.UTF8 #19633
Closed
5 tasks done
@sdwheeler Sean Wheeler (sdwheeler) mentioned this pull request Nov 17, 2023
Unable to get help files for cultures other than en-US #6217
Closed
@sdwheeler Sean Wheeler (sdwheeler) mentioned this pull request Dec 11, 2023
Update-Help fails on Windows 10.0.20206 #13591
Open
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@josea
Make Update-Help throw proper error when current culture is not ass…
71b1bfc
…ociated with a language (PowerShell#19765)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw left review comments
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@anmenaga Andrew (anmenaga)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small PowerShell-Docs needed The PR was reviewed and a PowerShell Docs update is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update error message of Update-Help when culture is C.UTF8

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@josea @adityapatwardhan @daxian-dbw @SteveL-MSFT @anmenaga @StevenBucher98
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.