GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Change variable used to bypass nuget security scanning by TravisEz13 · Pull Request #19907 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Jul 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

  • Change variable used to bypass nuget security scanning
    • Also, add some diagnostics code provider by James Truher (@JamesWTruher)

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Small label Jul 7, 2023
@TravisEz13 Travis Plunk (TravisEz13) added Backport-7.2.x-Consider labels Jul 7, 2023
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Jul 7, 2023
View reviewed changes
JamesWTruher
James Truher (JamesWTruher) approved these changes Jul 7, 2023
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) marked this pull request as ready for review July 7, 2023 20:29
@TravisEz13
Travis Plunk (TravisEz13) requested review from Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners July 7, 2023 20:29
James Truher (JamesWTruher) and others added 4 commits July 7, 2023 20:31
@JamesWTruher @TravisEz13
Add debugging output to determine whether the nuget.config really doe…
63f7fec 
…s have multiple feeds.
@TravisEz13
Fix up all the nuget config changes
1b51ff6
@TravisEz13
Add new variable.
8dad207
@TravisEz13
Revert "Fix up all the nuget config changes"
5eea57e 
This reverts commit 04a963da70011c48b9c50ef9d02a9eed2a06cc67.
@TravisEz13
Travis Plunk (TravisEz13) force-pushed the NugetFeedFix01 branch from 062366a to 5eea57e Compare July 7, 2023 20:31
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Jul 7, 2023

Copy link
Copy Markdown

This PR has 18 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +14 -4
Percentile : 7.2%

Total files changed: 2

Change summary by file extension:
.yml : +14 -4

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13
Travis Plunk (TravisEz13) enabled auto-merge (squash) July 7, 2023 20:32
@TravisEz13
Travis Plunk (TravisEz13) merged commit 8eb767d into PowerShell:master Jul 7, 2023
@TravisEz13 Travis Plunk (TravisEz13) added Backport-7.2.x-Approved and removed Backport-7.2.x-Consider labels Jul 11, 2023
Travis Plunk (TravisEz13) added a commit to TravisEz13/PowerShell that referenced this pull request Jul 12, 2023
@TravisEz13 @JamesWTruher
Change variable used to bypass nuget security scanning (PowerShell#19907
30f3242 
)

* Add debugging output to determine whether the nuget.config really does have multiple feeds.

* Fix up all the nuget config changes

* Add new variable.

* Revert "Fix up all the nuget config changes"

This reverts commit 04a963da70011c48b9c50ef9d02a9eed2a06cc67.

---------

Co-authored-by: James Truher <[email protected]>
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Jul 12, 2023
[release/v7.2.13]Change variable used to bypass nuget security scanning #19935
Merged
@TravisEz13 Travis Plunk (TravisEz13) added Backport-7.2.x-Done and removed Backport-7.2.x-Approved labels Jul 12, 2023
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Jul 12, 2023
[release/v7.3.6]Change variable used to bypass nuget security scanning #19953
Merged
@TravisEz13
Travis Plunk (TravisEz13) deleted the NugetFeedFix01 branch July 12, 2023 21:15
@TravisEz13 Travis Plunk (TravisEz13) added Backport-7.3.x-Done and removed Backport-7.3.x-Approved labels Jul 12, 2023
@SeeminglyScience Patrick Meinecke (SeeminglyScience) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Aug 17, 2023
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13 @JamesWTruher
Change variable used to bypass nuget security scanning (PowerShell#19907
4dda166 
)

* Add debugging output to determine whether the nuget.config really does have multiple feeds.

* Fix up all the nuget config changes

* Add new variable.

* Revert "Fix up all the nuget config changes"

This reverts commit 04a963da70011c48b9c50ef9d02a9eed2a06cc67.

---------

Co-authored-by: James Truher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
+1 more reviewer
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Backport-7.2.x-Done Backport-7.3.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@TravisEz13 @JamesWTruher @SteveL-MSFT @SeeminglyScience
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.