GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add mariner arm64 package build to release build by anamnavi · Pull Request #19946 · PowerShell/PowerShell

Conversation

@anamnavi

@anamnavi Anam Navied (anamnavi) commented Jul 12, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Add mariner arm64 package build to release build

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@anamnavi
add mariner arm64 package build to release build
433e483
@anamnavi
Anam Navied (anamnavi) requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners July 12, 2023 18:51
@microsoft-github-policy-service microsoft-github-policy-service Bot assigned Aditya Patwardhan (adityapatwardhan), Dongbo Wang (daxian-dbw), Ilya (iSazonov), Patrick Meinecke (SeeminglyScience) and Travis Plunk (TravisEz13) Jul 12, 2023
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Small label Jul 12, 2023
Anam Navied (anamnavi) added 2 commits July 12, 2023 19:25
@anamnavi
add conditions for mariner arm64 in build where needed
79e3476
@anamnavi
add SBOM for mariner arm64
5ac95c8
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added Small and removed Extra Small labels Jul 12, 2023
Anam Navied (anamnavi) added 4 commits July 12, 2023 19:45
@anamnavi
validate package name for rpm
69847f9
@anamnavi
add linux-arm64-mariner to releaseBuild matrix
62c07fd
@anamnavi
fix linux-arm64-mariner name
23b6f2d
@anamnavi
add build condition for mariner arm64 to Invoke-AzDevOpsLinuxPackageB…
1eb15dc
…uild
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added Medium and removed Small labels Jul 13, 2023
Anam Navied (anamnavi) added 3 commits July 13, 2023 13:09
@anamnavi
correct Start-PSPackage -Type for mariner-arm64
b823604
@anamnavi
don't set HostArtchitecture in loop as its set before and the var is …
5b78b1b
…empty in the loop
@anamnavi
Merge branch 'master' of https://github.com/anamnavi/PowerShell into …
ae5d370
…mariner-arm64-release-build
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Jul 14, 2023

Copy link
Copy Markdown

This PR has 106 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Medium
Size       : +97 -9
Percentile : 41.2%

Total files changed: 6

Change summary by file extension:
.psm1 : +30 -4
.yml : +67 -5

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Jul 17, 2023
View reviewed changes
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested changes Jul 17, 2023
View reviewed changes

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a update to the expected package names here:

PowerShell/tools/releaseBuild/azureDevOps/templates/release-ValidatePackageNames.yml

Lines 33 to 35 in 3ce65f3

Get-ChildItem $(System.ArtifactsDirectory)\* -recurse -filter *.rpm | ForEach-Object {
if($_.Name -notmatch 'powershell\-(preview-|lts-)?\d+\.\d+\.\d+(_[a-z]*\.\d+)?-1.(rh|cm).x86_64\.rpm')
{

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jul 17, 2023
@StevenBucher98 Steven Bucher (StevenBucher98) added the PowerShell-Docs needed The PR was reviewed and a PowerShell Docs update is needed label Jul 17, 2023
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Jul 17, 2023
View reviewed changes
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jul 17, 2023
TravisEz13
Travis Plunk (TravisEz13) approved these changes Jul 20, 2023
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit d712c45 into PowerShell:master Jul 20, 2023
@TravisEz13 Travis Plunk (TravisEz13) added Backport-7.2.x-Consider MustHave and removed Backport-7.3.x-Consider labels Sep 5, 2023
@TravisEz13

Travis Plunk (TravisEz13) commented Sep 6, 2023

Copy link
Copy Markdown
Member

@PowerShell/powershell-maintainers We will defer backporting to LTS until we have more data.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Sep 11, 2023
[release/v7.3.7]Add mariner arm64 package build to release build #20250
Merged
Dongbo Wang (daxian-dbw) pushed a commit that referenced this pull request Sep 11, 2023
@anamnavi @daxian-dbw
Add mariner arm64 package build to release build (#19946)
2a01164
Dongbo Wang (daxian-dbw) added a commit that referenced this pull request Sep 11, 2023
@daxian-dbw
[release/v7.3.7] Add mariner arm64 package build to release build (#1…
3c7009c
…9946) (#20250)
@daxian-dbw Dongbo Wang (daxian-dbw) added Backport-7.3.x-Done and removed Backport-7.3.x-Approved labels Sep 11, 2023
@TravisEz13 Travis Plunk (TravisEz13) removed the MustHave label Sep 20, 2023
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Backport-7.2.x-Approved and removed Backport-7.2.x-Consider labels Oct 24, 2023
Aditya Patwardhan (adityapatwardhan) pushed a commit that referenced this pull request Oct 24, 2023
@anamnavi @adityapatwardhan
Add mariner arm64 package build to release build (#19946)
3229c83
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) mentioned this pull request Oct 24, 2023
[release/v7.2.16]Add mariner arm64 package build to release build #20566
Merged
Aditya Patwardhan (adityapatwardhan) added a commit that referenced this pull request Oct 24, 2023
@adityapatwardhan
Add mariner arm64 package build to release build (#19946) (#20566)
5d5382b
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Backport-7.2.x-Done and removed Backport-7.2.x-Approved labels Oct 24, 2023
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Apr 16, 2024
WIP: add more detail to suspicious scriptblock logging #21475
Closed
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Jul 9, 2024
Add script to update SDK for release branches #24034
Merged
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@anamnavi
Add mariner arm64 package build to release build (PowerShell#19946)
eab83da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

@TravisEz13 Travis Plunk (TravisEz13)

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

@iSazonov Ilya (iSazonov)

@SeeminglyScience Patrick Meinecke (SeeminglyScience)

Labels

Backport-7.2.x-Done Backport-7.3.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Medium PowerShell-Docs needed The PR was reviewed and a PowerShell Docs update is needed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@anamnavi @TravisEz13 @adityapatwardhan @daxian-dbw @StevenBucher98 @iSazonov @SeeminglyScience
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.