GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixing PS 7.4 regression that is breaking DSCv3 by anmenaga · Pull Request #20268 · PowerShell/PowerShell

Conversation

@anmenaga

@anmenaga Andrew (anmenaga) commented Sep 12, 2023

Copy link
Copy Markdown

PR Summary

Some constants/resource strings, used by DSCv3, were accidentally removed by these 2 PRs:
#18383
#18154

Adding these back to PS 7.4 to avoid re-release of DSCv3 module.

PR Context

DSC repo issue: PowerShell/DSC#128

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Andrew
Fixing regression in DSC
1af6da7
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Small label Sep 12, 2023
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Sep 12, 2023

Copy link
Copy Markdown

This PR has 4 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +4 -0
Percentile : 1.6%

Total files changed: 2

Change summary by file extension:
.cs : +1 -0
.resx : +3 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@anmenaga
Andrew (anmenaga) requested review from Steve Lee (SteveL-MSFT) and Dongbo Wang (daxian-dbw) and removed request for Steve Lee (SteveL-MSFT) September 12, 2023 20:39
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Sep 12, 2023
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are only used by PSDSC, would it make more sense to make changes in that code to be self-contained rather than reaching into SMA.dll?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 12, 2023
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Sep 12, 2023
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with Andrew. Since we still have some DSC code in SMA.dll, it would be simpler for now to put these lines back and remove them along with the remaining DSC code in the future aligned with a new PSDSC 3.0 release

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@anmenaga
Andrew (anmenaga) merged commit 6d23f72 into PowerShell:master Sep 13, 2023
iSazonov
Ilya (iSazonov) reviewed Sep 13, 2023
View reviewed changes
Comment thread src/System.Management.Automation/engine/Utils.cs

internal static class Separators
{
internal static readonly char[] Backslash = new char[] { '\\' };

@iSazonov Ilya (iSazonov) Sep 13, 2023

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wander how and why DSC uses the internal?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ertyz reacted with laugh emoji
All reactions
  • 😄 1 reaction
@SteveL-MSFT Steve Lee (SteveL-MSFT) added this to the 7.4-Consider milestone Sep 29, 2023
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the Backport-7.4.x-Consider label Sep 29, 2023
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Backport-7.4.x-Approved and removed Backport-7.4.x-Consider labels Oct 19, 2023
Aditya Patwardhan (adityapatwardhan) pushed a commit that referenced this pull request Oct 19, 2023
Andrew @adityapatwardhan
Fixing regression in DSC (#20268)
7435755
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) mentioned this pull request Oct 19, 2023
[release/v7.4.0-preview.7]Fixing PS 7.4 regression that is breaking DSCv3 #20528
Merged
Aditya Patwardhan (adityapatwardhan) added a commit that referenced this pull request Oct 19, 2023
@adityapatwardhan
Fixing regression in DSC (#20268) (#20528)
62699bd
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Backport-7.4.x-Done CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log and removed Backport-7.4.x-Approved labels Oct 19, 2023
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Andrew
Fixing regression in DSC (PowerShell#20268)
79db098
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan
Fixing regression in DSC (PowerShell#20268) (PowerShell#20528)
2e8f312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov left review comments
@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Backport-7.4.x-Done CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept

Projects

None yet

Milestone

7.4-Consider

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@anmenaga @SteveL-MSFT @iSazonov @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.