GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||
GeezerVison is showing github.com — Fixing PS 7.4 regression that is breaking DSCv3 by anmenaga · Pull Request #20268 · PowerShell/PowerShell ConversationPR SummarySome constants/resource strings, used by DSCv3, were accidentally removed by these 2 PRs: Adding these back to PS 7.4 to avoid re-release of DSCv3 module. PR ContextDSC repo issue: PowerShell/DSC#128 PR Checklist
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Andrew (anmenaga)
requested review from
Steve Lee (SteveL-MSFT) and
Dongbo Wang (daxian-dbw)
and removed request for
Steve Lee (SteveL-MSFT)
Steve Lee (SteveL-MSFT)
requested changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since these are only used by PSDSC, would it make more sense to make changes in that code to be self-contained rather than reaching into SMA.dll?
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Steve Lee (SteveL-MSFT)
approved these changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Discussed with Andrew. Since we still have some DSC code in SMA.dll, it would be simpler for now to put these lines back and remove them along with the remaining DSC code in the future aligned with a new PSDSC 3.0 release
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wander how and why DSC uses the internal?
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Aditya Patwardhan (adityapatwardhan)
pushed a commit
that referenced
this pull request
Aditya Patwardhan (adityapatwardhan)
added a commit
that referenced
this pull request
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
Backport-7.4.x-Done
CL-General
ProjectsDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |