GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Bump PSReadLine from 2.2.6 to 2.3.4 by daxian-dbw · Pull Request #20305 · PowerShell/PowerShell

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Sep 19, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Bump PSReadLine from 2.2.6 to 2.3.4.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@daxian-dbw
Dongbo Wang (daxian-dbw) requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan) and Andrew (anmenaga) as code owners September 19, 2023 17:51
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Sep 19, 2023
Bump PSReadLine from 2.2.6 to 2.3.3 in /src/Modules #20301
Closed
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Small label Sep 19, 2023
@daxian-dbw Dongbo Wang (daxian-dbw) added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Backport-7.4.x-Consider labels Sep 20, 2023
@daxian-dbw Dongbo Wang (daxian-dbw) closed this Sep 20, 2023
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Sep 20, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Hold off the change because a regression was found with v2.3.3 on Win10 when running in the legacy console host, see PowerShell/PSReadLine#3805
The regression has been fixed in v2.3.4

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daxian-dbw Dongbo Wang (daxian-dbw) removed the Backport-7.4.x-Consider label Sep 20, 2023
@daxian-dbw Dongbo Wang (daxian-dbw) reopened this Oct 3, 2023
@daxian-dbw
Dongbo Wang (daxian-dbw) force-pushed the psreadline branch from 15c7b00 to 1f8fd2c Compare October 3, 2023 14:13
@daxian-dbw Dongbo Wang (daxian-dbw) changed the title Bump PSReadLine from 2.2.6 to 2.3.3 Bump PSReadLine from 2.2.6 to 2.3.4 Oct 3, 2023
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Oct 3, 2023
Bump PSReadLine from 2.2.6 to 2.3.4 in /src/Modules #20424
Closed
Dongbo Wang (daxian-dbw) added 2 commits October 3, 2023 09:12
@daxian-dbw
Bump PSReadLine from 2.2.6 to 2.3.4
879cf2d
@daxian-dbw
Update bom.json
3d55433
@daxian-dbw
Dongbo Wang (daxian-dbw) force-pushed the psreadline branch from 1f8fd2c to 3d55433 Compare October 3, 2023 16:12
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Oct 3, 2023

Copy link
Copy Markdown

This PR has 10 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +6 -4
Percentile : 4%

Total files changed: 3

Change summary by file extension:
.csproj : +1 -1
.ps1 : +2 -2
.json : +3 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 109c242 into PowerShell:master Oct 3, 2023
@daxian-dbw Dongbo Wang (daxian-dbw) added the Backport-7.4.x-Consider label Oct 3, 2023
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the psreadline branch October 3, 2023 18:29
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Backport-7.4.x-Approved and removed Backport-7.4.x-Consider labels Oct 19, 2023
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) mentioned this pull request Oct 19, 2023
[release/v7.4.0-preview.7]Bump PSReadLine from 2.2.6 to 2.3.4 #20533
Merged
Aditya Patwardhan (adityapatwardhan) pushed a commit that referenced this pull request Oct 20, 2023
@daxian-dbw @adityapatwardhan
Bump PSReadLine from 2.2.6 to 2.3.4 (#20305)
e88123a
Aditya Patwardhan (adityapatwardhan) added a commit that referenced this pull request Oct 20, 2023
@adityapatwardhan
Bump PSReadLine from 2.2.6 to 2.3.4 (#20305) (#20533)
b60d565
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Backport-7.4.x-Done and removed Backport-7.4.x-Approved labels Oct 20, 2023
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@daxian-dbw
Bump PSReadLine from 2.2.6 to 2.3.4 (PowerShell#20305)
ccce03f
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan
Bump PSReadLine from 2.2.6 to 2.3.4 (PowerShell#20305) (PowerShell#20533
0f4459a
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Backport-7.4.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@daxian-dbw @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.