GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix unixmode to handle setuid/sticky when not executable by JamesWTruher · Pull Request #20366 · PowerShell/PowerShell

Conversation

@JamesWTruher

@JamesWTruher James Truher (JamesWTruher) commented Sep 25, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

This is a fix for #20278

PR Context

I'm not addressing the CodeFactor reported complexity as I don't believe this method is overly complicated.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Small label Sep 25, 2023
@StevenBucher98 Steven Bucher (StevenBucher98) added the PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update label Sep 25, 2023
@JamesWTruher James Truher (JamesWTruher) added the WG-Engine core PowerShell engine, interpreter, and runtime label Sep 25, 2023
@JamesWTruher
James Truher (JamesWTruher) requested review from Patrick Meinecke (SeeminglyScience), Steve Lee (SteveL-MSFT) and Aditya Patwardhan (adityapatwardhan) September 25, 2023 21:39
@JamesWTruher James Truher (JamesWTruher) changed the title WIP: fix unixmode to handle setuid/sticky when not executable Fx unixmode to handle setuid/sticky when not executable Sep 25, 2023
@JamesWTruher James Truher (JamesWTruher) changed the title Fx unixmode to handle setuid/sticky when not executable Fix unixmode to handle setuid/sticky when not executable Sep 25, 2023
iSazonov
Ilya (iSazonov) reviewed Sep 26, 2023
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/UnixStat.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

iSazonov
Ilya (iSazonov) reviewed Sep 29, 2023
View reviewed changes
Comment thread src/System.Management.Automation/CoreCLR/CorePsPlatform.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@JamesWTruher
James Truher (JamesWTruher) force-pushed the UnixModeStringFix01 branch from ff2c2b3 to 310c4d5 Compare October 2, 2023 23:24
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Oct 3, 2023

Copy link
Copy Markdown

This PR has 68 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Small
Size       : +41 -27
Percentile : 27.2%

Total files changed: 2

Change summary by file extension:
.cs : +30 -25
.ps1 : +11 -2

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iSazonov
Ilya (iSazonov) approved these changes Oct 3, 2023
View reviewed changes
Comment thread src/System.Management.Automation/CoreCLR/CorePsPlatform.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@microsoft-github-policy-service microsoft-github-policy-service Bot added the Review - Needed The PR is being reviewed label Oct 10, 2023
daxian-dbw
Dongbo Wang (daxian-dbw) requested changes Oct 11, 2023
View reviewed changes
Comment thread src/System.Management.Automation/CoreCLR/CorePsPlatform.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/CoreCLR/CorePsPlatform.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@microsoft-github-policy-service microsoft-github-policy-service Bot added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed labels Oct 11, 2023
daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Oct 11, 2023
View reviewed changes
Comment thread src/System.Management.Automation/CoreCLR/CorePsPlatform.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@microsoft-github-policy-service microsoft-github-policy-service Bot removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 11, 2023
James Truher (JamesWTruher) and others added 8 commits October 11, 2023 16:14
@JamesWTruher
Change the way the mode string is created on Unix system.
fee81e8
@JamesWTruher
Add tests to cover more modes.
205a65e
@JamesWTruher
Add comment to explain why we check for chmod success.
5631c6f
@JamesWTruher @iSazonov
Update test/powershell/Modules/Microsoft.PowerShell.Management/UnixSt…
fcc5c17
…at.Tests.ps1

Co-authored-by: Ilya <[email protected]>
@JamesWTruher
Reduce allocations by providing some common mode strings as constants.
b2959a0
Use stackalloc rather than new for character mode array.
@JamesWTruher
Revert "Reduce allocations by providing some common mode strings as c…
4f1d4fb
…onstants."

This reverts commit 22769e9cd46bfc3620f96081e3b3783fa4e2d485.
@JamesWTruher
Reduce allocations by providing some common mode strings as constants.
cb92b5f
Use stackalloc rather than new for character mode array.
@JamesWTruher @daxian-dbw
Update src/System.Management.Automation/CoreCLR/CorePsPlatform.cs
ef7e0a8
Co-authored-by: Dongbo Wang <[email protected]>
@JamesWTruher
James Truher (JamesWTruher) force-pushed the UnixModeStringFix01 branch from 830080b to 00a4b6e Compare October 11, 2023 23:15
@JamesWTruher @daxian-dbw
Update src/System.Management.Automation/CoreCLR/CorePsPlatform.cs
70292b0
Co-authored-by: Dongbo Wang <[email protected]>
@JamesWTruher
James Truher (JamesWTruher) force-pushed the UnixModeStringFix01 branch from 00a4b6e to 70292b0 Compare October 11, 2023 23:22
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Oct 11, 2023
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@daxian-dbw Dongbo Wang (daxian-dbw) added Backport-7.4.x-Consider and removed WG-Engine core PowerShell engine, interpreter, and runtime labels Oct 11, 2023
@daxian-dbw
Dongbo Wang (daxian-dbw) enabled auto-merge (squash) October 11, 2023 23:29
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 81a7f6f into PowerShell:master Oct 11, 2023
@microsoft-github-policy-service

microsoft-github-policy-service Bot commented Oct 11, 2023 •
edited by unfurl-links Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

📣 Hey James Truher (@JamesWTruher), how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://forms.office.com/r/P926k48jRJ

Microsoft Forms
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Oct 18, 2023
UnixMode on files and directories does not display the SUID/SGID bit when execute is not set and the S is uppercase #20278
Closed
5 tasks done
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Backport-7.4.x-Approved and removed Backport-7.4.x-Consider labels Oct 19, 2023
Aditya Patwardhan (adityapatwardhan) pushed a commit that referenced this pull request Oct 19, 2023
@JamesWTruher @adityapatwardhan
Fix unixmode to handle setuid and sticky when file is not an ex…
5aba652
…ecutable (#20366)
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) mentioned this pull request Oct 19, 2023
[release/v7.4.0-preview.7]Fix unixmode to handle setuid/sticky when not executable #20537
Merged
Aditya Patwardhan (adityapatwardhan) added a commit that referenced this pull request Oct 19, 2023
@adityapatwardhan
Fix unixmode to handle setuid and sticky when file is not an ex…
5c1ca0f
…ecutable (#20366) (#20537)
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Backport-7.4.x-Done CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log and removed Backport-7.4.x-Approved labels Oct 19, 2023
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@JamesWTruher
Fix unixmode to handle setuid and sticky when file is not an ex…
c012847
…ecutable (PowerShell#20366)
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan
Fix unixmode to handle setuid and sticky when file is not an ex…
1634b3d
…ecutable (PowerShell#20366) (PowerShell#20537)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@SeeminglyScience Patrick Meinecke (SeeminglyScience) Awaiting requested review from SeeminglyScience

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Backport-7.4.x-Done CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@JamesWTruher @daxian-dbw @iSazonov @adityapatwardhan @StevenBucher98
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.