GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix alpine tar package name and do not crossgen alpine fxdependent package by adityapatwardhan · Pull Request #20459 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Oct 9, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

There was regression in previous release where the name of the alpine package as created as *-linux-linux-musl.tar.gz. This PR fixes it to *-linux-musl.tar.gz

There was a regression 2 releases ago where the fxdependent alpine package was getting crossgen'ed. This PR fixes it to be not crossgen'ed

PR Context

Fixes #20177

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Aditya Patwardhan (adityapatwardhan) added 4 commits October 9, 2023 09:48
@adityapatwardhan
Fix alpine packaging and crossgen for fxd pacakge
34ded6e
@adityapatwardhan
Use correct SDK
30faf17
@adityapatwardhan
Fix tar package name and alpine fxd download
ff0f259
@adityapatwardhan
Add noopt to package name
61e4cd0
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested review from Travis Plunk (TravisEz13), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners October 9, 2023 16:52
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the Backport-7.4.x-Consider label Oct 9, 2023
TravisEz13
Travis Plunk (TravisEz13) approved these changes Oct 9, 2023
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit a24e954 into PowerShell:master Oct 9, 2023
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the FixAlpineNamesCrossGen branch October 9, 2023 21:54
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Backport-7.4.x-Approved and removed Backport-7.4.x-Consider labels Oct 19, 2023
Aditya Patwardhan (adityapatwardhan) added a commit that referenced this pull request Oct 19, 2023
@adityapatwardhan
Fix alpine tar package name and do not crossgen alpine fxdependent pa…
f8b0ae3
…ckage (#20459)
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) mentioned this pull request Oct 19, 2023
[release/v7.4.0-preview.7]Fix alpine tar package name and do not crossgen alpine fxdependent package #20536
Merged
Aditya Patwardhan (adityapatwardhan) added a commit that referenced this pull request Oct 19, 2023
@adityapatwardhan
Fix alpine tar package name and do not crossgen alpine fxdependent pa…
e60125d
…ckage (#20459) (#20536)
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Backport-7.4.x-Done and removed Backport-7.4.x-Approved labels Oct 19, 2023
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 18, 2024
Chris Dent (chrisdent-de) pushed a commit to chrisdent-de/PowerShell that referenced this pull request Sep 12, 2024
@adityapatwardhan @chrisdent-de
Fix alpine tar package name and do not crossgen alpine fxdependent pa…
3fad584
…ckage (PowerShell#20459) (PowerShell#20536)
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan
Fix alpine tar package name and do not crossgen alpine fxdependent pa…
1bd77f2
…ckage (PowerShell#20459)
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan
Fix alpine tar package name and do not crossgen alpine fxdependent pa…
03bff19
…ckage (PowerShell#20459) (PowerShell#20536)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Backport-7.4.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Powershell v7.4.0-preview.5 Alpine nupkg doubled in size doubled compared to v7.4.0-preview.3

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@adityapatwardhan @TravisEz13 @daxian-dbw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.