GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Prevent localization of WPF key gesture strings by daxian-dbw · Pull Request #28020 · PowerShell/PowerShell

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Sep 16, 2026

Copy link
Copy Markdown
Member

PR Summary

Fix #27994

Preserve WPF key gesture tokens used by Out-GridView and Show-Command, and protect API identifiers embedded in invariant resource messages. Those key gesture tokens were translated in the localized resources and caused those 2 commands to fail.

The localized .resx files will be automatically updated by the Localization Pipeline.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge. If this PR is a work in progress, please open this as a Draft Pull Request and mark it as Ready to Review when it is ready to merge.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw
Prevent localization of WPF key gesture strings
7dd2624
Copilot AI lite review requested due to automatic review settings September 16, 2026 21:57
@daxian-dbw
Dongbo Wang (daxian-dbw) requested a review from a team as a code owner September 16, 2026 21:57
@azure-pipelines

azure-pipelines Bot commented Sep 16, 2026

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Copilot started reviewing on behalf of Dongbo Wang (daxian-dbw) September 16, 2026 21:58
View session
@daxian-dbw Dongbo Wang (daxian-dbw) added CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Backport-7.6.x-Consider labels Sep 16, 2026
Copilot AI reviewed Sep 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The reviewed resource changes preserve required tokens and identifiers with no unresolved blocking issues.

Pull request overview

Prevents localization of WPF key gesture tokens and embedded API identifiers.

Changes:

  • Protects zoom shortcut strings from translation.
  • Preserves Columns, Items, and View identifiers.
File summaries
File Description
src/Microsoft.Management.UI.Internal/resources/public.UICultureResources.resx Preserves WPF key gesture tokens.
src/Microsoft.Management.UI.Internal/resources/public.InvariantResources.resx Preserves API identifiers in messages.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
SeeminglyScience
Patrick Meinecke (SeeminglyScience) approved these changes Sep 17, 2026
View reviewed changes
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit a049fa3 into PowerShell:master Sep 17, 2026
37 of 38 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the loc-out-grid branch September 17, 2026 21:19
@daxian-dbw Dongbo Wang (daxian-dbw) added Backport-7.6.x-Approved and removed Backport-7.6.x-Consider labels Sep 24, 2026
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Sep 24, 2026
[release/v7.6.7] Prevent localization of WPF key gesture strings #28097
Merged
3 of 9 tasks
@daxian-dbw Dongbo Wang (daxian-dbw) added Backport-7.6.x-Migrated Backport-7.6.x-Done and removed Backport-7.6.x-Approved Backport-7.6.x-Migrated labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@SeeminglyScience Patrick Meinecke (SeeminglyScience) SeeminglyScience approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Backport-7.6.x-Done CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

OutGridView freezes indefinitely in 7.6.6

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@daxian-dbw @SeeminglyScience
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.