GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [release/v7.6.7] Prevent localization of WPF key gesture strings by daxian-dbw · Pull Request #28097 · PowerShell/PowerShell

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Sep 24, 2026

Copy link
Copy Markdown
Member

Backport of #28020 to release/v7.6.7

Triggered by Dongbo Wang (@daxian-dbw) on behalf of Dongbo Wang (@daxian-dbw)

Original CL Label: CL-General

/cc @PowerShell/powershell-maintainers

Impact

REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.

Tooling Impact

  • Required tooling change
  • Optional tooling change (include reasoning)

Customer Impact

  • Customer reported
  • Found internally

Fixes #27994 where WPF key gesture tokens used by Out-GridView and Show-Command were being translated in localized resources, causing those commands to fail in non-English locales. This PR preserves the key gesture tokens and protects API identifiers embedded in invariant resource messages so they are not localized.

Regression

REQUIRED: Check exactly one box.

  • Yes
  • No

Regression introduced when the WPF key gesture strings were exposed for localization; they were translated in non-English locales, breaking Out-GridView and Show-Command. Reported in #27994.

Testing

Verified that Out-GridView and Show-Command key gestures function correctly under non-English locales once the key gesture tokens are preserved from localization. Backport verified by confirming the cherry-pick applied cleanly with no conflicts on release/v7.6.7.

Risk

REQUIRED: Check exactly one box.

  • High
  • Medium
  • Low

Low risk: marks specific resource strings as non-localizable/protected; the localized .resx files are auto-updated by the Localization Pipeline. Narrow, well-scoped fix for a reported customer bug.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@daxian-dbw
Prevent localization of WPF key gesture strings (PowerShell#28020)
cfba15f
Copilot AI lite review requested due to automatic review settings September 24, 2026 21:29
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Sep 24, 2026
@azure-pipelines

azure-pipelines Bot commented Sep 24, 2026

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Copilot started reviewing on behalf of Dongbo Wang (daxian-dbw) September 24, 2026 21:29
View session
Copilot AI reviewed Sep 24, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved issues were identified that would block approval.

Review effort: Lite
Findings: None

What changed in this PR

Adds localization metadata to preserve WPF key gesture tokens and invariant API identifiers, fixing localized Out-GridView and Show-Command failures.

Changes:

  • Protects eight zoom shortcut strings from translation.
  • Protects Columns, Items, and View identifiers in invariant messages.
File Description
src/​Microsoft.Management.UI.Internal/​resources/​public.UICultureResources.resx Updated as part of this pull request.
src/​Microsoft.Management.UI.Internal/​resources/​public.InvariantResources.resx Updated as part of this pull request.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Sep 24, 2026
View reviewed changes
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 68964a3 into PowerShell:release/v7.6.7 Sep 24, 2026
35 of 36 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the backport/release/v7.6.7/28020-a049fa38e branch September 24, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@daxian-dbw @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.