GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||
GeezerVison is showing github.com — [release/v7.6.7] Prevent localization of WPF key gesture strings by daxian-dbw · Pull Request #28097 · PowerShell/PowerShell Conversation
Member
Backport of #28020 to release/v7.6.7 Triggered by Dongbo Wang (@daxian-dbw) on behalf of Dongbo Wang (@daxian-dbw) Original CL Label: CL-General /cc @PowerShell/powershell-maintainers ImpactREQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected. Tooling Impact
Customer Impact
Fixes #27994 where WPF key gesture tokens used by Out-GridView and Show-Command were being translated in localized resources, causing those commands to fail in non-English locales. This PR preserves the key gesture tokens and protects API identifiers embedded in invariant resource messages so they are not localized. RegressionREQUIRED: Check exactly one box.
Regression introduced when the WPF key gesture strings were exposed for localization; they were translated in non-English locales, breaking Out-GridView and Show-Command. Reported in #27994. TestingVerified that Out-GridView and Show-Command key gestures function correctly under non-English locales once the key gesture tokens are preserved from localization. Backport verified by confirming the cherry-pick applied cleanly with no conflicts on release/v7.6.7. RiskREQUIRED: Check exactly one box.
Low risk: marks specific resource strings as non-localizable/protected; the localized .resx files are auto-updated by the Localization Pipeline. Narrow, well-scoped fix for a reported customer bug.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Copilot review overview🟢 Approval recommendedNo unresolved issues were identified that would block approval. Review effort: Lite What changed in this PRAdds localization metadata to preserve WPF key gesture tokens and invariant API identifiers, fixing localized Changes:
💡 Add a
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Aditya Patwardhan (adityapatwardhan)
approved these changes
Dongbo Wang (daxian-dbw)
merged commit
68964a3
into
PowerShell:release/v7.6.7
35 of 36 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Dongbo Wang (daxian-dbw)
deleted the
backport/release/v7.6.7/28020-a049fa38e
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review
Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
CL-General
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |