GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Validate updatable-help CAB extraction and limit module names to 128 characters by jshigetomi · Pull Request #28203 · PowerShell/PowerShell

Conversation

Justin Chung (jshigetomi) commented Oct 14, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

PR Summary

This pull request introduces several important improvements to the handling of CAB extraction and module name validation in PowerShell's updatable help system. The main changes focus on strengthening error handling during file operations, improving path validation to prevent security issues, and enforcing limits on module name lengths to avoid filesystem problems.

PR Context

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge. If this PR is a work in progress, please open this as a Draft Pull Request and mark it as Ready to Review when it is ready to merge.
Breaking changes
- None
- OR
- Experimental feature(s) needed
  - Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- Documentation needed
  - Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Improve error handling for cab extraction and limit module name to 12…

…8 characters (#205)

azure-pipelines Bot commented Oct 14, 2026

Copy link

Copy Markdown

Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Justin Chung (jshigetomi) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label

Oct 14, 2026

Justin Chung (jshigetomi) changed the title ~~Improve error handling for cab extraction and limit module name to 128 characters~~ Validate updatable-help CAB extraction and limit module names to 128 characters

Oct 14, 2026


          Merge branch 'master' into 136251

632f7eb

Travis Plunk (TravisEz13) marked this pull request as ready for review

October 14, 2026 21:04

Copilot AI balanced review requested due to automatic review settings

October 14, 2026 21:04

Travis Plunk (TravisEz13) requested review from a team, Aditya Patwardhan (adityapatwardhan) and Dongbo Wang (daxian-dbw) as code owners

October 14, 2026 21:04

Travis Plunk (TravisEz13) approved these changes

Oct 14, 2026

View reviewed changes

Copilot started reviewing on behalf of Travis Plunk (TravisEz13)

October 14, 2026 21:05

View session

Copilot AI reviewed

Oct 14, 2026

View reviewed changes

Copilot AI left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Native extraction failure contracts lack regression coverage sufficient to establish safe behavior.

2 open findings

What changed in this PR

This PR hardens PowerShell’s updatable-help extraction and limits module names used in generated help paths.

Changes:

Adds CAB path checks and improves native callback failure handling.
Enforces a 128-character module-name limit with a dedicated error message.

File	Description
src/System.Management.Automation/resources/HelpDisplayStrings.resx	Adds the oversized module-name error message.
src/System.Management.Automation/help/UpdatableHelpModuleInfo.cs	Defines the module-name length limit.
src/System.Management.Automation/help/UpdatableHelpCommandBase.cs	Enforces the limit during module selection.
src/System.Management.Automation/help/CabinetNativeApi.cs	Strengthens extraction validation and failure handling.

🧠 Review effort: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

src/System.Management.Automation/help/CabinetNativeApi.cs

Comment on lines +486 to +488

		if (closeResult != 0)
		{
		return IntPtr.Zero;

Comment thread

src/System.Management.Automation/help/UpdatableHelpCommandBase.cs

		return;
		}

		if (module.Name.Length > UpdatableHelpModuleInfo.MaxModuleNameLength)

Justin Chung (jshigetomi) enabled auto-merge (squash)

October 14, 2026 21:43

Ilya (iSazonov) mentioned this pull request

Oct 15, 2026

Improve error handling for cab extraction and limit module name to 128 characters #28212

Closed

12 tasks

Aditya Patwardhan (adityapatwardhan) approved these changes

Oct 16, 2026

View reviewed changes

Justin Chung (jshigetomi) merged commit 873d2fa into master

Oct 16, 2026

37 checks passed

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

Copilot code review Copilot

Copilot review effort

Applies to this pull request for everyone.Learn more about Copilot code review.

Copilot left review comments

Travis Plunk (TravisEz13)

TravisEz13 approved these changes

Aditya Patwardhan (adityapatwardhan)

adityapatwardhan approved these changes

Dongbo Wang (daxian-dbw)

Awaiting requested review from daxian-dbw

daxian-dbw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CL-General

Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Justin Chung (jshigetomi) commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

azure-pipelines Bot commented Oct 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Justin Chung (jshigetomi) commented Oct 14, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.