GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Bind Hyper-V socket server V2 to the selected partition VM ID by jshigetomi · Pull Request #28204 · PowerShell/PowerShell

Conversation

@jshigetomi

@jshigetomi Justin Chung (jshigetomi) commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator

PR Summary

This pull request refactors how the Hyper-V session server determines which VM partition ID to bind to, centralizing the logic into a helper method for consistency and maintainability. It also adds a unit test to ensure the correct partition ID is used based on the connection mode.

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge. If this PR is a work in progress, please open this as a Draft Pull Request and mark it as Ready to Review when it is ready to merge.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Justin Chung
Remove Wildcard GUID in HyperVSocketServer V2 Constructor (#165)
a36af32
@jshigetomi Justin Chung (jshigetomi) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 14, 2026
@azure-pipelines

azure-pipelines Bot commented Oct 14, 2026

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jshigetomi Justin Chung (jshigetomi) changed the title Remove Wildcard GUID in HyperVSocketServer V2 Constructor Bind Hyper-V socket server V2 to the selected partition VM ID Oct 14, 2026
@jshigetomi
Merge branch 'master' into 116136
3cb8654
@jshigetomi
Justin Chung (jshigetomi) marked this pull request as ready for review October 14, 2026 21:43
@jshigetomi
Justin Chung (jshigetomi) requested review from a team, Travis Plunk (TravisEz13) and Dongbo Wang (daxian-dbw) as code owners October 14, 2026 21:43
Copilot AI balanced review requested due to automatic review settings October 14, 2026 21:43
Copilot started reviewing on behalf of Justin Chung (jshigetomi) October 14, 2026 21:44
View session
Copilot AI reviewed Oct 14, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused change preserves V1 behavior, aligns V2 binding, and tests both partition selections without identified blocking issues.

0 open findings

What changed in this PR

Aligns Hyper-V socket server V2 with V1 by binding to the partition VM ID selected by the connection mode.

Changes:

  • Shares partition selection logic between both server constructors.
  • Adds unit coverage for parent and loopback VM IDs.
File Description
test/​xUnit/​csharp/​test_RemoteHyperV.cs Tests partition selection for both connection modes.
src/​System.Management.Automation/​engine/​remoting/​common/​RemoteSessionHyperVSocket.cs Extracts the selection helper and replaces V2’s wildcard binding.

🧠 Review effort: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov Ilya (iSazonov) mentioned this pull request Oct 15, 2026
Remove Wildcard GUID in HyperVSocketServer V2 Constructor (#165) #28213
Closed
12 tasks
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Oct 19, 2026
View reviewed changes
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Oct 19, 2026
View reviewed changes
@jshigetomi
Justin Chung (jshigetomi) merged commit 43d85c7 into master Oct 19, 2026
36 of 37 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13 TravisEz13 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@jshigetomi @daxian-dbw @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.