GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove Wildcard GUID in HyperVSocketServer V2 Constructor (#165) by adityapatwardhan · Pull Request #28213 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Oct 14, 2026

Copy link
Copy Markdown
Member

PR Summary

This pull request refactors the way the Hyper-V socket server determines which VM partition ID to use when listening for connections, improving maintainability and consistency. It introduces a helper method to centralize this logic and updates both the server constructors and tests to use it.

Refactoring and Helper Method Introduction:

  • Added a new internal static method GetListenerVmId(bool loopbackMode) to RemoteSessionHyperVSocketServer to encapsulate the logic for choosing the correct VM partition ID (loopback or parent) for the listening socket.

Constructor Consistency and Usage:

  • Updated both constructors of RemoteSessionHyperVSocketServer to use the new GetListenerVmId helper, ensuring consistent partition selection logic across server instantiations. [1] [2]

Testing Improvements:

  • Added a new test ServerListenerUsesExpectedPartitionVmId to verify that GetListenerVmId returns the correct VM ID for both loopback and parent partition modes.

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge. If this PR is a work in progress, please open this as a Draft Pull Request and mark it as Ready to Review when it is ready to merge.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Justin Chung @adityapatwardhan
Remove Wildcard GUID in HyperVSocketServer V2 Constructor (#165)
0867bf4
Copilot AI balanced review requested due to automatic review settings October 14, 2026 22:59
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested review from a team, Travis Plunk (TravisEz13) and Dongbo Wang (daxian-dbw) as code owners October 14, 2026 22:59
@azure-pipelines

azure-pipelines Bot commented Oct 14, 2026

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Copilot started reviewing on behalf of Aditya Patwardhan (adityapatwardhan) October 14, 2026 23:00
View session
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Oct 14, 2026
Copilot AI reviewed Oct 14, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The V2 binding change needs Windows/Hyper-V connectivity validation beyond the helper’s GUID-selection tests.

0 open findings

What changed in this PR

This PR replaces the V2 Hyper-V session server’s wildcard listener binding with the partition-selection logic already used by V1.

Changes:

  • Centralizes partition selection in GetListenerVmId.
  • Uses the helper in both server constructors.
  • Adds tests for parent and loopback GUID selection.
File Description
test/​xUnit/​csharp/​test_RemoteHyperV.cs Tests both partition-selection modes.
src/​System.Management.Automation/​engine/​remoting/​common/​RemoteSessionHyperVSocket.cs Shares partition-selection logic and removes V2 wildcard binding.

🧠 Review effort: Balanced


💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@iSazonov

Ilya (iSazonov) commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Dup #28204

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jshigetomi Justin Chung (jshigetomi) closed this Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw daxian-dbw is a code owner
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13 TravisEz13 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@adityapatwardhan @iSazonov @jshigetomi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.