GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [release/v7.6.10] Add warning for SHA-1 File Catalog by daxian-dbw · Pull Request #28311 · PowerShell/PowerShell

Conversation

Dongbo Wang (daxian-dbw) commented Nov 3, 2026

Copy link

Copy Markdown

Member

Backport of #27805 to release/v7.6.10

Triggered by Dongbo Wang (@daxian-dbw) on behalf of Anam Navied (@anamnavi)

Original CL Label: CL-General

/cc @PowerShell/powershell-maintainers

Impact

REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.

Tooling Impact

Required tooling change
Optional tooling change (include reasoning)

Customer Impact

Customer reported
Found internally

Warns when generating or validating legacy SHA-1 file catalogs and recommends regenerating with -CatalogVersion 2. Catalog generation and validation remain supported for compatibility; hashing and validation behavior are unchanged.

Regression

REQUIRED: Check exactly one box.

This is not a regression.

Testing

No tests were added in the original diff. The backport cherry-picked without conflicts and the working tree is clean. Local tests were not run; backport CI must pass before merge.

Risk

REQUIRED: Check exactly one box.

High
Medium
Low

Security-related catalog handling. The change is limited to advisory warnings when legacy catalog versions are used; hashing and validation logic are unchanged.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Add warning for SHA-1 file catalog (PowerShell#27805)

ced3630

Dongbo Wang (daxian-dbw) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label

Nov 3, 2026

Copilot AI balanced review requested due to automatic review settings

November 3, 2026 22:12

azure-pipelines Bot commented Nov 3, 2026

Copy link

Copy Markdown

Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Copilot started reviewing on behalf of Dongbo Wang (daxian-dbw)

November 3, 2026 22:12

View session

Copilot AI reviewed

Nov 3, 2026

View reviewed changes

Copilot AI left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The catalog warning incorrectly lists SHA0 as a possible algorithm and omits the catalog version instead of accurately identifying version 1 catalogs as using weak SHA-1.

1 open issue

Identify version 1 catalogs as using weak SHA-1 · New

What changed in this PR

Backports #27805 to release/v7.6.10, adding warnings when generating or validating legacy SHA-1 file catalogs while retaining compatibility.

Changes:

Adds a shared warning helper to catalog generation and validation.
Adds warning text recommending regeneration with -CatalogVersion 2.
Leaves hashing and validation logic unchanged.

File	Description
`src/System.Management.Automation/security/CatalogHelper.cs`	Emits warnings when generating or validating legacy catalogs.
`src/System.Management.Automation/resources/CatalogStrings.resx`	Adds the warning message and migration guidance.

_{Review effort: Balanced}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

src/System.Management.Automation/resources/CatalogStrings.resx

		<value>Catalog version is not valid. We only support catalog version {0} and version {1}.</value>
		</data>
		<data name="WeakCatalogHashAlgorithm" xml:space="preserve">
		<value>'{0}' is a version catalog that uses SHA0 or SHA1. Consider regenerating this catalog with '-CatalogVersion 2'.</value>

Dongbo Wang (daxian-dbw) Nov 3, 2026

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anam Navied (@anamnavi) I think this comment makes sense. The GetCatalogHashAlgorithm throws a terminating error when the passed-in catalogVersion is neither 1 nor 2.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Dongbo Wang (daxian-dbw) Nov 3, 2026

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I submitted #28322 to fix it in GitHub. Will backport it in the next 7.6 release.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Justin Chung (jshigetomi) approved these changes

Nov 4, 2026

View reviewed changes

Justin Chung (jshigetomi) left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed as a faithful backport; no blocking issues found.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Aditya Patwardhan (adityapatwardhan) approved these changes

Nov 4, 2026

View reviewed changes

Dongbo Wang (daxian-dbw) merged commit 3e75fdf into PowerShell:release/v7.6.10

Nov 4, 2026

36 checks passed

Uh oh!

There was an error while loading. Please reload this page.

Dongbo Wang (daxian-dbw) deleted the backport/release/v7.6.10/27805-097b42e9b branch

November 4, 2026 17:21

Dongbo Wang (daxian-dbw) mentioned this pull request

Nov 4, 2026

[release/v7.6.10] Fix the resource string WeakCatalogHashAlgorithm #28334

Merged

3 of 9 tasks

Reviewers

Copilot code review Copilot

Copilot review effort

Applies to this pull request for everyone.Learn more about Copilot code review.

Copilot left review comments

Aditya Patwardhan (adityapatwardhan)

adityapatwardhan approved these changes

Justin Chung (jshigetomi)

jshigetomi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CL-General

Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.