GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix the resource string `WeakCatalogHashAlgorithm` by daxian-dbw · Pull Request #28322 · PowerShell/PowerShell

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Nov 3, 2026

Copy link
Copy Markdown
Member

PR Summary

This is a follow-up change of the PR #27805.
The resource string for WeakCatalogHashAlgorithm needs to be updated to be accurate -- the GetCatalogHashAlgorithm throws a terminating error when the passed-in catalogVersion is neither 1 nor 2, so mentioning SHA0 is incorrect.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw
Fix the resource string 'WeakCatalogHashAlgorithm'
f4e8b75
@daxian-dbw
Dongbo Wang (daxian-dbw) requested a review from a team as a code owner November 3, 2026 23:54
Copilot AI balanced review requested due to automatic review settings November 3, 2026 23:54
@azure-pipelines

azure-pipelines Bot commented Nov 3, 2026

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Nov 3, 2026
Copilot started reviewing on behalf of Dongbo Wang (daxian-dbw) November 3, 2026 23:54
View session
@microsoft-github-policy-service microsoft-github-policy-service Bot added Backport-7.4.x-Consider Backport-7.5.x-Consider Backport-7.6.x-Consider labels Nov 3, 2026
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Nov 3, 2026
[release/v7.6.10] Add warning for SHA-1 File Catalog #28311
Merged
3 of 9 tasks
@daxian-dbw Dongbo Wang (daxian-dbw) added Backport-7.7.x-Consider and removed Backport-7.4.x-Consider Backport-7.5.x-Consider labels Nov 3, 2026
Copilot AI reviewed Nov 3, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the catalog-warning wording and localization metadata changes.

No open issues 🎉

What changed in this PR

This follow-up to #27805 corrects PowerShell’s weak file-catalog hash warning to accurately describe version 1 catalogs.

Changes:

  • Replaces the incorrect SHA0/SHA1 wording with “version 1” and “weak SHA-1 hash algorithm.”
  • Adds localization metadata to preserve SHA-1 and -CatalogVersion 2.
File Description
src/​System.Management.Automation/​resources/​CatalogStrings.resx Corrects the warning text and adds localization constraints.

Review effort: Balanced

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Nov 4, 2026
Specify version 1 catalog in warning for weak catalog version #28321
Closed
12 tasks
jshigetomi
Justin Chung (jshigetomi) approved these changes Nov 4, 2026
View reviewed changes

@jshigetomi Justin Chung (jshigetomi) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed; no blocking issues found.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Nov 4, 2026
View reviewed changes
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 3209d2a into PowerShell:master Nov 4, 2026
42 of 43 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the sha1-warning-string branch November 4, 2026 17:40
@daxian-dbw Dongbo Wang (daxian-dbw) added Backport-7.6.x-Approved and removed Backport-7.6.x-Consider labels Nov 4, 2026
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Nov 4, 2026
[release/v7.6.10] Fix the resource string WeakCatalogHashAlgorithm #28334
Merged
3 of 9 tasks
@daxian-dbw Dongbo Wang (daxian-dbw) added Backport-7.6.x-Migrated Backport-7.6.x-Done and removed Backport-7.6.x-Approved Backport-7.6.x-Migrated labels Nov 4, 2026
@jshigetomi Justin Chung (jshigetomi) mentioned this pull request Nov 5, 2026
[release/v7.7.0] Fix the resource string WeakCatalogHashAlgorithm #28350
Closed
Copilot AI mentioned this pull request Nov 5, 2026
[release/v7.7.0] Localized file check-in: Build ID 2785816 #28347
Closed
@daxian-dbw Dongbo Wang (daxian-dbw) added Backport-7.7.x-Approved and removed Backport-7.7.x-Consider labels Nov 5, 2026
@jshigetomi Justin Chung (jshigetomi) mentioned this pull request Nov 6, 2026
[release/v7.7.0] Fix the resource string WeakCatalogHashAlgorithm #28368
Merged
3 of 9 tasks
@jshigetomi Justin Chung (jshigetomi) added Backport-7.7.x-Migrated and removed Backport-7.7.x-Approved labels Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@jshigetomi Justin Chung (jshigetomi) jshigetomi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Backport-7.6.x-Done Backport-7.7.x-Migrated CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@daxian-dbw @adityapatwardhan @jshigetomi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.