GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — [release/v7.6.10] Fix module-only vPack build feed credentials by daxian-dbw · Pull Request #28362 · PowerShell/PowerShell Conversation
Member
Backport of #28356 to release/v7.6.10 Triggered by Dongbo Wang (@daxian-dbw) on behalf of Aditya Patwardhan (@adityapatwardhan) Original CL Label: CL-BuildPackaging /cc @PowerShell/powershell-maintainers ImpactREQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected. Tooling Impact
Fixes authenticated bundled-module restores in vPack and MSIX builds when UseEarlyAccessModules is enabled without IsEarlyAccess. Both build steps explicitly map the secret VSS_NUGET_EXTERNAL_FEED_ENDPOINTS variable into their environment, since Azure Pipelines does not automatically export secret variables. Customer Impact
RegressionREQUIRED: Check exactly one box.
Fixes credential mapping omitted when the internal module-feed feature from #28326 was backported to release/v7.6.10 via #28355. TestingIncludes the original PR's regression coverage requiring direct secret credential mappings in both build-step environment blocks. Independent review confirmed the intended mappings, preservation of release runtime-key behavior, documentation and regression additions, no remaining YAML conflict markers, and a passing git diff --check HEAD. Local YAML parsing was skipped at the user's request; local Pester tests were not run. Cherry-pick completed as 3a91ff5 and the worktree is clean. Backport CI, including Azure Pipelines authentication validation, must pass before merge. RiskREQUIRED: Check exactly one box.
Changes shared build pipeline authentication, but the fix is limited to explicit environment mappings for the existing secret variable. Release-specific runtime-key behavior is unchanged, and regression tests cover both mappings. CI validation is required before merge. Merge ConflictsResolved conflicts in .pipelines/MSIXBundle-vPack-Official.yml and .pipelines/templates/stages/PowerShell-vPack-Stages.yml. In both files, added a direct VSS_NUGET_EXTERNAL_FEED_ENDPOINTS environment mapping to the Build Windows Universal step. Preserved the release vPack template's existing unconditional __DOTNET_RUNTIME_FEED_KEY mapping. The release MSIX pipeline has no IsEarlyAccess parameter or runtime-feed-key mapping, so did not import master's unrelated conditional runtime-key block. Documentation and regression tests applied without conflicts.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Dongbo Wang (daxian-dbw)
requested review from
a team and
Justin Chung (jshigetomi)
as code owners
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔵 Needs a closer lookModule-only vPack and MSIX restores require Azure Pipelines runtime validation because static review cannot confirm secret propagation, credential-provider authentication, or service-connection feed access. No open issues 🎉 What changed in this PRBackports #28356 to Changes:
Review effort: Balanced
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Aditya Patwardhan (adityapatwardhan)
approved these changes
Dongbo Wang (daxian-dbw)
merged commit
ac0b83b
into
PowerShell:release/v7.6.10
35 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Dongbo Wang (daxian-dbw)
deleted the
backport/release/v7.6.10/28356-1aac7f5e3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review
Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
CL-BuildPackaging
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |