GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — Fix module-only vPack build feed credentials by adityapatwardhan · Pull Request #28356 · PowerShell/PowerShell Conversation
Member
PR SummaryExport Use the same direct environment mapping as the other build templates. Keep the credential-producing variable secret and preserve the existing .NET runtime-feed-key conditions. Add regression coverage for both build-step environment mappings and document the explicit secret-mapping requirement. PR ContextFollow-up to #28326. Azure Pipelines does not automatically export secret variables to subsequent processes. Gating these mappings only on This fixes master first. After merge, backport the fix to Validation:
PR Checklist
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsMap secret feed credentials directly into the vPack and MSIX build environments, matching other build templates. Co-authored-by: Copilot <[email protected]>
Aditya Patwardhan (adityapatwardhan)
requested review from
a team and
Justin Chung (jshigetomi)
as code owners
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
3 of 9 tasks
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟢 Approval recommendedThere are no active review issues with the feed credential-mapping changes. No open issues 🎉 What changed in this PRFixes feed authentication for vPack and MSIX builds that enable early-access modules without enabling early-access .NET, completing the internal module-feed support added in #28326. Changes:
Review effort: Balanced
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Dongbo Wang (daxian-dbw)
approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Dongbo Wang (daxian-dbw)
deleted the
fix/vpack-module-feed-credentials
branch
3 of 9 tasks
3 of 9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review
Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
Backport-7.6.x-Done
Backport-7.7.x-Migrated
CL-BuildPackaging
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |