GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix module-only vPack build feed credentials by adityapatwardhan · Pull Request #28356 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Nov 5, 2026

Copy link
Copy Markdown
Member

PR Summary

Export VSS_NUGET_EXTERNAL_FEED_ENDPOINTS explicitly in the vPack and MSIX PowerShell build steps, including when UseEarlyAccessModules is enabled without IsEarlyAccess.

Use the same direct environment mapping as the other build templates. Keep the credential-producing variable secret and preserve the existing .NET runtime-feed-key conditions.

Add regression coverage for both build-step environment mappings and document the explicit secret-mapping requirement.

PR Context

Follow-up to #28326. Azure Pipelines does not automatically export secret variables to subsequent processes. Gating these mappings only on IsEarlyAccess leaves module-only builds without credentials for noninteractive module restores.

This fixes master first. After merge, backport the fix to release/v7.6.10, where #28355 carries the original module-feed feature.

Validation:

  • Parsed both pipeline YAML files and verified direct credential mapping for all four early-access flag combinations.
  • Confirmed existing runtime-key behavior and secret publication are unchanged.
  • Executed the new regression-test regexes against the fixed files and original master: both fixes pass and both original files fail.
  • PowerShell syntax parsing and git diff --check passed.
  • The full Pester file could not run: Pester is unavailable locally and PowerShell Gallery hosts could not be resolved. Pipeline authentication requires Azure Pipelines validation.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@adityapatwardhan
Fix module-only vPack build feed credentials
7cfce83
Map secret feed credentials directly into the vPack and MSIX build environments, matching other build templates.

Co-authored-by: Copilot <[email protected]>
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested review from a team and Justin Chung (jshigetomi) as code owners November 5, 2026 18:36
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Issue-Bug Issue has been identified as a bug in the product WG-Maintainers-Build specific to affecting the build CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log labels Nov 5, 2026
Copilot AI balanced review requested due to automatic review settings November 5, 2026 18:36
@azure-pipelines

azure-pipelines Bot commented Nov 5, 2026

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@microsoft-github-policy-service microsoft-github-policy-service Bot added Backport-7.6.x-Consider Backport-7.7.x-Consider labels Nov 5, 2026
Copilot started reviewing on behalf of Aditya Patwardhan (adityapatwardhan) November 5, 2026 18:37
View session
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) mentioned this pull request Nov 5, 2026
[release/v7.6.10] Add ability to consume PowerShell modules from internal feed #28355
Merged
3 of 9 tasks
@daxian-dbw Dongbo Wang (daxian-dbw) added Backport-7.6.x-Approved Backport-7.7.x-Approved and removed Backport-7.6.x-Consider Backport-7.7.x-Consider labels Nov 5, 2026
Copilot AI reviewed Nov 5, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues with the feed credential-mapping changes.

No open issues 🎉

What changed in this PR

Fixes feed authentication for vPack and MSIX builds that enable early-access modules without enabling early-access .NET, completing the internal module-feed support added in #28326.

Changes:

  • Maps secret feed credentials directly into both build-step environments while preserving existing runtime-feed-key conditions.
  • Adds regression checks for both environment mappings.
  • Documents Azure Pipelines’ explicit secret-mapping requirement.
File Description
test/​infrastructure/​NugetConfig.Tests.ps1 Adds regression checks for direct credential mappings in both pipelines.
docs/​building/​internals.md Explains explicit secret mapping, including module-only builds.
.pipelines/​templates/​stages/​PowerShell-vPack-Stages.yml Removes the early-access condition from the vPack credential mapping.
.pipelines/​MSIXBundle-vPack-Official.yml Makes the MSIX credential mapping unconditional while retaining the runtime-key condition.

Review effort: Balanced

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@daxian-dbw Dongbo Wang (daxian-dbw) removed Issue-Bug Issue has been identified as a bug in the product WG-Maintainers-Build specific to affecting the build labels Nov 5, 2026
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Nov 5, 2026
View reviewed changes
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 1aac7f5 into master Nov 5, 2026
47 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the fix/vpack-module-feed-credentials branch November 5, 2026 18:48
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Nov 5, 2026
[release/v7.6.10] Fix module-only vPack build feed credentials #28362
Merged
3 of 9 tasks
@daxian-dbw Dongbo Wang (daxian-dbw) added Backport-7.6.x-Migrated Backport-7.6.x-Done and removed Backport-7.6.x-Approved Backport-7.6.x-Migrated labels Nov 5, 2026
@jshigetomi Justin Chung (jshigetomi) mentioned this pull request Nov 6, 2026
[release/v7.7.0] Fix module-only vPack build feed credentials #28369
Merged
3 of 9 tasks
@jshigetomi Justin Chung (jshigetomi) added Backport-7.7.x-Migrated and removed Backport-7.7.x-Approved labels Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@jshigetomi Justin Chung (jshigetomi) Awaiting requested review from jshigetomi jshigetomi is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Backport-7.6.x-Done Backport-7.7.x-Migrated CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@adityapatwardhan @daxian-dbw @jshigetomi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.