GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — [release/v7.7.0] Fix module-only vPack build feed credentials by jshigetomi · Pull Request #28369 · PowerShell/PowerShell Conversation
Collaborator
Backport of #28356 to release/v7.7.0 Triggered by Justin Chung (@jshigetomi) on behalf of Aditya Patwardhan (@adityapatwardhan) Original CL Label: CL-BuildPackaging /cc @PowerShell/powershell-maintainers ImpactTooling Impact
Fixes authenticated bundled-module restores in vPack and MSIX builds when Customer Impact
Regression
Fixes credential mapping omitted when the internal module-feed feature from #28326 was backported to release/v7.7.0 via merged prerequisite #28366. TestingIncludes the original PR's regression coverage requiring direct secret credential mappings in both build-step environment blocks. The clean cherry-pick applied without conflicts. The original PR validated both pipeline YAML files across all four early-access flag combinations, preserved existing runtime-feed-key behavior and secret publication, passed PowerShell syntax parsing and Risk
Changes shared build pipeline authentication, but the fix is limited to explicit environment mappings for the existing secret variable. Runtime-feed-key behavior is unchanged, and regression tests cover both mappings. CI validation is required before merge.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔵 Needs a closer lookAzure Pipelines validation is needed to confirm authenticated restores, service-connection access, and secret propagation through OneBranch for vPack and MSIX builds, which static checks cannot verify. No open issues 🎉 What changed in this PRBackports #28356 to Changes:
Review effort: Balanced
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Aditya Patwardhan (adityapatwardhan)
approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Dongbo Wang (daxian-dbw)
deleted the
backport/release/v7.7.0/28356-1aac7f5e3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review
Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
CL-BuildPackaging
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||||||||
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |