GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [release/v7.7.0] Fix module-only vPack build feed credentials by jshigetomi · Pull Request #28369 · PowerShell/PowerShell

Conversation

@jshigetomi

@jshigetomi Justin Chung (jshigetomi) commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

Backport of #28356 to release/v7.7.0

Triggered by Justin Chung (@jshigetomi) on behalf of Aditya Patwardhan (@adityapatwardhan)

Original CL Label: CL-BuildPackaging

/cc @PowerShell/powershell-maintainers

Impact

Tooling Impact

  • Required tooling change
  • Optional tooling change (include reasoning)

Fixes authenticated bundled-module restores in vPack and MSIX builds when UseEarlyAccessModules is enabled without IsEarlyAccess. Both build steps explicitly map the secret VSS_NUGET_EXTERNAL_FEED_ENDPOINTS variable into their environment, since Azure Pipelines does not automatically export secret variables.

Customer Impact

  • Customer reported
  • Found internally

Regression

  • Yes
  • No

Fixes credential mapping omitted when the internal module-feed feature from #28326 was backported to release/v7.7.0 via merged prerequisite #28366.

Testing

Includes the original PR's regression coverage requiring direct secret credential mappings in both build-step environment blocks. The clean cherry-pick applied without conflicts. The original PR validated both pipeline YAML files across all four early-access flag combinations, preserved existing runtime-feed-key behavior and secret publication, passed PowerShell syntax parsing and git diff --check, and verified the new regression-test regexes against fixed and original files. Local Pester could not run because Pester and PowerShell Gallery access were unavailable. Backport CI, including Azure Pipelines authentication validation, must pass before merge.

Risk

  • High
  • Medium
  • Low

Changes shared build pipeline authentication, but the fix is limited to explicit environment mappings for the existing secret variable. Runtime-feed-key behavior is unchanged, and regression tests cover both mappings. CI validation is required before merge.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@adityapatwardhan Justin Chung
Fix module-only vPack build feed credentials (#28356)
c03d379
@jshigetomi
Justin Chung (jshigetomi) requested a review from a team as a code owner November 6, 2026 03:03
@jshigetomi Justin Chung (jshigetomi) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Nov 6, 2026
Copilot AI balanced review requested due to automatic review settings November 6, 2026 03:03
@jshigetomi Justin Chung (jshigetomi) changed the title Fix module-only vPack build feed credentials (#28356) [release/v7.7.0] Fix module-only vPack build feed credentials Nov 6, 2026
@azure-pipelines

azure-pipelines Bot commented Nov 6, 2026

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Copilot started reviewing on behalf of Justin Chung (jshigetomi) November 6, 2026 03:03
View session
Copilot AI reviewed Nov 6, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Azure Pipelines validation is needed to confirm authenticated restores, service-connection access, and secret propagation through OneBranch for vPack and MSIX builds, which static checks cannot verify.

No open issues 🎉

What changed in this PR

Backports #28356 to release/v7.7.0, fixing authenticated bundled-module restores in vPack and MSIX builds when UseEarlyAccessModules is enabled without IsEarlyAccess.

Changes:

  • Explicitly maps secret feed credentials into both build-step environments while preserving runtime-feed-key behavior.
  • Adds regression tests requiring direct credential mappings in both pipelines.
  • Documents Azure Pipelines’ explicit secret-mapping requirement.
File Description
test/​infrastructure/​NugetConfig.Tests.ps1 Adds regression coverage for both build-step credential mappings.
docs/​building/​internals.md Documents explicit secret mapping, including module-only builds.
.pipelines/​templates/​stages/​PowerShell-vPack-Stages.yml Removes the early-access condition from the vPack credential mapping.
.pipelines/​MSIXBundle-vPack-Official.yml Maps MSIX feed credentials independently of the runtime-feed-key condition.

Review effort: Balanced

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Nov 6, 2026
View reviewed changes
@jshigetomi
Justin Chung (jshigetomi) merged commit ac94577 into release/v7.7.0 Nov 6, 2026
37 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the backport/release/v7.7.0/28356-1aac7f5e3 branch November 6, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@jshigetomi @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.