GeezerVison

redundant extra-line before else #Resolved

why not simple { get; private set; } #WontFix

I think it's fine to follow the existing code pattern here. We can convert the style using a tool later. #ByDesign

to match the current code style

In reply to: 100213197 [](ancestors = 100213197)

I wonder how it's going to interact with existing in Windows PowerShell
powershell -version 2.0

Since we are stopping to build Windows powershell, and core edition doesn't have any -version 2.0 support, it's probably okey. #ByDesign

sergei (@vors), the @PowerShell/powershell-committee discussed this and that is pretty much the thinking: -version for Windows PowerShell really only supported 2.0 and we're moving away from that. Aligning with Linux convention makes sense. PSCore supports side-by-side intrinsically and using file paths to launch different versions is completely acceptable. #ByDesign

Furthermore we can always do something like powershell -version:2 if people really demand that functionality in the future (and actually Jason Shirk (@lzybkr) and Bruce Payette (@BrucePay) agreed that it would even be acceptable to do powershell -version 2 as it's highly unlikely that anyone wants to echo one int when they shell out to PowerShell).

Why are you setting _commandLineCommand here? #Resolved

vestige of earlier implementation - removed

In reply to: 100401276 [](ancestors = 100401276)

I recommend to use PSVersionInfo.GetPSVersionTable()["GitCommitId"], or even better, add an internal static property GitCommitId right after the PSVersion property at here, and then use PSVersionInfo.GitCommitId here.

Reason: PSVersionInfo has a type initializer, which calls GetCommitInfo() and store the value in a hashtable. the current implementation of GetCommitInfo() reads git commit information from a file, which is slow and this implementation is subject to change (this method may be gone in near future -- we want to generate code at build time to embed the git commit id info, so as to avoid reading a file at startup time). Since the type initializer must run the first time you access a type, it's a waste to call GetCommitInfo() here to read the file again. #Resolved

There is an extra blank line here. #Resolved

what would happen if I have powershell -noprofile -noexit -version? #WontFix

it would report the version and exit - I can add a test for that explicitly if you like. Rather than testing all of the permutations for the parameters, I chose a representative single case

In reply to: 100405816 [](ancestors = 100405816)