GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix for race bug in WSMan command plugin instance close operation by PaulHigin · Pull Request #3203 · PowerShell/PowerShell

Conversation

@PaulHigin

@PaulHigin Paul Higinbotham (PaulHigin) commented Feb 24, 2017

Copy link
Copy Markdown
Contributor

This fixes a rare race condition that can crash the WinRM service when remote sessions are closing.
From the crash stack dump it is clear that the exception comes from a SetThreadProperties call that references an invalid unmanaged data handle which was previously released. The data handle is released when the plugin command instance is closed and the error occurs when two threads contend to close the same object.

The close command and close session operations are designed to be multi-thread safe, but the SetThreadProperties call is done before the atomic check is performed. The fix is to move the SetThreadProperties call after the atomic check to ensure it is only called when the object is in the opened state.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@PaulHigin
Fix for race bug in WSMan command plugin instance close operation
33f04b9
@PaulHigin Paul Higinbotham (PaulHigin) assigned Mike Richmond (mirichmo) Feb 24, 2017
@PaulHigin
Paul Higinbotham (PaulHigin) requested a review from Dan Travison (dantraMSFT) February 24, 2017 21:42
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Feb 24, 2017
@mirichmo
Mike Richmond (mirichmo) requested a review from Manoj Ampalam (manojampalam) February 24, 2017 22:25
dantraMSFT
Dan Travison (dantraMSFT) approved these changes Feb 25, 2017
View reviewed changes
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 136213d into PowerShell:master Feb 27, 2017
@PaulHigin
Paul Higinbotham (PaulHigin) deleted the RaceFix branch February 28, 2017 18:02
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@PaulHigin @daxian-dbw
Fix for race bug in WSMan command plugin instance close operation (Po…
58e0c2a
…werShell#3203)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manojampalam Manoj Ampalam (manojampalam) Awaiting requested review from manojampalam
1 more reviewer
@dantraMSFT Dan Travison (dantraMSFT) dantraMSFT approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@mirichmo Mike Richmond (mirichmo)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@PaulHigin @dantraMSFT @daxian-dbw @msftclas @mirichmo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.