GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||
GeezerVison is showing github.com — Fix powershell to not crash on converting recursive array to bool by PetSerAl · Pull Request #3208 · PowerShell/PowerShell Conversation
|
|
@PetSerAl, It will cover your contributions to all Microsoft-managed open source projects. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Code changes look good - we do need the cla to be signed before it can be merged. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
PetSerAl Thanks for your contribution! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
PetSerAl, |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
One possible breaking change came to my mind: $a = ,,$false $b = ,[PSObject](,$false) !!$a # $true !!$b # was $false, now is $true So, this PR make PowerShell behavior more consistent in regard to wrapping array into |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
I think the behavior with the fix reflects the original intention of the code. Here is the comment in
And as you said, now the conversion is more consistent: After Fix Using a nested array in |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
It's definitely obscure, I'm not worried about the change. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.