GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove System.Array type data by PetSerAl · Pull Request #3231 · PowerShell/PowerShell

Conversation

@PetSerAl

@PetSerAl PetSerAl commented Feb 28, 2017

Copy link
Copy Markdown
Contributor

Closes #3222

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
PetSerAl added 5 commits February 28, 2017 21:21
@PetSerAl
Rename Types_Ps1Xml.generated.cs
35860d0
@PetSerAl
Remove <auto-generated> header from Types_Ps1Xml.cs
6740297
@PetSerAl
Remove System.Array type data
0f8e338
@PetSerAl
Change System.Array to System.DateTime in tests
80c0376
@PetSerAl
Add test for absence of System.Array type data
fd09cd7
@msftclas

Microsoft Contribution License Agreements (msftclas) commented Feb 28, 2017

Copy link
Copy Markdown

PetSerAl,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label Feb 28, 2017
@daxian-dbw Dongbo Wang (daxian-dbw) self-assigned this Feb 28, 2017
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Feb 28, 2017
View reviewed changes
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Feb 28, 2017

Copy link
Copy Markdown
Member

#3230 is opened to track other *.generated.cs files.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Feb 28, 2017
Rename "generated" files #3230
Closed
iSazonov
Ilya (iSazonov) reviewed Feb 28, 2017
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/typedata.tests.ps1 Outdated
Context "Get-TypeData" {
It "System.Array" {
(Get-TypeData System.Array).TypeName | Should Be System.Array
Get-TypeData System.Array | Should Be $null

@iSazonov Ilya (iSazonov) Feb 28, 2017

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this test? Maybe remove?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@PetSerAl PetSerAl Feb 28, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just add it by analogy to other existing test. If you think, that it is not necessary here, then I can remove that last commit.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@daxian-dbw Dongbo Wang (daxian-dbw) Mar 1, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this test using on-page edit.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@PetSerAl PetSerAl Mar 1, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dongbo Wang (@daxian-dbw) You could just remove one last commit.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@daxian-dbw Dongbo Wang (daxian-dbw) Mar 1, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PetSerAl Yes. I made this change with the online editor. But I'm going to squash and merge, so it should be fine.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw
Remove the test for Get-TypeData System.Array
0a1c96d
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit c490e36 into PowerShell:master Mar 1, 2017
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Mar 1, 2017

Copy link
Copy Markdown
Member

PetSerAl Thanks for the contribution!
iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT Steve Lee (SteveL-MSFT) mentioned this pull request Mar 16, 2017
ConvertFrom-Json doesn't unwrap arrays on output, resulting in an extraneous wrapper JSON object with Count and Value properties on reconversion #3153
Closed
@PetSerAl
PetSerAl deleted the remove-system.array-type-data branch March 19, 2017 00:02
This was referenced Nov 28, 2017
Unexpected behavior of array-valued calculated properties added to a custom object with Select-Object #3163
Closed
Objects are situationally invisibly [psobject]-wrapped, sometimes causing unexpected behavior. #5579
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@PetSerAl @daxian-dbw
Remove System.Array type data (PowerShell#3231)
fa6b8ef 
* Rename Types_Ps1Xml.generated.cs
* Remove <auto-generated> header from Types_Ps1Xml.cs
* Remove System.Array type data
* Update `Get-TypeData` tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@iSazonov Ilya (iSazonov) iSazonov left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@PetSerAl @msftclas @daxian-dbw @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.