GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove BuildVersion from $PSVersionTable by iSazonov · Pull Request #3877 · PowerShell/PowerShell

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented May 29, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Close #1415

Motivation

PowerShell Committee concluded to remove BuildVersion property from $PSVersionTable as unneeded - now we use new GitCommitId property.

Fix

Remove BuildVersion from PSVersionHashTable and PSVersionInfo types and replace BuildVersion with GitCommitId in codes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov
Remove BuildVersion from PSVersionInfo type
ac20884
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label May 29, 2017
@iSazonov
Fix error messages
e2b8685
@iSazonov Ilya (iSazonov) changed the title Remove BuildVersion from PSVersionInfo type Remove BuildVersion from $PSVersionTable May 29, 2017
@iSazonov
Remove BuildVersion from tests
da609ce
@iSazonov
Ilya (iSazonov) force-pushed the remove-buildversion branch from 4ec781e to da609ce Compare May 29, 2017 05:54
@iSazonov

Ilya (iSazonov) commented May 29, 2017

Copy link
Copy Markdown
Collaborator Author

CI AppVeyor is failed on Set-Content.Tests.ps1 tests - it seems it is not related to the PR changes 😕
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov
Ilya (iSazonov) requested a review from Steve Lee (SteveL-MSFT) June 1, 2017 16:05
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Jun 1, 2017
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
vors
sergei (vors) approved these changes Jun 1, 2017
View reviewed changes
@vors
sergei (vors) merged commit 9c42d2d into PowerShell:master Jun 1, 2017
@iSazonov
Ilya (iSazonov) deleted the remove-buildversion branch June 2, 2017 03:01
@iSazonov Ilya (iSazonov) added the Documentation Needed in this repo Documentation is needed in this repo label Jun 17, 2017
@joeyaiello Joey Aiello (joeyaiello) mentioned this pull request Oct 15, 2018
Docs needed for 'Remove BuildVersion from $PSVersionTable' MicrosoftDocs/PowerShell-Docs#3099
Closed
@joeyaiello Joey Aiello (joeyaiello) removed Documentation Needed in this repo Documentation is needed in this repo labels Oct 15, 2018
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@iSazonov @vors
Remove BuildVersion from $PSVersionTable (PowerShell#3877)
19c6c16 
* Remove BuildVersion from PSVersionInfo type

* Fix error messages

* Remove BuildVersion from tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
+1 more reviewer
@vors sergei (vors) vors approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@iSazonov @vors @SteveL-MSFT @joeyaiello @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.