GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add version to PowerShell banner by iSazonov · Pull Request #3916 · PowerShell/PowerShell

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented Jun 2, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Close #3895

Motivation

Since we support side-by-side, it makes it easier to see which PowerShell version you started rather than checking $psversiontable or $pshome.

Fix

Add "GitCommitId" to PowerShell banner.

Follow-up work

Based on #3690 later we will change a GitCommitId format.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov
Add version to PowerShell banner
b9b8ee4
@iSazonov
Ilya (iSazonov) requested review from Steve Lee (SteveL-MSFT) and Jason Shirk (lzybkr) June 2, 2017 09:09
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label Jun 2, 2017
vors
sergei (vors) suggested changes Jun 3, 2017
View reviewed changes
Comment thread src/Microsoft.PowerShell.ConsoleHost/resources/ManagedEntranceStrings.resx Outdated
<value>PowerShell
Copyright (C) Microsoft Corporation. All rights reserved.</value>
Copyright (C) Microsoft Corporation. All rights reserved.
Version: {0}</value>

@vors sergei (vors) Jun 3, 2017

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the version proposed by Steve Lee (@SteveL-MSFT) originally reads nicer:

PowerShell {0}
Copyright (C) Microsoft Corporation. All rights reserved.

For example, here is how python banner looks like

Python 2.7.10 (default, Oct 18 2015, 00:31:39) 
[GCC 4.2.1 Compatible Apple LLVM 7.0.0 (clang-700.0.72)] on darwin
Type "help", "copyright", "credits" or "license" for more information.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Jun 3, 2017

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it doesn't look elegant :-) but fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov
Change banner
b477f49
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Jun 3, 2017
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov

Ilya (iSazonov) commented Jun 7, 2017

Copy link
Copy Markdown
Collaborator Author

sergei (@vors) Can you approve and merge?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mirichmo Mike Richmond (mirichmo) assigned Jason Shirk (lzybkr) Jun 7, 2017
@lzybkr
Jason Shirk (lzybkr) merged commit 0052ebb into PowerShell:master Jun 7, 2017
@iSazonov
Ilya (iSazonov) deleted the banner-version branch June 8, 2017 05:11
@iSazonov
Ilya (iSazonov) restored the banner-version branch June 20, 2017 17:37
@iSazonov
Ilya (iSazonov) deleted the banner-version branch July 20, 2017 11:35
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@iSazonov @lzybkr
Add version to PowerShell banner (PowerShell#3916)
c8dace7 
Fixes PowerShell#3895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@lzybkr Jason Shirk (lzybkr) Awaiting requested review from lzybkr
+1 more reviewer
@vors sergei (vors) vors requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@lzybkr Jason Shirk (lzybkr)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@iSazonov @vors @SteveL-MSFT @lzybkr @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.