GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add 'CSharpVersion7' member into public 'Language' enum by iSazonov · Pull Request #3933 · PowerShell/PowerShell

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented Jun 5, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Close #3853

Public enum 'LanguageVersion' from 'Microsoft.CodeAnalysis.CSharp'
already contains 'CSharp7' member.
After moving PowerShell to .Net Core 2.0 we should add 'CSharpVersion7'
member into public 'Microsoft.PowerShell.Commands.Language' enum too.

This will allow 'Add-Type -Language CSharpVersion7'

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov
Add 'CSharpVersion7' member into public 'Language' enum
db58a19 
Public enum 'LanguageVersion' from 'Microsoft.CodeAnalysis.CSharp'
already contains 'CSharp7' member.
After moving PowerShell to .Net Core 2.0 we should add 'CSharpVersion7'
member into public 'Microsoft.PowerShell.Commands.Language' enum too.

This will allow 'Add-Type -Language CSharpVersion7'
@iSazonov
Ilya (iSazonov) requested a review from Jason Shirk (lzybkr) June 5, 2017 10:25
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label Jun 5, 2017
Francisco-Gamino
Francisco Gamino (Francisco-Gamino) reviewed Jun 5, 2017
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Add-Type.Tests.ps1
It "Public 'Language' enumeration contains all members" {
[Enum]::GetNames("Microsoft.PowerShell.Commands.Language") -join "," | Should Be "CSharp,CSharpVersion7,CSharpVersion6,CSharpVersion5,CSharpVersion4,CSharpVersion3,CSharpVersion2,CSharpVersion1,VisualBasic,JScript"
}

@Francisco-Gamino Francisco Gamino (Francisco-Gamino) Jun 5, 2017

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a test case for 'Add-Type -Language CSharpVersion7'?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Francisco-Gamino Francisco Gamino (Francisco-Gamino) Jun 5, 2017

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, should there be two commits (one for the product change and one for the test)?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Jun 5, 2017

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We checked it manually in the original Issue.
I didn't touch the functionality of this cmdlet. Besides, we don't even have tests for it right now. So I believe this is a separate huge job.
It seems Dongbo Wang (@daxian-dbw) is working on Add-Type. It would be good to agree on the distribution of work on tests.

I can say nothing about separate commits. 😕

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@mirichmo Mike Richmond (mirichmo) Jun 20, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two commits (one for code changes and one for tests) is not a strict requirement.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mirichmo Mike Richmond (mirichmo) self-assigned this Jun 7, 2017
@iSazonov

Ilya (iSazonov) commented Jun 14, 2017

Copy link
Copy Markdown
Collaborator Author

Mike Richmond (@mirichmo) Could you please continue with the PR?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mirichmo
Mike Richmond (mirichmo) approved these changes Jun 20, 2017
View reviewed changes
@mirichmo
Mike Richmond (mirichmo) merged commit f30b06f into PowerShell:master Jun 20, 2017
@iSazonov
Ilya (iSazonov) deleted the CSharpVersion7 branch June 20, 2017 03:00
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@iSazonov @mirichmo
Add 'CSharpVersion7' member into public 'Language' enum (PowerShell#3933
ba4652f 
)

Public enum 'LanguageVersion' from 'Microsoft.CodeAnalysis.CSharp'
already contains 'CSharp7' member.
After moving PowerShell to .Net Core 2.0 we should add 'CSharpVersion7'
member into public 'Microsoft.PowerShell.Commands.Language' enum too.

This will allow 'Add-Type -Language CSharpVersion7'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lzybkr Jason Shirk (lzybkr) Awaiting requested review from lzybkr
2 more reviewers
@Francisco-Gamino Francisco Gamino (Francisco-Gamino) Francisco-Gamino left review comments
@mirichmo Mike Richmond (mirichmo) mirichmo approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@mirichmo Mike Richmond (mirichmo)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@iSazonov @Francisco-Gamino @mirichmo @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.