GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — PSReadline unusable on ServerCore container by SteveL-MSFT · Pull Request #3937 · PowerShell/PowerShell

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Jun 5, 2017

Copy link
Copy Markdown
Member

The GetCurrentConsoleFontEx() api is available, but fails with unspecified error code on ServerCore running in container. Using similar logic to NanoServer where the api is not available, don't make the error fatal. Ignore the error so PSReadline continues to work. Impact is if using ServerCore on non-English (double char wide) characters.

Fix #3927

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SteveL-MSFT
ignore failure on GetConsoleFontInfoEx() api call which is available …
fab1e66 
…on ServerCore but fails running in container to allow PSReadline to continue
@SteveL-MSFT
Steve Lee (SteveL-MSFT) requested a review from Jason Shirk (lzybkr) June 5, 2017 18:29
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Jun 5, 2017
@SteveL-MSFT Steve Lee (SteveL-MSFT) assigned Jason Shirk (lzybkr) Jun 5, 2017
lzybkr
Jason Shirk (lzybkr) approved these changes Jun 5, 2017
View reviewed changes
@lzybkr
Jason Shirk (lzybkr) merged commit 22a3a89 into PowerShell:master Jun 5, 2017
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the psreadline-servercore branch June 19, 2017 21:16
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@SteveL-MSFT @lzybkr
Silently ignore failure on GetConsoleFontInfoEx() api call (PowerShel…
f716d6d 
…l#3937)

The api is available on ServerCore but fails (returns false) running in container.
Silently ignoring the failure allows PSReadline to work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@lzybkr Jason Shirk (lzybkr) lzybkr approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@lzybkr Jason Shirk (lzybkr)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@SteveL-MSFT @lzybkr @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.