GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove ClrVersion property from $PSVersionTable by SteveL-MSFT · Pull Request #4027 · PowerShell/PowerShell

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Jun 15, 2017

Copy link
Copy Markdown
Member

The ClrVersion property of $PSVersionTable is not useful with CoreCLR and end users should not be using
that value to determine compatibility. Recommendation from dotnet team is to remove that property.

Fix #1395

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SteveL-MSFT
ClrVersion property of $PSVersionTable is not useful with CoreCLR and…
645c875 
… end users should not be using

that value to determine compatibility.  Recommendation from dotnet team is to remove that property.
@SteveL-MSFT Steve Lee (SteveL-MSFT) assigned Mike Richmond (mirichmo) Jun 15, 2017
@SteveL-MSFT
Steve Lee (SteveL-MSFT) requested a review from Ilya (iSazonov) June 15, 2017 22:48
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Jun 15, 2017
@lzybkr Jason Shirk (lzybkr) added the Breaking-Change breaking change that may affect users label Jun 16, 2017
iSazonov
Ilya (iSazonov) reviewed Jun 16, 2017
View reviewed changes

@iSazonov Ilya (iSazonov) left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should remove internal static Version CLRVersion and internal const string PSCLRVersionName

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Jun 16, 2017

Copy link
Copy Markdown
Member Author

Ilya (@iSazonov) will remove those
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT
Removed internal members used for CLRVersion
6d8d085
iSazonov
Ilya (iSazonov) approved these changes Jun 16, 2017
View reviewed changes
@iSazonov

Ilya (iSazonov) commented Jun 16, 2017

Copy link
Copy Markdown
Collaborator

LGTM.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Jun 19, 2017

Copy link
Copy Markdown
Member Author

Mike Richmond (@mirichmo) can you merge?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mirichmo
Mike Richmond (mirichmo) reviewed Jun 19, 2017
View reviewed changes
Comment thread src/System.Management.Automation/engine/PSVersionInfo.cs
}
}

internal static Version CLRVersion

@mirichmo Mike Richmond (mirichmo) Jun 19, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is our stance on removing FullCLR compatibility of the code? If we are dropping that requirement and only focusing on CoreCLR, then you should remove PSCLRVersionName from line 77 as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@SteveL-MSFT Steve Lee (SteveL-MSFT) Jun 19, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it since we removed the other members anyways. After beta.3 goes out, I intend to revisit the discussion about removing FullCLR code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Steve Lee (SteveL-MSFT) added 2 commits June 19, 2017 13:19
@SteveL-MSFT
removed CLRVersion from FullCLR build as well
5420ebf
@SteveL-MSFT
added additional information to run start-psbootstrap -buildnative …
87411c5 
…if cmake is not found
mirichmo
Mike Richmond (mirichmo) approved these changes Jun 19, 2017
View reviewed changes
@mirichmo
Mike Richmond (mirichmo) merged commit a66cd0b into PowerShell:master Jun 19, 2017
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the clrversion branch June 28, 2017 21:19
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@SteveL-MSFT @mirichmo
Remove ClrVersion property from $PSVersionTable (PowerShell#4027)
92f1330 
* ClrVersion property of $PSVersionTable is not useful with CoreCLR and end users should not be using it
that value to determine compatibility.  Recommendation from dotnet team is to remove that property.

* Removed internal members used for CLRVersion

* removed CLRVersion from FullCLR build as well

* added additional information to run `start-psbootstrap -buildnative` if cmake is not found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
+1 more reviewer
@mirichmo Mike Richmond (mirichmo) mirichmo approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@mirichmo Mike Richmond (mirichmo)

Labels

Breaking-Change breaking change that may affect users

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@SteveL-MSFT @iSazonov @mirichmo @lzybkr @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.