GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — Add description of recommended settings for VS Code by iSazonov · Pull Request #4054 · PowerShell/PowerShell Conversation
Ilya (iSazonov)
force-pushed
the
contrib-vscode
branch
from
8f2e798 to
bc5d3da
Compare
Collaborator
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Steve Lee (SteveL-MSFT)
requested changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like a double space between
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should we just limit this to resx and powershell script files for now or are all the c# files clean?
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
|
|
||
| ### Code Editors | ||
|
|
||
| [You can use multiplatform Visual Studio Code (VS Code)][use-vscode-editor] |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I think it should say: You should use the multi-platform ...
And make just the Visual Studio Code (VSCode) the hyperlink instead of the whole line
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Keith Hill (@rkeithhill) Any thoughts? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Ilya (@iSazonov) The problem with putting this in the docs is that few people read the docs. That said, it's better to have in the docs than nowhere. :-) But at some point, I suggest we either add a This brings me to my next suggestion. Consider adding a |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Keith Hill (@rkeithhill) Thanks for great feedback! I think we should be more conservative - other developers might have their preferences and we shouldn't overwrite them. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Keep in mind that the use of a "workspace" specific settings file only overrides "user" specific settings for that workspace. And that is typically what you want. That is, a user might prefer tabs to spaces but this project uses spaces. So adding that setting to an editor config file will ensure that spaces are used for this user in only this workspace. In his own projects, tabs will still be used. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Keith Hill (@rkeithhill) The PR is for docs only. I believe your suggestions is great for new PR. Could you please open it? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
This reverts commit 84d458b.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.