GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add description of recommended settings for VS Code by iSazonov · Pull Request #4054 · PowerShell/PowerShell

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented Jun 20, 2017

Copy link
Copy Markdown
Collaborator

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label Jun 20, 2017
@iSazonov
Add link to VS Code docs
bc5d3da
@iSazonov
Ilya (iSazonov) force-pushed the contrib-vscode branch from 8f2e798 to bc5d3da Compare June 20, 2017 15:04
@iSazonov Ilya (iSazonov) mentioned this pull request Jun 20, 2017
Resx - remove trailing white spaces and extra Newline at EOF #4047
Merged
@iSazonov

Ilya (iSazonov) commented Jun 20, 2017

Copy link
Copy Markdown
Collaborator Author

CI OSX temporary failed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov
Ilya (iSazonov) requested a review from Steve Lee (SteveL-MSFT) June 20, 2017 15:41
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Jun 20, 2017
View reviewed changes
Comment thread docs/learning-powershell/using-vscode.md Outdated

By using the steps in the previous paragraph you can add onfiguration settings in `settings.json`.

We recommend the following configuration settings for Visual Studio Code:

@SteveL-MSFT Steve Lee (SteveL-MSFT) Jun 20, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a double space between following and configuration

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@iSazonov Ilya (iSazonov) Jun 20, 2017

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread docs/learning-powershell/using-vscode.md
"editor.renderWhitespace": "all",
"editor.renderControlCharacters": true,
"omnisharp.projectLoadTimeout": 120,
"files.trimTrailingWhitespace": true

@SteveL-MSFT Steve Lee (SteveL-MSFT) Jun 20, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just limit this to resx and powershell script files for now or are all the c# files clean?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@iSazonov Ilya (iSazonov) Jun 20, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# files was fixed in #3001 by lzybkr.

But we stiil have about 350 files with tabs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread .github/CONTRIBUTING.md Outdated

### Code Editors

[You can use multiplatform Visual Studio Code (VS Code)][use-vscode-editor]

@SteveL-MSFT Steve Lee (SteveL-MSFT) Jun 20, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should say: You should use the multi-platform ...

And make just the Visual Studio Code (VSCode) the hyperlink instead of the whole line

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@iSazonov Ilya (iSazonov) Jun 20, 2017

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Ilya (iSazonov) added 2 commits June 20, 2017 23:59
@iSazonov
Update using-vscode.md
49f019c
@iSazonov
Update CONTRIBUTING.md
5e5ccd6
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Jun 20, 2017
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@iSazonov

Ilya (iSazonov) commented Jun 21, 2017

Copy link
Copy Markdown
Collaborator Author

Keith Hill (@rkeithhill) Any thoughts?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rkeithhill

Keith Hill (rkeithhill) commented Jun 21, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Ilya (@iSazonov) The problem with putting this in the docs is that few people read the docs. That said, it's better to have in the docs than nowhere. :-) But at some point, I suggest we either add a .vscode\settting.json for this project or perhaps even better, add a .editorconfig file in the root dir. This is a config file that supports multiple editors. VS 2017 supports this file and VSCode does if you install the EditorConfig extension.

This brings me to my next suggestion. Consider adding a .vscode\extensions.json file which will prompt VSCode users to install the "recommended" extensions for this project. Perhaps with contents like this:

{
    // See http://go.microsoft.com/fwlink/?LinkId=827846
    // for the documentation about the extensions.json format
    "recommendations": [
        "ms-vscode.csharp",
        "ms-vscode.powershell",
        "EditorConfig.editorconfig"
    ]
}
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov

Ilya (iSazonov) commented Jun 21, 2017

Copy link
Copy Markdown
Collaborator Author

Keith Hill (@rkeithhill) Thanks for great feedback!

I think we should be more conservative - other developers might have their preferences and we shouldn't overwrite them.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rkeithhill

Keith Hill (rkeithhill) commented Jun 21, 2017

Copy link
Copy Markdown
Collaborator

Keep in mind that the use of a "workspace" specific settings file only overrides "user" specific settings for that workspace. And that is typically what you want. That is, a user might prefer tabs to spaces but this project uses spaces. So adding that setting to an editor config file will ensure that spaces are used for this user in only this workspace. In his own projects, tabs will still be used.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov

Ilya (iSazonov) commented Jun 21, 2017

Copy link
Copy Markdown
Collaborator Author

Keith Hill (@rkeithhill) The PR is for docs only. I believe your suggestions is great for new PR. Could you please open it?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daxian-dbw
Fix a typo
6154587
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Jun 21, 2017
View reviewed changes
@daxian-dbw
Minor updates to 'Contributing.md'
0b787fe
@daxian-dbw Dongbo Wang (daxian-dbw) self-assigned this Jun 21, 2017
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 84d458b into PowerShell:master Jun 23, 2017
Mike Richmond (mirichmo) added a commit that referenced this pull request Jun 23, 2017
@mirichmo
Revert "Add description of recommended settings for VS Code (#4054)"
ca541cd
This reverts commit 84d458b.
@iSazonov
Ilya (iSazonov) deleted the contrib-vscode branch July 20, 2017 11:32
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@iSazonov @daxian-dbw
Add description of recommended settings for VS Code (PowerShell#4054)
667a154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@iSazonov @rkeithhill @daxian-dbw @SteveL-MSFT @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.