GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — added test coverage for -notcontains, -is, -isnot operators by SteveL-MSFT · Pull Request #4179 · PowerShell/PowerShell

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Jul 3, 2017

Copy link
Copy Markdown
Member

-like and -contains already has coverage

Fix #4162

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SteveL-MSFT
added test coverage for -notcontains, -is, -isnot operators
150d74d
@SteveL-MSFT Steve Lee (SteveL-MSFT) assigned Travis Plunk (TravisEz13) Jul 3, 2017
@SteveL-MSFT
Steve Lee (SteveL-MSFT) requested review from James Truher (JamesWTruher) and Aditya Patwardhan (adityapatwardhan) July 3, 2017 22:18
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Jul 3, 2017
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested changes Jul 6, 2017
View reviewed changes
Comment thread test/powershell/Language/Operators/ComparisonOperator.Tests.ps1 Outdated
$arr= 'Hello','world'
$arr -contains 'Hello' | Should Be $true
It "Should be <result> for 'Hello','world' <operator> <rhs>" -TestCases @(
@{result = $true; operator = "-contains"; rhs = "'Hello'"},

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Jul 6, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test for case sensitive variants? ccontains and cnotcontains? There are some tests below. Can we move them to this It and add it as part of -TestCases array.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@SteveL-MSFT Steve Lee (SteveL-MSFT) Jul 7, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do some general cleanup of the tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SteveL-MSFT
cleaned up tests to use -TestCases, added missing -cnotcontains test
aba74b6
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Jul 8, 2017

Copy link
Copy Markdown
Member Author

Aditya Patwardhan (@adityapatwardhan) addressed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Jul 8, 2017
View reviewed changes

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13
Travis Plunk (TravisEz13) merged commit db813b6 into PowerShell:master Jul 11, 2017
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the test-operators branch August 24, 2017 03:02
@markekraus Mark Kraus (markekraus) mentioned this pull request Aug 31, 2017
Add test WebListener module and tests for Web Cmdlet Certificate Authentication #4622
Merged
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@SteveL-MSFT @TravisEz13
add test coverage for -notcontains, -is, -isnot operators (PowerShell…
7aa9170 
…#4179)

* added test coverage for -notcontains, -is, -isnot operators

* cleaned up tests to use -TestCases, added missing -cnotcontains test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@SteveL-MSFT @adityapatwardhan @msftclas @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.