GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Support Invoke-Item -Path <folder> by SteveL-MSFT · Pull Request #4262 · PowerShell/PowerShell

Support Invoke-Item -Path <folder> #4262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dongbo Wang (daxian-dbw) merged 9 commits into PowerShell:master from SteveL-MSFT:invoke-item
Jul 28, 2017

Uh oh!

There was an error while loading. Please reload this page.

Merged

Support Invoke-Item -Path <folder> #4262

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
65513b8
Support Invoke-Item -Path <folder>
SteveL-MSFT Jul 15, 2017
706a7b2
added validation that shell window opened on Windows
SteveL-MSFT Jul 15, 2017
1a3134c
special case directories to work on Unix
SteveL-MSFT Jul 15, 2017
08f6a43
reorganized code to make it more readable
SteveL-MSFT Jul 15, 2017
1aa5e77
changed fixed sleep to polling to make test more reliable
SteveL-MSFT Jul 15, 2017
c04d1be
added validation for Linux
SteveL-MSFT Jul 15, 2017
186f8ff
reorganized code based on feedback
SteveL-MSFT Jul 18, 2017
46442da
added MacOS test
SteveL-MSFT Jul 25, 2017
4a4cd71
increased timeout for waiting for window to open
SteveL-MSFT Jul 27, 2017
File filter
Filter by extension

Clear filters
Conversations
Failed to load comments.
Loading

Uh oh!

There was an error while loading. Please reload this page.

Jump to
Jump to file
Failed to load files.
Loading

Uh oh!

There was an error while loading. Please reload this page.

Diff view
Diff view
Prev Previous commit
increased timeout for waiting for window to open
  • Loading branch information

Uh oh!

There was an error while loading. Please reload this page.

@SteveL-MSFT
SteveL-MSFT committed Jul 27, 2017
commit 4a4cd71e0cac55cf1938f32b83e07e8c94af32fe

There are no files selected for viewing

8 changes: 4 additions & 4 deletions 8 test/powershell/Modules/Microsoft.PowerShell.Utility/Invoke-Item.Tests.ps1
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Describe "Invoke-Item basic tests" -Tags "CI" {
Invoke-Item -Path $TestFile
$startTime = Get-Date
$title = [String]::Empty
while (((Get-Date) - $startTime).TotalSeconds -lt 5 -and ($title -ne $expectedTitle))
while (((Get-Date) - $startTime).TotalSeconds -lt 10 -and ($title -ne $expectedTitle))
{
Start-Sleep -Milliseconds 100
$title = 'tell application "TextEdit" to get name of front window' | osascript
Expand Down Expand Up @@ -111,7 +111,7 @@ Categories=Application;
Invoke-Item -Path $PSHOME
$startTime = Get-Date
# may take time for explorer to open window
while (((Get-Date) - $startTime).TotalSeconds -lt 5 -and ($windows.Count -eq $before))
while (((Get-Date) - $startTime).TotalSeconds -lt 10 -and ($windows.Count -eq $before))
{
Start-Sleep -Milliseconds 100
}
Expand All @@ -129,7 +129,7 @@ Categories=Application;
Invoke-Item -Path $PSHOME
$startTime = Get-Date
# may take time for handler to start
while (((Get-Date) - $startTime).TotalSeconds -lt 5 -and (-not (Test-Path "$HOME/InvokeItemTest.Success")))
while (((Get-Date) - $startTime).TotalSeconds -lt 10 -and (-not (Test-Path "$HOME/InvokeItemTest.Success")))
{
Start-Sleep -Milliseconds 100
}
Expand All @@ -143,7 +143,7 @@ Categories=Application;
$startTime = Get-Date
$expectedTitle = Split-Path $PSHOME -Leaf
$title = [String]::Empty
while (((Get-Date) - $startTime).TotalSeconds -lt 5 -and ($title -ne $expectedTitle))
while (((Get-Date) - $startTime).TotalSeconds -lt 10 -and ($title -ne $expectedTitle))
{
Start-Sleep -Milliseconds 100
$title = 'tell application "Finder" to get name of front window' | osascript
Expand Down
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.