GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix ConvertTo-Html single matched column header bug by mirichmo · Pull Request #4276 · PowerShell/PowerShell

Conversation

@mirichmo

@mirichmo Mike Richmond (mirichmo) commented Jul 17, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This replaces abandoned PR #2184 since the fix looks like it might be worthwhile to include. This PR adds the changes requested in the original PR that held it up from being merged.

PR #2241 included the original tests.

FYI: Tim Curwick (@TimCurwick)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Jul 17, 2017
@mirichmo
Mike Richmond (mirichmo) requested review from James Truher (JamesWTruher), Steve Lee (SteveL-MSFT) and jeffbi July 17, 2017 22:36
@JamesWTruher

James Truher (JamesWTruher) commented Jul 18, 2017

Copy link
Copy Markdown
Collaborator

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JamesWTruher
James Truher (JamesWTruher) approved these changes Jul 18, 2017
View reviewed changes
@TimCurwick @mirichmo
Fix ConvertTo-Html single matched column header bug
943eabd
@mirichmo
Mike Richmond (mirichmo) force-pushed the pr-completion-for-convertto-html branch from 4cc8346 to 943eabd Compare July 18, 2017 20:27
@mirichmo

Mike Richmond (mirichmo) commented Jul 18, 2017

Copy link
Copy Markdown
Member Author

The content is the same. I just re-did the commit giving Tim Curwick (@TimCurwick) credit for it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mirichmo
Mike Richmond (mirichmo) requested a review from Aditya Patwardhan (adityapatwardhan) July 18, 2017 20:48
@mirichmo Mike Richmond (mirichmo) mentioned this pull request Jul 18, 2017
Fix ConvertTo-Html single matched column header bug #2184
Closed
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Jul 18, 2017
View reviewed changes

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mirichmo

Mike Richmond (mirichmo) commented Jul 18, 2017

Copy link
Copy Markdown
Member Author

@PowerShell/powershell-maintainers This is ready for merge
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 4f13bf4 into PowerShell:master Jul 18, 2017
@mirichmo
Mike Richmond (mirichmo) deleted the pr-completion-for-convertto-html branch August 8, 2017 23:11
@rjmholt Rob Holt (rjmholt) mentioned this pull request Mar 8, 2018
ConvertTo-Html incorrectly labels default single column #2185
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@mirichmo @daxian-dbw
Fix ConvertTo-Html single matched column header bug (PowerShell#4276)
090bc14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@jeffbi jeffbi Awaiting requested review from jeffbi
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT
+1 more reviewer
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@mirichmo @JamesWTruher @adityapatwardhan @daxian-dbw @msftclas @TimCurwick
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.