GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Increase test coverage for Rename-Item and Move-Item by jeffbi · Pull Request #4329 · PowerShell/PowerShell

Conversation

@jeffbi

@jeffbi jeffbi commented Jul 24, 2017

Copy link
Copy Markdown

Addresses parts of #4148.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Jeff Bienstadt
Increase test coverage for Rename-Item and Move-Item
f4ea391
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label Jul 24, 2017
dantraMSFT
Dan Travison (dantraMSFT) suggested changes Jul 25, 2017
View reviewed changes

@dantraMSFT Dan Travison (dantraMSFT) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest using -ErrorAction Stop for the operations that you expect to succeed. It will be clearer than diagnosing why the Should statement failed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Jeff Bienstadt
Changes per code review.
e8d304f
@jeffbi

jeffbi commented Jul 25, 2017

Copy link
Copy Markdown
Author

Fixed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
dantraMSFT
Dan Travison (dantraMSFT) approved these changes Jul 25, 2017
View reviewed changes
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested changes Jul 28, 2017
View reviewed changes

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1 Outdated
"$destDir/$testDir/$testFile" | Should Exist
}

It "Verity Move-Item will not move to an existing file" {

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Jul 28, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in Verity -> Verify

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@jeffbi jeffbi Aug 1, 2017

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Jul 28, 2017
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1 Outdated
$testDir | Should Exist
}

It "Verify Move-Item as substitue for Rename-Item" {

@SteveL-MSFT Steve Lee (SteveL-MSFT) Jul 28, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: substitute

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@jeffbi jeffbi Aug 1, 2017

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Jul 28, 2017

Copy link
Copy Markdown
Member

Add test for Access Denied
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Jeff Bienstadt added 4 commits July 31, 2017 18:26
Jeff Bienstadt
Fix typos
26595b8
Jeff Bienstadt
Add access-denied tests
657a494
Jeff Bienstadt
Add -skip on Unix for access-denied tests.
ec3b580
Jeff Bienstadt
Cleanup to fix CI failure.
c7240df
@jeffbi

jeffbi commented Aug 1, 2017

Copy link
Copy Markdown
Author

Added tests for access-denied. Steve Lee (@SteveL-MSFT) thanks for the pointer.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Aug 1, 2017
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Aug 1, 2017
View reviewed changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) assigned Aditya Patwardhan (adityapatwardhan) Aug 1, 2017
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 8f9aed8 into PowerShell:master Aug 2, 2017
@jeffbi
jeffbi deleted the tests-4148 branch August 2, 2017 18:22
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
jeffbi @adityapatwardhan
Increase test coverage for Rename-Item and Move-Item (PowerShell#4329)
9dc5512 
* Increase test coverage for Rename-Item and Move-Item
* Add access-denied tests
* Add -skip on Unix for access-denied tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
+1 more reviewer
@dantraMSFT Dan Travison (dantraMSFT) dantraMSFT approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@jeffbi @SteveL-MSFT @dantraMSFT @adityapatwardhan @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.