GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add test coverage for Registry by jeffbi · Pull Request #4354 · PowerShell/PowerShell

Conversation

@jeffbi

@jeffbi jeffbi commented Jul 26, 2017

Copy link
Copy Markdown

Addresses parts of #4148

Add coverage for Get-Item, Get-ChildItem, Set-Item, and Clear-Item

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Jeff Bienstadt
Add test coverage for Registry (#4148)
cec7f3f 
Add coverage for Get-Item, Get-ChildItem, Set-Item, and Clear-Item
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label Jul 26, 2017
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Jul 27, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Missing tests:

  • invalid hive root
  • validate -whatif works for set-item and clear-item
  • attempt accessing path you don't have access to
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw Dongbo Wang (daxian-dbw) assigned Aditya Patwardhan (adityapatwardhan) Jul 28, 2017
Jeff Bienstadt
Add more tests per code review.
307d107
@jeffbi

jeffbi commented Jul 28, 2017

Copy link
Copy Markdown
Author

Steve Lee (@SteveL-MSFT) These test run with the tag RequireAdminOnWindows. Is there a Registry path that admin would not have access to?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Jul 28, 2017

Copy link
Copy Markdown
Member

jeffbi try HKLM:\sam
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Jeff Bienstadt
Add test for accessing inaccessible path, per code review.
6f28212
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested changes Jul 28, 2017
View reviewed changes

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/Registry.Tests.ps1 Outdated
$property."$testPropertyName" | Should Be 0
}

It "Verity Clear-Item" {

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Jul 28, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo Verity->Verify

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Jul 28, 2017
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/Registry.Tests.ps1 Outdated
$key.Property.Length | Should BeExactly 0
}

It "Verity Clear-Item with -WhatIf" {

@SteveL-MSFT Steve Lee (SteveL-MSFT) Jul 28, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here has well Verify

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Jeff Bienstadt
Fix typos.
a946fc5
@jeffbi

jeffbi commented Jul 28, 2017

Copy link
Copy Markdown
Author

Typos fixed.

The Travis failure seems to be in a test for Invoke-Item.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Jul 28, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

jeffbi I have a PR to change the invoke-item tests to Feature as they shouldn't be CI anyways, I'll restart the Mac job, there's a chance it'll pass as it's a timing issue
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Jul 28, 2017
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Jul 28, 2017
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 19fcd43 into PowerShell:master Aug 2, 2017
@jeffbi
jeffbi deleted the tests-4148-registry branch August 2, 2017 18:21
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
jeffbi @adityapatwardhan
Add test coverage for Registry (PowerShell#4354)
c3c5f46 
* Add test coverage for Registry (PowerShell#4148)

* Add coverage for Get-Item, Get-ChildItem, Set-Item, and Clear-Item

* Add test for accessing inaccessible path, per code review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@jeffbi @SteveL-MSFT @adityapatwardhan @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.