GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — add amazonlinux compatibility in install-powershell.sh by DarwinJS · Pull Request #4360 · PowerShell/PowerShell

Conversation

@DarwinJS

@DarwinJS Darwin (DarwinJS) commented Jul 27, 2017

Copy link
Copy Markdown
Contributor

Amazon linux is a fine mix of CentOS versions ;) Needed to make a few adaptations to get the installer working for it. It might also pickup older versions of CentOS that use /etc/system-release instead of /etc/redhat-release

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Darwin Sanoy added 3 commits July 27, 2017 10:53
Darwin Sanoy Darwin Sanoy
Updated to support amazon linux (centos variant)
ece57f8
Darwin Sanoy Darwin Sanoy
Updated to support amazon linux (centos variant)
743bc76
Darwin Sanoy Darwin Sanoy
Updated to support amazon linux (centos variant)
17cf5cc
@msftclas

Microsoft Contribution License Agreements (msftclas) commented Jul 27, 2017

Copy link
Copy Markdown

Darwin (@DarwinJS),
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label Jul 27, 2017
@DarwinJS Darwin (DarwinJS) changed the title Issue4359 amazonlinux compatibility Issue4359 amazonlinux compatibility for install-powershell.sh Jul 27, 2017
@DarwinJS Darwin (DarwinJS) mentioned this pull request Jul 27, 2017
Ensure install-powershell.sh can install on Amazon Linux (CentOS variant) #4359
Closed
@DarwinJS

Darwin (DarwinJS) commented Jul 27, 2017

Copy link
Copy Markdown
Contributor Author

Tested and working on AMI:
ami-c58c1dd3 (amzn-ami-hvm-2017.03.0.20170417-x86_64-gp2)
Had to download install-powershell.sh and installpsh-redhat.sh and chmod 755.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw Dongbo Wang (daxian-dbw) assigned Travis Plunk (TravisEz13) Jul 28, 2017
@TravisEz13

Travis Plunk (TravisEz13) commented Jul 29, 2017

Copy link
Copy Markdown
Member

It would be good if we have a way of testing this. Do you want to create a docker file with amazonlinux https://hub.docker.com/_/amazonlinux/ which we can use to verify this works during a release?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DarwinJS

Darwin (DarwinJS) commented Jul 29, 2017

Copy link
Copy Markdown
Contributor Author

Travis Plunk (@TravisEz13) - not sure - the changes were quite moderate - probably just changes needed to support earlier versions of CentOS.

Do we test all the other supported distros and versions for the installer?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Jul 29, 2017

Copy link
Copy Markdown
Member

If you don't think it's needed, please file an issue and mention this PR. It's not much work if the installer is working.

Also, Please use the present tense, imperative style for commit messages and title per Contribution Guide
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DarwinJS

Darwin (DarwinJS) commented Jul 29, 2017

Copy link
Copy Markdown
Contributor Author

Travis Plunk (@TravisEz13) - I'm not sure what I should be putting in the issue? This PR is against issue 4359. If you mean that I file one for the docker file - do you mean I ask for one to be made or mention that one is not needed?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DarwinJS

Darwin (DarwinJS) commented Jul 30, 2017

Copy link
Copy Markdown
Contributor Author

Travis Plunk (@TravisEz13) - I might be interested in doing the docker file. Is there an existing pattern or guidance document? I looked around for docker files in the testing files of the repository - I found one - but can't tell exactly how to wire a new dockerfile into the automated testing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Jul 30, 2017

Copy link
Copy Markdown
Member

Darwin (@DarwinJS) Just write a docker file, similar to the ones in https://github.com/PowerShell/PowerShell/tree/master/docker/release and then add it to the list of tests cases here: https://github.com/PowerShell/PowerShell/blob/master/docker/tests/containerTestCommon.psm1#L68
There is a md on how to run the tests in the same folder.

The issue would say that the above needs to be done.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13 Travis Plunk (TravisEz13) changed the title Issue4359 amazonlinux compatibility for install-powershell.sh add amazonlinux compatibility in install-powershell.sh Aug 1, 2017
TravisEz13
Travis Plunk (TravisEz13) approved these changes Aug 1, 2017
View reviewed changes
@TravisEz13

Travis Plunk (TravisEz13) commented Aug 1, 2017

Copy link
Copy Markdown
Member

docker file submitted on #4393
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13
Travis Plunk (TravisEz13) merged commit b7b3b69 into PowerShell:master Aug 1, 2017
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@DarwinJS @TravisEz13
add amazonlinux compatibility in install-powershell.sh (PowerShell#4360)
66b15b0 
* Updated to support amazon linux (centos variant)

* Updated to support amazon linux (centos variant)

* Updated to support amazon linux (centos variant)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@DarwinJS @msftclas @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.