GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — ensure running `powershell` within PowerShell starts instance of currently running PowerShell by SteveL-MSFT · Pull Request #4481 · PowerShell/PowerShell

Conversation

Steve Lee (SteveL-MSFT) commented Aug 3, 2017

Copy link

Copy Markdown

Member

modify PATH env var at startup so that $PSHOME is in front

Fix #4194

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          ensure running powershell within PowerShell starts instance of curr…

97e2791

…ently running PowerShell

modify PATH env var at startup so that $PSHOME is in front

Steve Lee (SteveL-MSFT) assigned Dongbo Wang (daxian-dbw)

Aug 3, 2017

Steve Lee (SteveL-MSFT) requested a review from Dongbo Wang (daxian-dbw)

August 3, 2017 17:54

Microsoft Contribution License Agreements (msftclas) added the cla-not-required label

Aug 3, 2017

Dongbo Wang (daxian-dbw) requested changes

Aug 3, 2017

View reviewed changes

Comment thread

src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHost.cs

		if (!Platform.IsWindows)
		{
		pathSeparator = ":";
		}

Dongbo Wang (daxian-dbw) Aug 3, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use Path.PathSeparator.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Steve Lee (SteveL-MSFT) Aug 3, 2017

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHost.cs Outdated

		pathSeparator = ":";
		}
		string pshome = Utils.DefaultPowerShellAppBase;
		path.Replace(pathSeparator + pshome, "");

Dongbo Wang (daxian-dbw) Aug 3, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Steve Lee (SteveL-MSFT) Aug 3, 2017

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that the PWD got appended to the end of PATH so I didn't want it on both ends, looks like that isn't the case. I'll remove.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHost.cs Outdated

		}
		string pshome = Utils.DefaultPowerShellAppBase;
		path.Replace(pathSeparator + pshome, "");
		path.Insert(0, pshome + pathSeparator);

Dongbo Wang (daxian-dbw) Aug 3, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check if the first path in $env:PATH is pshome, and only insert if it's not. Otherwise, the nested powershell instance will have 2 pshome paths in $env:PATH

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Steve Lee (SteveL-MSFT) Aug 3, 2017

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          address PR feedback

e59aca1

Dongbo Wang (daxian-dbw) approved these changes

Aug 4, 2017

View reviewed changes

Dongbo Wang (daxian-dbw) left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Dongbo Wang (daxian-dbw) merged commit d17aaad into PowerShell:master

Aug 4, 2017

Ilya (iSazonov) reviewed

Aug 6, 2017

View reviewed changes

Comment thread

src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHost.cs

		}
		#endif

		// put PSHOME in front of PATH so that calling `powershell` within `powershell` always starts the same running version

Ilya (iSazonov) Aug 6, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right for other applications?
I would prefer more deterministic [System.Diagnostics.Process]::GetCurrentProcess().MainModule.FileName. (Related Improve experience for side-by-side versions of PowerShell #4199 . What about Start-PowerShell cmdlet?)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Steve Lee (SteveL-MSFT) deleted the powershell-path branch

August 6, 2017 20:03

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request

Aug 6, 2026


          Ensure running powershell within PowerShell starts instance of curr…

867213d

…ently running PowerShell (PowerShell#4481)

Modify PATH env var at startup so that $PSHOME is in front

Reviewers

Ilya (iSazonov)

iSazonov left review comments

Dongbo Wang (daxian-dbw)

daxian-dbw approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Steve Lee (SteveL-MSFT) commented Aug 3, 2017

Uh oh!

Dongbo Wang (daxian-dbw) Aug 3, 2017

Choose a reason for hiding this comment

Uh oh!

Steve Lee (SteveL-MSFT) Aug 3, 2017

Choose a reason for hiding this comment

Uh oh!

Dongbo Wang (daxian-dbw) Aug 3, 2017

Choose a reason for hiding this comment

Uh oh!

Steve Lee (SteveL-MSFT) Aug 3, 2017

Choose a reason for hiding this comment

Uh oh!

Dongbo Wang (daxian-dbw) Aug 3, 2017

Choose a reason for hiding this comment

Uh oh!

Steve Lee (SteveL-MSFT) Aug 3, 2017

Choose a reason for hiding this comment

Uh oh!

Dongbo Wang (daxian-dbw) left a comment

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) Aug 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Ilya (iSazonov) Aug 6, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.