GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add ability to package non-release packages by TravisEz13 · Pull Request #4509 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Aug 5, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

For certain testing, we need builds with symbols. Adding the ability to package builds with symbols for this purpose

I enabled for all packaging types except AppImage.

I forced the option to add symbols into the package name, except for Release/Linux (the Linux Release configuration). This will allow this special package type to be easily identified.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13 Travis Plunk (TravisEz13) added the WG-Maintainers-Build specific to affecting the build label Aug 5, 2017
@TravisEz13
Travis Plunk (TravisEz13) requested a review from Aditya Patwardhan (adityapatwardhan) August 5, 2017 16:30
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label Aug 5, 2017
@TravisEz13 Travis Plunk (TravisEz13) assigned Dongbo Wang (daxian-dbw) Aug 5, 2017
daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Aug 7, 2017
View reviewed changes
Comment thread src/powershell-unix/powershell-unix.csproj Outdated

@daxian-dbw Dongbo Wang (daxian-dbw) Aug 7, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe .NET CLI generates portable pdb by default on Linux/OSX. See https://github.com/OmniSharp/omnisharp-vscode/wiki/Portable-PDBs#how-to-generate-portable-pdbs.
So the LinuxDebug may not be necessary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Aug 7, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, even for Windows the PDBs that are generated are portable. Hence, for code coverage we explicitly make the DebugType as full, which is Windows style full PDBs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TravisEz13 Travis Plunk (TravisEz13) Aug 7, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

PS > dir  ./powershell/src/powershell-unix/bin/Linux/netcoreapp2.0/osx.10.12-x64/publish/*.pdb -Recurse          


    Directory: /Users/travisplunk/git/powershell/src/powershell-unix/bin/Linux/netcoreapp2.0/osx.10.12-x64/publish


Mode                LastWriteTime         Length Name                                                                                                                 
----                -------------         ------ ----                                                                                                                 
------           8/7/17   9:57 AM            236 Microsoft.PowerShell.SDK.pdb                                                                                         
------           8/7/17   9:57 AM            488 powershell.pdb                                                                                                       


PS > dir  ./src/powershell-unix/bin/LinuxDebug/netcoreapp2.0/osx.10.12-x64/publish/*.pdb -Recurse     


    Directory: /Users/travisplunk/git/powershell/src/powershell-unix/bin/LinuxDebug/netcoreapp2.0/osx.10.12-x64/publish


Mode                LastWriteTime         Length Name                                                                                                                 
----                -------------         ------ ----                                                                                                                 
------           8/5/17   9:10 AM         184768 Microsoft.PowerShell.Commands.Management.pdb                                                                         
------           8/5/17   9:10 AM         242416 Microsoft.PowerShell.Commands.Utility.pdb                                                                            
------           8/5/17   9:10 AM          78996 Microsoft.PowerShell.ConsoleHost.pdb                                                                                 
------           8/5/17   9:10 AM          29848 Microsoft.PowerShell.CoreCLR.AssemblyLoadContext.pdb                                                                 
------           8/5/17   9:10 AM          39696 Microsoft.PowerShell.CoreCLR.Eventing.pdb                                                                            
------           8/5/17   9:10 AM          87268 Microsoft.PowerShell.PSReadLine.pdb                                                                                  
------           8/5/17   9:10 AM            236 Microsoft.PowerShell.SDK.pdb                                                                                         
------           8/5/17   9:10 AM          42868 Microsoft.PowerShell.Security.pdb                                                                                    
------           8/5/17  11:42 AM            488 powershell.pdb                                                                                                       
------           8/5/17   9:10 AM        2916020 System.Management.Automation.pdb

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TravisEz13 Travis Plunk (TravisEz13) Aug 7, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they are generated, they are not included in the publish directory.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@daxian-dbw Dongbo Wang (daxian-dbw) Aug 8, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are generated. However, when specifying -Crossgen, those .pdb files will be removed during Start-Crossgen.
For the same reason, you shouldn't specify -Crossgen when packing debug packages.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Aug 7, 2017
View reviewed changes
Comment thread tools/packaging/packaging.psm1 Outdated

@daxian-dbw Dongbo Wang (daxian-dbw) Aug 7, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to double check -- we don't change the existing names of the release packages, right?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TravisEz13 Travis Plunk (TravisEz13) Aug 7, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but, I'll update this code, as when I wrote it I assumed Release was the only Release configuration

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) previously requested changes Aug 7, 2017
View reviewed changes
Comment thread src/powershell-unix/powershell-unix.csproj Outdated

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Aug 7, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, even for Windows the PDBs that are generated are portable. Hence, for code coverage we explicitly make the DebugType as full, which is Windows style full PDBs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Travis Plunk (TravisEz13) added 2 commits August 8, 2017 11:06
@TravisEz13
Make package name a parameter to the project
7dd67a5
@TravisEz13
Add -IncludeSymbols to start-pspackaging
3bfa807
@TravisEz13
Travis Plunk (TravisEz13) force-pushed the DebugPackages branch from 82b6d30 to 3bfa807 Compare August 8, 2017 18:37
@TravisEz13

Travis Plunk (TravisEz13) commented Aug 8, 2017

Copy link
Copy Markdown
Member Author

I changed this to only allow packaging with symbols for now by removing crossgen from the build. I've updated the PR Description.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw
Align the comment with other comments
b72aadf
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Aug 8, 2017
View reviewed changes
@daxian-dbw
Dongbo Wang (daxian-dbw) dismissed Aditya Patwardhan (adityapatwardhan)’s stale review August 8, 2017 22:31

new commits were pushed.

@daxian-dbw

Dongbo Wang (daxian-dbw) commented Aug 8, 2017

Copy link
Copy Markdown
Member

Aditya Patwardhan (@adityapatwardhan) The comments are addressed. Can you please take another look?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Aug 9, 2017

Copy link
Copy Markdown
Member Author

Aditya Patwardhan (@adityapatwardhan) any update?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Aug 9, 2017
View reviewed changes

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 8bf386e into PowerShell:master Aug 9, 2017
@TravisEz13
Travis Plunk (TravisEz13) deleted the DebugPackages branch August 9, 2017 22:41
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13 @daxian-dbw
Add ability to package non-release packages (PowerShell#4509)
4fc0ccb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

WG-Maintainers-Build specific to affecting the build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@TravisEz13 @daxian-dbw @adityapatwardhan @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.